mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nadi Ke <kenadicanady@gmail.com>
To: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, orsonzhai@gmail.com,
	baolin.wang@linux.alibaba.com
Cc: zhang.lyra@gmail.com, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Nadi Ke <kenadicanady@gmail.com>
Subject: [PATCH v2 0/2] clk: sprd: Add support for Unisoc SC9832E clocks
Date: Wed, 21 Jan 2026 15:14:10 +0800	[thread overview]
Message-ID: <20260121071412.256215-1-kenadicanady@gmail.com> (raw)

The SC9832E clock architecture involves several PLLs and gates. Some gate
clocks are located within the PMU global register area.

** Author Email Change **
Please note that my previous email address (kanadenady@gmail.com) is no
longer accessible. I am submitting this version from my new address
(kenadicanady@gmail.com). I am the same author as the previous submission.
Please update your records accordingly.

** Technical Details **
Based on the review comments from v1, I have significantly refactored the
handling of the PMU gate clocks. The hardware registers for these gates are
scattered within the PMU global register space (interleaved with other
system controls) and do not form a contiguous region.

To correctly model this hardware:
1. I removed the artificial child node (`sprd,sc9832e-pmu-gate`) which lacked
   a valid `reg` property.
2. The parent syscon node (`sprd,sc9832e-glbregs`) is now defined as the
   clock provider.
3. The driver has been updated to match the syscon compatible string directly.

Verified on SC9832E hardware, clk_summary shows correct PLL rates and
clock tree topology.

Changes in v2:
- dt-bindings:
  - Removed the artificial 'sprd,sc9832e-pmu-gate' child node definition.
  - Added '#clock-cells' to the 'sprd,sc9832e-glbregs' node definition.
  - Removed 'simple-mfd' from the parent node in the example to reflect
    that the child node (if present in dts) is logical and shares resources,
    or that the parent acts as the provider.
  - Simplified 'allOf' logic by merging similar conditions.
  - Added mock clock definitions in the example to fix dt_binding_check warnings.
  - Fixed 'compatible' array definition in the example to match schema.

- clk driver:
  - Updated the OF match table to match 'sprd,sc9832e-glbregs' instead of
    the removed child node compatible string.
  - Fixed a compilation error due to a typo in variable names.
  - Updated Author email address.

Nadi Ke (2):
  Add device tree bindings for Spreadtrum/Unisoc SC9832E clock
    controller.
  Add clock driver for Spreadtrum/Unisoc SC9832E SoC.

 .../bindings/clock/sprd,sc9832e-clk.yaml      |  182 +++
 drivers/clk/sprd/Kconfig                      |   10 +
 drivers/clk/sprd/Makefile                     |    1 +
 drivers/clk/sprd/sc9832e-clk.c                | 1077 +++++++++++++++++
 include/dt-bindings/clock/sprd,sc9832e-clk.h  |  177 +++
 5 files changed, 1447 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/sprd,sc9832e-clk.yaml
 create mode 100644 drivers/clk/sprd/sc9832e-clk.c
 create mode 100644 include/dt-bindings/clock/sprd,sc9832e-clk.h

-- 
2.34.1


             reply	other threads:[~2026-01-21  7:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21  7:14 Nadi Ke [this message]
2026-01-21  7:14 ` [PATCH v2 1/2] dt-bindings: clock: sprd: add SC9832E clock controller Nadi Ke
2026-01-22  8:01   ` Krzysztof Kozlowski
2026-01-21  7:14 ` [PATCH v2 2/2] Add clock driver for Unisoc SC9832E SoC Nadi Ke
2026-01-23 18:50   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260121071412.256215-1-kenadicanady@gmail.com \
    --to=kenadicanady@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=orsonzhai@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®