[PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[Carl Lee via B4 Relay]

From: Carl Lee <carl.lee@amd.com>

Add device type support for MPQ8786

Signed-off-by: Carl Lee <carl.lee@amd.com>
---
 Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
index 90970a0433e9..aec7397a29f9 100644
--- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
@@ -19,6 +19,7 @@ properties:
       - mps,mpm3695-25
       - mps,mpm82504
       - mps,mpq8785
+      - mps,mpq8786
 
   reg:
     maxItems: 1
@@ -52,7 +53,9 @@ allOf:
   - if:
       properties:
         compatible:
-          const: mps,mpq8785
+          enum:
+            - mps,mpq8785
+            - mps,mpq8786
     then:
       properties:
         mps,vout-fb-divider-ratio-permille:

---
base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
change-id: 20260203-dt-bindings-hwmon-pmbus-mpq8785-add-mpq8786-support-f48049e8411e

Best regards,
-- 
Carl Lee <carl.lee@amd.com>

Re: [PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

On Tue, Feb 03, 2026 at 04:15:18PM +0800, Carl Lee via B4 Relay wrote:
> From: Carl Lee <carl.lee@amd.com>
> 
> Add device type support for MPQ8786

This doesn't seem very helpful on it's own, where's the corresponding
driver change?

> 
> Signed-off-by: Carl Lee <carl.lee@amd.com>
> ---
>  Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> index 90970a0433e9..aec7397a29f9 100644
> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
> @@ -19,6 +19,7 @@ properties:
>        - mps,mpm3695-25
>        - mps,mpm82504
>        - mps,mpq8785
> +      - mps,mpq8786
>  
>    reg:
>      maxItems: 1
> @@ -52,7 +53,9 @@ allOf:
>    - if:
>        properties:
>          compatible:
> -          const: mps,mpq8785
> +          enum:
> +            - mps,mpq8785
> +            - mps,mpq8786
>      then:
>        properties:
>          mps,vout-fb-divider-ratio-permille:
> 
> ---
> base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
> change-id: 20260203-dt-bindings-hwmon-pmbus-mpq8785-add-mpq8786-support-f48049e8411e
> 
> Best regards,
> -- 
> Carl Lee <carl.lee@amd.com>
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[Guenter Roeck]

On 2/4/26 09:52, Conor Dooley wrote:
> On Tue, Feb 03, 2026 at 04:15:18PM +0800, Carl Lee via B4 Relay wrote:
>> From: Carl Lee <carl.lee@amd.com>
>>
>> Add device type support for MPQ8786
> 
> This doesn't seem very helpful on it's own, where's the corresponding
> driver change?
> 
For whatever reason not sent as series.

https://patchwork.kernel.org/project/linux-hwmon/patch/20260203-hwmon-pmbus-mpq8785-add-support-for-mpq8786-v1-1-9ff8c7c50242@amd.com/

Guenter

>>
>> Signed-off-by: Carl Lee <carl.lee@amd.com>
>> ---
>>   Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> index 90970a0433e9..aec7397a29f9 100644
>> --- a/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/mps,mpq8785.yaml
>> @@ -19,6 +19,7 @@ properties:
>>         - mps,mpm3695-25
>>         - mps,mpm82504
>>         - mps,mpq8785
>> +      - mps,mpq8786
>>   
>>     reg:
>>       maxItems: 1
>> @@ -52,7 +53,9 @@ allOf:
>>     - if:
>>         properties:
>>           compatible:
>> -          const: mps,mpq8785
>> +          enum:
>> +            - mps,mpq8785
>> +            - mps,mpq8786
>>       then:
>>         properties:
>>           mps,vout-fb-divider-ratio-permille:
>>
>> ---
>> base-commit: 4c87cdd0328495759f6e9f9f4e1e53ef8032a76f
>> change-id: 20260203-dt-bindings-hwmon-pmbus-mpq8785-add-mpq8786-support-f48049e8411e
>>
>> Best regards,
>> -- 
>> Carl Lee <carl.lee@amd.com>
>>
>>

RE: [PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[Lee, Carl]

[AMD Proprietary]

sorry for the confusion.

I didn't realize before that driver patches should be sent as part of the same series,
while DT binding updates should be submitted later.
The corresponding driver patch is available here:
https://lore.kernel.org/all/20260203-hwmon-pmbus-mpq8785-add-support-for-mpq8786-v1-1-9ff8c7c50242@amd.com/

Please let me know if you would prefer this to be resent properly as a series.

Re: [PATCH] dt-bindings: hwmon: pmbus: mpq8785: add MPQ8786 support

[Guenter Roeck]

On 2/4/26 19:32, Lee, Carl wrote:
> [AMD Proprietary]
> 
> sorry for the confusion.
> 
> I didn't realize before that driver patches should be sent as part of the same series,
> while DT binding updates should be submitted later.

Patches should be sent as series, with the devicetree patch as _first_ patch
of the series (_not_ later).

Guenter

> The corresponding driver patch is available here:
> https://lore.kernel.org/all/20260203-hwmon-pmbus-mpq8785-add-support-for-mpq8786-v1-1-9ff8c7c50242@amd.com/
> 
> Please let me know if you would prefer this to be resent properly as a series.