From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
Jonathan Santos <Jonathan.Santos@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Jonathan Santos <Jonathan.Santos@analog.com>,
Michael.Hennerich@analog.com, lars@metafoo.de, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org
Subject: Re: [PATCH 3/3] iio: adc: ad7768-1: add support for SPI offload
Date: Thu, 5 Feb 2026 09:03:14 +0300 [thread overview]
Message-ID: <202602051234.5gArzLyZ-lkp@intel.com> (raw)
In-Reply-To: <9f9aedbe374461e48f1f1e64d5487b5b6c1fc992.1769889074.git.Jonathan.Santos@analog.com>
Hi Jonathan,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Santos/iio-adc-ad7768-1-fix-one-shot-mode-data-acquisition/20260204-203950
base: d820183f371d9aa8517a1cd21fe6edacf0f94b7f
patch link: https://lore.kernel.org/r/9f9aedbe374461e48f1f1e64d5487b5b6c1fc992.1769889074.git.Jonathan.Santos%40analog.com
patch subject: [PATCH 3/3] iio: adc: ad7768-1: add support for SPI offload
config: x86_64-randconfig-161-20260205 (https://download.01.org/0day-ci/archive/20260205/202602051234.5gArzLyZ-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch version: v0.5.0-8994-gd50c5a4c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202602051234.5gArzLyZ-lkp@intel.com/
New smatch warnings:
drivers/iio/adc/ad7768-1.c:1789 ad7768_spi_offload_probe() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +1789 drivers/iio/adc/ad7768-1.c
0cac6d2893a658 Jonathan Santos 2026-01-31 1758 static int ad7768_spi_offload_probe(struct iio_dev *indio_dev,
0cac6d2893a658 Jonathan Santos 2026-01-31 1759 struct ad7768_state *st)
0cac6d2893a658 Jonathan Santos 2026-01-31 1760 {
0cac6d2893a658 Jonathan Santos 2026-01-31 1761 struct device *dev = &st->spi->dev;
0cac6d2893a658 Jonathan Santos 2026-01-31 1762 struct spi_offload_trigger_info trigger_info = {
0cac6d2893a658 Jonathan Santos 2026-01-31 1763 .fwnode = dev_fwnode(dev),
0cac6d2893a658 Jonathan Santos 2026-01-31 1764 .ops = &ad7768_offload_trigger_ops,
0cac6d2893a658 Jonathan Santos 2026-01-31 1765 .priv = st,
0cac6d2893a658 Jonathan Santos 2026-01-31 1766 };
0cac6d2893a658 Jonathan Santos 2026-01-31 1767 struct dma_chan *rx_dma;
0cac6d2893a658 Jonathan Santos 2026-01-31 1768 int ret;
0cac6d2893a658 Jonathan Santos 2026-01-31 1769
0cac6d2893a658 Jonathan Santos 2026-01-31 1770 ret = devm_spi_offload_trigger_register(dev, &trigger_info);
0cac6d2893a658 Jonathan Santos 2026-01-31 1771 if (ret)
0cac6d2893a658 Jonathan Santos 2026-01-31 1772 return dev_err_probe(dev, ret,
0cac6d2893a658 Jonathan Santos 2026-01-31 1773 "failed to register offload trigger\n");
0cac6d2893a658 Jonathan Santos 2026-01-31 1774
0cac6d2893a658 Jonathan Santos 2026-01-31 1775 st->offload_trigger = devm_spi_offload_trigger_get(dev, st->offload,
0cac6d2893a658 Jonathan Santos 2026-01-31 1776 SPI_OFFLOAD_TRIGGER_DATA_READY);
0cac6d2893a658 Jonathan Santos 2026-01-31 1777 if (IS_ERR(st->offload_trigger))
0cac6d2893a658 Jonathan Santos 2026-01-31 1778 return dev_err_probe(dev, PTR_ERR(st->offload_trigger),
0cac6d2893a658 Jonathan Santos 2026-01-31 1779 "failed to get offload trigger\n");
0cac6d2893a658 Jonathan Santos 2026-01-31 1780
0cac6d2893a658 Jonathan Santos 2026-01-31 1781 rx_dma = devm_spi_offload_rx_stream_request_dma_chan(dev, st->offload);
0cac6d2893a658 Jonathan Santos 2026-01-31 1782 if (IS_ERR(rx_dma))
0cac6d2893a658 Jonathan Santos 2026-01-31 1783 return dev_err_probe(dev, PTR_ERR(rx_dma),
0cac6d2893a658 Jonathan Santos 2026-01-31 1784 "failed to get offload RX DMA\n");
0cac6d2893a658 Jonathan Santos 2026-01-31 1785
0cac6d2893a658 Jonathan Santos 2026-01-31 1786 ret = devm_iio_dmaengine_buffer_setup_with_handle(dev, indio_dev,
0cac6d2893a658 Jonathan Santos 2026-01-31 1787 rx_dma, IIO_BUFFER_DIRECTION_IN);
0cac6d2893a658 Jonathan Santos 2026-01-31 1788 if (ret)
0cac6d2893a658 Jonathan Santos 2026-01-31 @1789 return dev_err_probe(dev, PTR_ERR(rx_dma),
s/PTR_ERR(rx_dma)/ret/
0cac6d2893a658 Jonathan Santos 2026-01-31 1790 "failed to setup offload RX DMA\n");
0cac6d2893a658 Jonathan Santos 2026-01-31 1791
0cac6d2893a658 Jonathan Santos 2026-01-31 1792 indio_dev->setup_ops = &ad7768_offload_buffer_ops;
0cac6d2893a658 Jonathan Santos 2026-01-31 1793 st->offload_en = true;
0cac6d2893a658 Jonathan Santos 2026-01-31 1794
0cac6d2893a658 Jonathan Santos 2026-01-31 1795 return 0;
0cac6d2893a658 Jonathan Santos 2026-01-31 1796 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-02-05 6:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 1:35 [PATCH 0/3] " Jonathan Santos
2026-02-01 1:35 ` [PATCH 1/3] iio: adc: ad7768-1: fix one-shot mode data acquisition Jonathan Santos
2026-02-07 16:48 ` Jonathan Cameron
2026-02-09 21:38 ` Jonathan Santos
2026-02-14 14:47 ` Jonathan Cameron
2026-02-01 1:35 ` [PATCH 2/3] iio: adc: ad7768-1: prevent one-shot mode with wideband filter Jonathan Santos
2026-02-04 16:11 ` Nuno Sá
2026-02-02 22:41 ` Jonathan Santos
2026-02-01 1:35 ` [PATCH 3/3] iio: adc: ad7768-1: add support for SPI offload Jonathan Santos
2026-02-04 14:09 ` Andy Shevchenko
2026-02-04 15:38 ` David Lechner
2026-02-05 5:42 ` kernel test robot
2026-02-05 6:03 ` Dan Carpenter [this message]
2026-02-05 6:44 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602051234.5gArzLyZ-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=Jonathan.Santos@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®