From: "Derek J. Clark" <derekjohn.clark@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
Armin Wolf <W_Armin@gmx.de>, Jonathan Corbet <corbet@lwn.net>,
Rong Zhang <i@rong.moe>, Kurt Borja <kuurtb@gmail.com>,
"Derek J . Clark" <derekjohn.clark@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/6] platform-x86: lenovo-wmi-other: Consolidate name into single const
Date: Sun, 15 Feb 2026 06:12:58 +0000 [thread overview]
Message-ID: <20260215061339.2842486-6-derekjohn.clark@gmail.com> (raw)
In-Reply-To: <20260215061339.2842486-1-derekjohn.clark@gmail.com>
In the next patch a power supply extension is added which requires
a name attribute. Instead of creating a third const macro with the
same information, replace LWMI_OM_FW_ATTR_BASE_PATH and
LWMI_OM_HWMON_NAME with LWMI_OM_NAME and use that everywhere.
Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
---
drivers/platform/x86/lenovo/wmi-other.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c
index 876834af838e0..8e52f692f8605 100644
--- a/drivers/platform/x86/lenovo/wmi-other.c
+++ b/drivers/platform/x86/lenovo/wmi-other.c
@@ -92,14 +92,13 @@ enum lwmi_feature_id_gpu {
#define LWMI_FAN_NR 4
#define LWMI_FAN_ID(x) ((x) + LWMI_FAN_ID_BASE)
+#define LWMI_FAN_DIV 100
+
#define LWMI_ATTR_ID_FAN_RPM(x) \
LWMI_ATTR_ID(LWMI_DEVICE_ID_FAN, LWMI_FEATURE_ID_FAN_RPM, \
LWMI_GZ_THERMAL_MODE_NONE, LWMI_FAN_ID(x))
-#define LWMI_FAN_DIV 100
-
-#define LWMI_OM_FW_ATTR_BASE_PATH "lenovo-wmi-other"
-#define LWMI_OM_HWMON_NAME "lenovo_wmi_other"
+#define LWMI_OM_NAME "lenovo-wmi-other"
static BLOCKING_NOTIFIER_HEAD(om_chain_head);
static DEFINE_IDA(lwmi_om_ida);
@@ -454,7 +453,7 @@ static void lwmi_om_hwmon_add(struct lwmi_om_priv *priv)
}
priv->hwmon_dev = hwmon_device_register_with_info(&priv->wdev->dev,
- LWMI_OM_HWMON_NAME, priv,
+ LWMI_OM_NAME, priv,
&lwmi_om_hwmon_chip_info,
NULL);
if (IS_ERR(priv->hwmon_dev)) {
@@ -1253,8 +1252,7 @@ static int lwmi_om_fw_attr_add(struct lwmi_om_priv *priv)
priv->fw_attr_dev = device_create(&firmware_attributes_class, NULL,
MKDEV(0, 0), NULL, "%s-%u",
- LWMI_OM_FW_ATTR_BASE_PATH,
- priv->ida_id);
+ LWMI_OM_NAME, priv->ida_id);
if (IS_ERR(priv->fw_attr_dev)) {
err = PTR_ERR(priv->fw_attr_dev);
goto err_free_ida;
--
2.52.0
next prev parent reply other threads:[~2026-02-15 6:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 6:12 [PATCH v2 0/6] platform-x86: lenovo-wmi: Add fixes and enhancement Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 1/6] platform/x86: lenovo-wmi-other: Add LWMI_ATTR_ID Macro Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 2/6] platform/x86: lenovo-wmi-other: Limit adding attributes to supported devices Derek J. Clark
2026-02-17 23:54 ` Mark Pearson
2026-02-18 0:20 ` Derek J. Clark
2026-02-18 0:26 ` Mark Pearson
2026-02-15 6:12 ` [PATCH v2 3/6] platform/x86: lenovo-wmi-other: Add missing CPU tunable attributes Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 4/6] platform/x86: lenovo-wmi-other: Add GPU " Derek J. Clark
2026-02-15 6:12 ` Derek J. Clark [this message]
2026-02-15 6:56 ` [PATCH v2 5/6] platform-x86: lenovo-wmi-other: Consolidate name into single const Kurt Borja
2026-02-15 7:22 ` Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 6/6] platform/x86: lenovo-wmi-other: Add WMI battery charge limiting Derek J. Clark
2026-02-15 15:20 ` kernel test robot
2026-02-15 19:47 ` kernel test robot
2026-02-17 23:49 ` [PATCH v2 0/6] platform-x86: lenovo-wmi: Add fixes and enhancement Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260215061339.2842486-6-derekjohn.clark@gmail.com \
--to=derekjohn.clark@gmail.com \
--cc=W_Armin@gmx.de \
--cc=corbet@lwn.net \
--cc=hansg@kernel.org \
--cc=i@rong.moe \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®