From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: "Derek J . Clark" <derekjohn.clark@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Hans de Goede" <hansg@kernel.org>
Cc: "Armin Wolf" <W_Armin@gmx.de>, "Jonathan Corbet" <corbet@lwn.net>,
"Rong Zhang" <i@rong.moe>, "Kurt Borja" <kuurtb@gmail.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] platform/x86: lenovo-wmi-other: Limit adding attributes to supported devices
Date: Tue, 17 Feb 2026 18:54:09 -0500 [thread overview]
Message-ID: <d6ff122a-1ccc-422f-9c24-b95106469d9e@app.fastmail.com> (raw)
In-Reply-To: <20260215061339.2842486-3-derekjohn.clark@gmail.com>
On Sun, Feb 15, 2026, at 1:12 AM, Derek J. Clark wrote:
> Adds lwmi_is_attr_01_supported, and only creates the attribute subfolder
> if the attribute is supported by the hardware. Due to some poorly
> implemented BIOS, this is a multi-step sequence of events. This is
> because:
> - Some BIOS support getting the capability data from custom mode (0xff),
> while others only support it in no-mode (0x00).
> - Similarly, some BIOS support get/set for the current value from custom
> mode (0xff), while others only support it in no-mode (0x00).
> - Some BIOS report capability data for a method that is not fully
> implemented.
> - Some BIOS have methods fully implemented, but no complimentary
> capability data.
>
> To ensure we only expose fully implemented methods with corresponding
> capability data, we check each outcome before reporting that an
> attribute can be supported.
>
The Legion's aren't in the Linux program (with an asterisk for the Legion Go/Go2) - but if there's anywhere it's tracked or highlighted which platforms differ/have issues let me know. Not sure how widespread the issues is?
I can try and let the Legion team know that there are platforms which (likely) aren't following the internal specs. It might be possible to improve things for future platforms?
Mark
next prev parent reply other threads:[~2026-02-17 23:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-15 6:12 [PATCH v2 0/6] platform-x86: lenovo-wmi: Add fixes and enhancement Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 1/6] platform/x86: lenovo-wmi-other: Add LWMI_ATTR_ID Macro Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 2/6] platform/x86: lenovo-wmi-other: Limit adding attributes to supported devices Derek J. Clark
2026-02-17 23:54 ` Mark Pearson [this message]
2026-02-18 0:20 ` Derek J. Clark
2026-02-18 0:26 ` Mark Pearson
2026-02-15 6:12 ` [PATCH v2 3/6] platform/x86: lenovo-wmi-other: Add missing CPU tunable attributes Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 4/6] platform/x86: lenovo-wmi-other: Add GPU " Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 5/6] platform-x86: lenovo-wmi-other: Consolidate name into single const Derek J. Clark
2026-02-15 6:56 ` Kurt Borja
2026-02-15 7:22 ` Derek J. Clark
2026-02-15 6:12 ` [PATCH v2 6/6] platform/x86: lenovo-wmi-other: Add WMI battery charge limiting Derek J. Clark
2026-02-15 15:20 ` kernel test robot
2026-02-15 19:47 ` kernel test robot
2026-02-17 23:49 ` [PATCH v2 0/6] platform-x86: lenovo-wmi: Add fixes and enhancement Mark Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6ff122a-1ccc-422f-9c24-b95106469d9e@app.fastmail.com \
--to=mpearson-lenovo@squebb.ca \
--cc=W_Armin@gmx.de \
--cc=corbet@lwn.net \
--cc=derekjohn.clark@gmail.com \
--cc=hansg@kernel.org \
--cc=i@rong.moe \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®