[PATCH v4 0/4] x86/cpu: Take Intel platform into account for old microcode checks

[Dave Hansen <dave.hansen@linux.intel.com>]

Chagnes from v3:
 * Fix handling of the Pentium II's "no platform" goofiness.
   Note: this was found in a Github Copilot review of the
   series. I wrote the solution.
 * Rebase to 7.0-rc2

Changes from v2:
 * Move new helpers from .h into .c file. This avoids the
   #include dependency issues for now. That can be dealt
   with another day.
 * Rename x86_platform_id to have an intel_ prefix and add a
   union to make it clear that AMD can use the space for
   something else

Changes from v1:
 * Fix non-x86 PECI compile issues by lifting some x86 macros
   into an arch-independent header.
 * Make intel_get_platform_id() match its name and return an ID,
   not a mask.
 * Sort #includes
 * Move ->x86_platform_id comment

The platform ID vs. platform mask confusion meant that v1
worked by total accident. If you tested v1, I'd really
appreciate you retest this as well.

--

There was a report[1] that CPUs running updated microcode were being
reported as running old microcode. The reason is that the old
microcode list neglects to take the platform ID into account.

The platform ID is an Intel-only construct that allows CPUs that
otherwise have the same model/family/stepping to take different
microcode revisions. The microcode loader itself already checks this.
Only the recent "old_microcode" checker failed here.

Treat the platform ID as a peer of model/family/stepping. Store it
in 'struct cpuinfo_x86', enable matching on it with with 'struct
x86_cpu_id', and flesh out the 'old_microcode' list with it.

This fixes the report of an inaccurate, false positive in the
'old_microcode' vulnerability file.

1. https://lore.kernel.org/all/38660F8F-499E-48CD-B58B-4822228A5941@nutanix.com/

Cc: Thomas Gleixner <tglx@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
Cc: x86@kernel.org
Cc: Jon Kohler <jon@nutanix.com>

 arch/x86/include/asm/microcode.h                 |    2 
 arch/x86/include/asm/processor.h                 |    5 
 arch/x86/kernel/cpu/intel.c                      |    1 
 arch/x86/kernel/cpu/match.c                      |    3 
 arch/x86/kernel/cpu/microcode/intel-ucode-defs.h |  398 +++++++++++++----------
 arch/x86/kernel/cpu/microcode/intel.c            |   55 ++-
 include/linux/mod_devicetable.h                  |    2 
 7 files changed, 294 insertions(+), 172 deletions(-)