mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, sohil.mehta@intel.com,
	zhao1.liu@intel.com, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
	Jon Kohler <jon@nutanix.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Thomas Gleixner <tglx@kernel.org>,
	Tony Luck <tony.luck@intel.com>,
	x86@kernel.org
Subject: Re: [PATCH v4 2/4] x86/cpu: Add platform ID to CPU info structure
Date: Thu, 5 Mar 2026 10:39:44 -0800	[thread overview]
Message-ID: <dc376ea0-97f7-4e62-8463-5b5a876984b2@intel.com> (raw)
In-Reply-To: <20260305022636.pt4zt42qjiudxtbz@desk>

On 3/4/26 18:26, Pawan Gupta wrote:
> Just want to make sure that c->intel_platform_id not getting explicitly
> initialized for !CONFIG_CPU_SUP_INTEL is okay. I believe it is fine because
> the global boot_cpu_data should be zero-initialized.
> 
> I see model and stepping are being initialized in identify_cpu(), but I
> don't see any vendor specific initialization here:
> 
> identify_cpu()
> {
>         int i;
> 
>         c->loops_per_jiffy = loops_per_jiffy;
>         c->x86_cache_size = 0;
>         c->x86_vendor = X86_VENDOR_UNKNOWN;
>         c->x86_model = c->x86_stepping = 0;     /* So far unknown... */

Yeah, I believe it's OK. The model/stepping initialization is probably
unnecessary in the first place, and all of the Intel code that use the
platform IDs will have set it properly.

  reply	other threads:[~2026-03-05 18:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 18:10 [PATCH v4 0/4] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-03-04 18:10 ` [PATCH v4 1/4] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
2026-03-05  1:38   ` Pawan Gupta
2026-03-05  6:28     ` Sohil Mehta
2026-03-05 18:01       ` Pawan Gupta
2026-03-05 18:37     ` Dave Hansen
2026-03-05 13:16   ` Borislav Petkov
2026-03-05 19:07   ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28   ` tip-bot2 for Dave Hansen
2026-03-04 18:10 ` [PATCH v4 2/4] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-03-05  2:26   ` Pawan Gupta
2026-03-05 18:39     ` Dave Hansen [this message]
2026-03-05 19:07   ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28   ` tip-bot2 for Dave Hansen
     [not found]   ` <20260306004923.ln6ai2zl23gjsdov@desk>
2026-03-06  0:56     ` [PATCH v4 2/4] " Pawan Gupta
2026-03-04 18:10 ` [PATCH v4 3/4] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
2026-03-05 19:07   ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28   ` tip-bot2 for Dave Hansen
2026-03-04 18:10 ` [PATCH v4 4/4] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen
2026-03-05 19:07   ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28   ` tip-bot2 for Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc376ea0-97f7-4e62-8463-5b5a876984b2@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jon@nutanix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=sohil.mehta@intel.com \
    --cc=tglx@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome