From: Dave Hansen <dave.hansen@intel.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, sohil.mehta@intel.com,
zhao1.liu@intel.com, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jon Kohler <jon@nutanix.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>,
Tony Luck <tony.luck@intel.com>,
x86@kernel.org
Subject: Re: [PATCH v4 1/4] x86/microcode: Refactor platform ID enumeration into a helper
Date: Thu, 5 Mar 2026 10:37:45 -0800 [thread overview]
Message-ID: <9dfae93e-3949-44f2-a6f0-7650123a6443@intel.com> (raw)
In-Reply-To: <20260305013853.3riphxey733tokly@desk>
On 3/4/26 17:38, Pawan Gupta wrote:
>> +/*
>> + * Use CPUID to generate a "vfm" value. Useful
>> + * before 'cpuinfo_x86' structures are populated.
>> + */
>> +static u32 intel_cpuid_vfm(void)
>> +{
>> + u32 eax = cpuid_eax(1);
>> + u32 fam = x86_family(eax);
>> + u32 model = x86_model(eax);
> Nit, is s/eax/sig/ more clear?
>
> u32 sig = cpuid_eax(1);
> u32 fam = x86_family(sig);
> u32 model = x86_model(sig);
It's debatable. It's nice having the 'sig' explain what's in EAX. But
'sig' is pretty generic and the code is all right here anyway. I think
I'll leave it as 'eax'.
next prev parent reply other threads:[~2026-03-05 18:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 18:10 [PATCH v4 0/4] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
2026-03-04 18:10 ` [PATCH v4 1/4] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
2026-03-05 1:38 ` Pawan Gupta
2026-03-05 6:28 ` Sohil Mehta
2026-03-05 18:01 ` Pawan Gupta
2026-03-05 18:37 ` Dave Hansen [this message]
2026-03-05 13:16 ` Borislav Petkov
2026-03-05 19:07 ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28 ` tip-bot2 for Dave Hansen
2026-03-04 18:10 ` [PATCH v4 2/4] x86/cpu: Add platform ID to CPU info structure Dave Hansen
2026-03-05 2:26 ` Pawan Gupta
2026-03-05 18:39 ` Dave Hansen
2026-03-05 19:07 ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28 ` tip-bot2 for Dave Hansen
[not found] ` <20260306004923.ln6ai2zl23gjsdov@desk>
2026-03-06 0:56 ` [PATCH v4 2/4] " Pawan Gupta
2026-03-04 18:10 ` [PATCH v4 3/4] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
2026-03-05 19:07 ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28 ` tip-bot2 for Dave Hansen
2026-03-04 18:10 ` [PATCH v4 4/4] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen
2026-03-05 19:07 ` [tip: x86/microcode] " tip-bot2 for Dave Hansen
2026-03-05 20:28 ` tip-bot2 for Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9dfae93e-3949-44f2-a6f0-7650123a6443@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon@nutanix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=sohil.mehta@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®