* [PATCH 1/5] arm64: dts: exynos7870: Move I2C address/size-cells to DTSI
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
@ 2026-03-05 9:09 ` Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 2/5] arm64: dts: exynos8895: " Krzysztof Kozlowski
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-05 9:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Krzysztof Kozlowski
Convention followed in all other DTSI files is to define I2C controller
address/size-cells in the DTSI thus reducing code needed in each DTS.
It's also logical, since I2C is a bus and needs definition of addressing
children, even if the bus is enabled without the nodes.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 9 ----
arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts | 5 ---
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts | 6 ---
arch/arm64/boot/dts/exynos/exynos7870-j7xelte.dts | 3 --
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 9 ----
arch/arm64/boot/dts/exynos/exynos7870.dtsi | 48 ++++++++++++++++++++++
6 files changed, 48 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
index 6f40ca4350ed..0888cd2faca4 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
@@ -158,9 +158,6 @@ &gpu {
};
&hsi2c0 {
- #address-cells = <1>;
- #size-cells = <0>;
-
status = "okay";
pmic@66 {
@@ -394,9 +391,6 @@ vdd_ldo35: ldo35 {
};
&i2c5 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
@@ -428,9 +422,6 @@ proximity@48 {
};
&i2c6 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts
index d685bc0703cf..36c327668db5 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-j5y17lte.dts
@@ -129,8 +129,6 @@ &gpu {
&hsi2c0 {
status = "okay";
- #address-cells = <1>;
- #size-cells = <0>;
pmic@66 {
compatible = "samsung,s2mpu05-pmic";
@@ -358,9 +356,6 @@ vdd_ldo35: ldo35 {
};
&i2c2 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
index 09f2367cfec9..de30d0970336 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
@@ -383,9 +383,6 @@ vdd_ldo35: ldo35 {
};
&i2c5 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
@@ -409,9 +406,6 @@ accelerometer@1d {
};
&i2c6 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j7xelte.dts
index 1da826ca1087..079b2b581307 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-j7xelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-j7xelte.dts
@@ -334,9 +334,6 @@ vdd_ldo35: ldo35 {
};
&i2c1 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
index 29e124c72e9d..29be4764f84d 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
@@ -398,9 +398,6 @@ vdd_ldo35: ldo35 {
};
&i2c1 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
@@ -438,9 +435,6 @@ rmi4-f12@12 {
};
&i2c7 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
@@ -464,9 +458,6 @@ accelerometer@1d {
};
&i2c8 {
- #address-cells = <1>;
- #size-cells = <0>;
-
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
diff --git a/arch/arm64/boot/dts/exynos/exynos7870.dtsi b/arch/arm64/boot/dts/exynos/exynos7870.dtsi
index 2827e10d6962..19f9ae783587 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7870.dtsi
@@ -220,6 +220,9 @@ hsi2c0: i2c@10510000 {
clock-names = "hsi2c";
clocks = <&cmu_mif CLK_GOUT_MIF_HSI2C_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -422,6 +425,9 @@ i2c0: i2c@13830000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C0_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -437,6 +443,9 @@ i2c1: i2c@13840000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C1_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -452,6 +461,9 @@ i2c2: i2c@13850000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C2_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -467,6 +479,9 @@ i2c3: i2c@13860000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C3_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -482,6 +497,9 @@ i2c4: i2c@13870000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C4_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -497,6 +515,9 @@ i2c5: i2c@13880000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C5_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -512,6 +533,9 @@ i2c6: i2c@13890000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C6_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -527,6 +551,9 @@ hsi2c1: i2c@138a0000 {
clock-names = "hsi2c";
clocks = <&cmu_peri CLK_GOUT_PERI_HSI2C1_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -542,6 +569,9 @@ hsi2c2: i2c@138b0000 {
clock-names = "hsi2c";
clocks = <&cmu_peri CLK_GOUT_PERI_HSI2C2_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -557,6 +587,9 @@ hsi2c3: i2c@138c0000 {
clock-names = "hsi2c";
clocks = <&cmu_peri CLK_GOUT_PERI_HSI2C3_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -572,6 +605,9 @@ i2c7: i2c@138d0000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C7_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -587,6 +623,9 @@ i2c8: i2c@138e0000 {
clock-names = "i2c";
clocks = <&cmu_peri CLK_GOUT_PERI_I2C8_PCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -602,6 +641,9 @@ hsi2c4: i2c@138f0000 {
clock-names = "hsi2c";
clocks = <&cmu_peri CLK_GOUT_PERI_HSI2C4_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -617,6 +659,9 @@ hsi2c5: i2c@13950000 {
clock-names = "hsi2c";
clocks = <&cmu_peri CLK_GOUT_PERI_HSI2C5_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -632,6 +677,9 @@ hsi2c6: i2c@13960000 {
clock-names = "hsi2c";
clocks = <&cmu_peri CLK_GOUT_PERI_HSI2C6_IPCLK>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 2/5] arm64: dts: exynos8895: Move I2C address/size-cells to DTSI
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 1/5] arm64: dts: exynos7870: Move I2C address/size-cells to DTSI Krzysztof Kozlowski
@ 2026-03-05 9:09 ` Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 3/5] ARM: dts: exynos3250: Drop duplicated I2C address/size-cells Krzysztof Kozlowski
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-05 9:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Krzysztof Kozlowski
Convention followed in all other DTSI files is to define I2C controller
address/size-cells in the DTSI thus reducing code needed in each DTS.
It's also logical, since I2C is a bus and needs definition of addressing
children, even if the bus is enabled without the nodes.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts | 2 -
arch/arm64/boot/dts/exynos/exynos8895.dtsi | 128 +++++++++++++++++++++
2 files changed, 128 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts b/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
index 61e064af3337..305dc72f93d8 100644
--- a/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos8895-dreamlte.dts
@@ -103,8 +103,6 @@ reg_placeholder: regulator-0 {
};
&hsi2c_23 {
- #address-cells = <1>;
- #size-cells = <0>;
status = "okay";
touchscreen@48 {
diff --git a/arch/arm64/boot/dts/exynos/exynos8895.dtsi b/arch/arm64/boot/dts/exynos/exynos8895.dtsi
index f92d2a8a20a2..ff114cd6c9ea 100644
--- a/arch/arm64/boot/dts/exynos/exynos8895.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos8895.dtsi
@@ -266,6 +266,10 @@ hsi2c_5: i2c@0 {
interrupts = <GIC_SPI 364 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c5_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -305,6 +309,10 @@ hsi2c_6: i2c@10000 {
interrupts = <GIC_SPI 365 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c6_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -328,6 +336,10 @@ hsi2c_7: i2c@0 {
interrupts = <GIC_SPI 368 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c5_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -367,6 +379,10 @@ hsi2c_8: i2c@10000 {
interrupts = <GIC_SPI 369 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c8_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -390,6 +406,10 @@ hsi2c_9: i2c@0 {
interrupts = <GIC_SPI 372 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c9_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -429,6 +449,10 @@ hsi2c_10: i2c@10000 {
interrupts = <GIC_SPI 373 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c10_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -452,6 +476,10 @@ hsi2c_11: i2c@0 {
interrupts = <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c11_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -491,6 +519,10 @@ hsi2c_12: i2c@10000 {
interrupts = <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c12_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -565,6 +597,10 @@ hsi2c_13: i2c@0 {
interrupts = <GIC_SPI 390 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c13_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -604,6 +640,10 @@ hsi2c_14: i2c@10000 {
interrupts = <GIC_SPI 391 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c14_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -627,6 +667,10 @@ hsi2c_15: i2c@0 {
interrupts = <GIC_SPI 394 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c15_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -666,6 +710,10 @@ hsi2c_16: i2c@10000 {
interrupts = <GIC_SPI 395 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c16_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -689,6 +737,10 @@ hsi2c_17: i2c@0 {
interrupts = <GIC_SPI 398 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c17_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -728,6 +780,10 @@ hsi2c_18: i2c@10000 {
interrupts = <GIC_SPI 399 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c18_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -751,6 +807,10 @@ hsi2c_19: i2c@0 {
interrupts = <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c19_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -790,6 +850,10 @@ hsi2c_20: i2c@10000 {
interrupts = <GIC_SPI 403 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c20_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -813,6 +877,10 @@ hsi2c_21: i2c@0 {
interrupts = <GIC_SPI 406 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c21_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -852,6 +920,10 @@ hsi2c_22: i2c@10000 {
interrupts = <GIC_SPI 407 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c22_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -875,6 +947,10 @@ hsi2c_23: i2c@0 {
interrupts = <GIC_SPI 410 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c23_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -914,6 +990,10 @@ hsi2c_24: i2c@10000 {
interrupts = <GIC_SPI 411 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c24_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -937,6 +1017,10 @@ hsi2c_25: i2c@0 {
interrupts = <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c25_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -976,6 +1060,10 @@ hsi2c_26: i2c@10000 {
interrupts = <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c26_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -999,6 +1087,10 @@ hsi2c_27: i2c@0 {
interrupts = <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c27_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -1038,6 +1130,10 @@ hsi2c_28: i2c@10000 {
interrupts = <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c28_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -1061,6 +1157,10 @@ hsi2c_29: i2c@0 {
interrupts = <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c29_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -1100,6 +1200,10 @@ hsi2c_30: i2c@10000 {
interrupts = <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c30_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -1123,6 +1227,10 @@ hsi2c_31: i2c@0 {
interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c31_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -1162,6 +1270,10 @@ hsi2c_32: i2c@10000 {
interrupts = <GIC_SPI 427 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c32_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
};
@@ -1180,6 +1292,10 @@ hsi2c_1: i2c@10990000 {
interrupts = <GIC_SPI 431 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c1_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -1191,6 +1307,10 @@ hsi2c_2: i2c@109a0000 {
interrupts = <GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c2_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -1202,6 +1322,10 @@ hsi2c_3: i2c@109b0000 {
interrupts = <GIC_SPI 433 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c3_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
@@ -1213,6 +1337,10 @@ hsi2c_4: i2c@109c0000 {
interrupts = <GIC_SPI 434 IRQ_TYPE_LEVEL_HIGH>;
pinctrl-0 = <&hsi2c4_bus>;
pinctrl-names = "default";
+
+ #address-cells = <1>;
+ #size-cells = <0>;
+
status = "disabled";
};
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 3/5] ARM: dts: exynos3250: Drop duplicated I2C address/size-cells
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 1/5] arm64: dts: exynos7870: Move I2C address/size-cells to DTSI Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 2/5] arm64: dts: exynos8895: " Krzysztof Kozlowski
@ 2026-03-05 9:09 ` Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 4/5] ARM: dts: exynos4210-smdkv310: " Krzysztof Kozlowski
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-05 9:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Krzysztof Kozlowski
The DTSI already has address/size-cells for each I2C controller, thus
the board does not have to define them again.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/samsung/exynos3250-artik5.dtsi | 2 --
arch/arm/boot/dts/samsung/exynos3250-monk.dts | 4 ----
arch/arm/boot/dts/samsung/exynos3250-rinato.dts | 4 ----
3 files changed, 10 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos3250-artik5.dtsi b/arch/arm/boot/dts/samsung/exynos3250-artik5.dtsi
index 3fdd922e635c..059c0f44e164 100644
--- a/arch/arm/boot/dts/samsung/exynos3250-artik5.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos3250-artik5.dtsi
@@ -74,8 +74,6 @@ &gpu {
};
&i2c_0 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
diff --git a/arch/arm/boot/dts/samsung/exynos3250-monk.dts b/arch/arm/boot/dts/samsung/exynos3250-monk.dts
index 68236c7297d7..d59ed46614bd 100644
--- a/arch/arm/boot/dts/samsung/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/samsung/exynos3250-monk.dts
@@ -191,8 +191,6 @@ &hsotg {
};
&i2c_0 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
@@ -414,8 +412,6 @@ buck5_reg: BUCK5 {
};
&i2c_1 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <400000>;
diff --git a/arch/arm/boot/dts/samsung/exynos3250-rinato.dts b/arch/arm/boot/dts/samsung/exynos3250-rinato.dts
index 36d2171c1ce8..fa983b732898 100644
--- a/arch/arm/boot/dts/samsung/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/samsung/exynos3250-rinato.dts
@@ -263,8 +263,6 @@ &gpu {
};
&i2c_0 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <100000>;
@@ -594,8 +592,6 @@ regulator-state-mem {
};
&i2c_1 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-slave-addr = <0x10>;
samsung,i2c-max-bus-freq = <400000>;
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 4/5] ARM: dts: exynos4210-smdkv310: Drop duplicated I2C address/size-cells
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
` (2 preceding siblings ...)
2026-03-05 9:09 ` [PATCH 3/5] ARM: dts: exynos3250: Drop duplicated I2C address/size-cells Krzysztof Kozlowski
@ 2026-03-05 9:09 ` Krzysztof Kozlowski
2026-03-05 9:09 ` [PATCH 5/5] ARM: dts: exyons4412: " Krzysztof Kozlowski
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-05 9:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Krzysztof Kozlowski
The DTSI already has address/size-cells for each I2C controller, thus
the board does not have to define them again.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
index 18f4f494093b..a6b73a8967c6 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-smdkv310.dts
@@ -68,8 +68,6 @@ map1 {
};
&i2c_0 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <100000>;
status = "okay";
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 5/5] ARM: dts: exyons4412: Drop duplicated I2C address/size-cells
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
` (3 preceding siblings ...)
2026-03-05 9:09 ` [PATCH 4/5] ARM: dts: exynos4210-smdkv310: " Krzysztof Kozlowski
@ 2026-03-05 9:09 ` Krzysztof Kozlowski
2026-03-10 16:04 ` (subset) [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
2026-03-10 16:04 ` Krzysztof Kozlowski
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-05 9:09 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel,
Krzysztof Kozlowski
The DTSI already has address/size-cells for each I2C controller, thus
the board does not have to define them again.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
arch/arm/boot/dts/samsung/exynos4412-itop-scp-core.dtsi | 2 --
arch/arm/boot/dts/samsung/exynos4412-origen.dts | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4412-itop-scp-core.dtsi b/arch/arm/boot/dts/samsung/exynos4412-itop-scp-core.dtsi
index 7bc6968af9c3..223907e5919c 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-itop-scp-core.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4412-itop-scp-core.dtsi
@@ -130,8 +130,6 @@ &hsotg {
};
&i2c_1 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <400000>;
pinctrl-0 = <&i2c1_bus>;
diff --git a/arch/arm/boot/dts/samsung/exynos4412-origen.dts b/arch/arm/boot/dts/samsung/exynos4412-origen.dts
index 10ab7bc90f50..c5fb551ab352 100644
--- a/arch/arm/boot/dts/samsung/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/samsung/exynos4412-origen.dts
@@ -113,8 +113,6 @@ &fimd {
};
&i2c_0 {
- #address-cells = <1>;
- #size-cells = <0>;
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <20000>;
pinctrl-0 = <&i2c0_bus>;
--
2.51.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: (subset) [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
` (4 preceding siblings ...)
2026-03-05 9:09 ` [PATCH 5/5] ARM: dts: exyons4412: " Krzysztof Kozlowski
@ 2026-03-10 16:04 ` Krzysztof Kozlowski
2026-03-10 16:04 ` Krzysztof Kozlowski
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-10 16:04 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Thu, 05 Mar 2026 10:09:23 +0100, Krzysztof Kozlowski wrote:
> No functional impact expected.
>
> Best regards,
> Krzysztof
>
Applied, thanks!
[3/5] ARM: dts: exynos3250: Drop duplicated I2C address/size-cells
https://git.kernel.org/krzk/linux/c/cb243c21bbe14739406b5be680c850cdf20c9739
[4/5] ARM: dts: exynos4210-smdkv310: Drop duplicated I2C address/size-cells
https://git.kernel.org/krzk/linux/c/7c40913bc532f3645c522a89886070a08b1ad23b
[5/5] ARM: dts: exyons4412: Drop duplicated I2C address/size-cells
https://git.kernel.org/krzk/linux/c/44ee52a030a6dd2f6e0ecb3632ecf8b263114619
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: (subset) [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells
2026-03-05 9:09 [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
` (5 preceding siblings ...)
2026-03-10 16:04 ` (subset) [PATCH 0/5] ARM: dts: exynos: Cleanup I2C address-cells and size-cells Krzysztof Kozlowski
@ 2026-03-10 16:04 ` Krzysztof Kozlowski
6 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-10 16:04 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alim Akhtar,
Krzysztof Kozlowski
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel
On Thu, 05 Mar 2026 10:09:23 +0100, Krzysztof Kozlowski wrote:
> No functional impact expected.
>
> Best regards,
> Krzysztof
>
Applied, thanks!
[1/5] arm64: dts: exynos7870: Move I2C address/size-cells to DTSI
https://git.kernel.org/krzk/linux/c/41dadc6f78150b7bf0308269fba7ba8a1a516392
[2/5] arm64: dts: exynos8895: Move I2C address/size-cells to DTSI
https://git.kernel.org/krzk/linux/c/90f771a9745476a5e2b95b5efe225a943c090bb9
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread