* [PATCH] staging: media: atomisp: split long line in sh_css_sp.c
@ 2026-03-11 8:43 Muhammad Shadab Khan
2026-03-11 9:41 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Shadab Khan @ 2026-03-11 8:43 UTC (permalink / raw)
To: hansg, mchehab, sakari.ailus, andy, gregkh, linux-media,
linux-kernel, linux-staging
Cc: Muhammad Shadab Khan
Split a long line exceeding 100 characters to comply with
Linux kernel coding style guidelines.
Signed-off-by: Muhammad Shadab Khan <shadabtg4@gmail.com>
---
drivers/staging/media/atomisp/pci/sh_css_sp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c
index 6da151e7a873..c38a7c69728b 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_sp.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c
@@ -983,7 +983,9 @@ sh_css_sp_init_stage(struct ia_css_binary *binary,
IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
}
ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
- sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
+ sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id,
+ mmgr_EXCEPTION,
+ IA_CSS_BUFFER_TYPE_METADATA);
if (err)
return err;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: atomisp: split long line in sh_css_sp.c
2026-03-11 8:43 [PATCH] staging: media: atomisp: split long line in sh_css_sp.c Muhammad Shadab Khan
@ 2026-03-11 9:41 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2026-03-11 9:41 UTC (permalink / raw)
To: Muhammad Shadab Khan
Cc: hansg, mchehab, andy, gregkh, linux-media, linux-kernel, linux-staging
Hi Huhammad,
On Wed, Mar 11, 2026 at 02:13:18PM +0530, Muhammad Shadab Khan wrote:
> Split a long line exceeding 100 characters to comply with
> Linux kernel coding style guidelines.
>
> Signed-off-by: Muhammad Shadab Khan <shadabtg4@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/sh_css_sp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c
> index 6da151e7a873..c38a7c69728b 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c
> @@ -983,7 +983,9 @@ sh_css_sp_init_stage(struct ia_css_binary *binary,
> IA_CSS_BUFFER_TYPE_DIS_STATISTICS);
> }
> ia_css_query_internal_queue_id(IA_CSS_BUFFER_TYPE_METADATA, thread_id, &queue_id);
> - sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id, mmgr_EXCEPTION, IA_CSS_BUFFER_TYPE_METADATA);
> + sh_css_copy_buffer_attr_to_spbuffer(&sh_css_sp_stage.frames.metadata_buf, queue_id,
That limit is actually 80... so you could wrap at a different location.
Are there no other such cases in the driver?
> + mmgr_EXCEPTION,
> + IA_CSS_BUFFER_TYPE_METADATA);
> if (err)
> return err;
>
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-11 9:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-11 8:43 [PATCH] staging: media: atomisp: split long line in sh_css_sp.c Muhammad Shadab Khan
2026-03-11 9:41 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®