Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]

On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
> This commit adds regulator properties for vcnl4000 ambient light and
> proximity sensors.

This we can see. Your commit message should say why.

Do all devices in the binding have all of these supplies?

> 
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> index 2ba4d5de4ec4..a1b4c02db246 100644
> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> @@ -33,6 +33,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  vdd-supply: true
> +  vddio-supply: true
> +  vled-supply: true
> +
>    reg:
>      maxItems: 1
>  
> @@ -54,6 +58,9 @@ examples:
>              compatible = "vishay,vcnl4200";
>              reg = <0x51>;
>              proximity-near-level = <220>;
> +            vdd-supply = <&reg_vdd>;
> +            vddio-supply = <&reg_vddio>;
> +            vled-supply = <&reg_vled>;
>          };
>      };
>  ...
> 
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]