Re: [PATCH v2 3/3] iio: light: vcnl4000: move client->dev in probe into a variable

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Mar 12, 2026 at 01:53:14PM +0200, Erikas Bitovtas wrote:
> Move client->dev into a variable of its own and replace all instances of
> client->dev being used by it.

...

> +	struct device *dev = &client->dev;

This should be done in the previous patch to reduce churn...


> -	ret = devm_regulator_bulk_get_enable(&client->dev,
> +	ret = devm_regulator_bulk_get_enable(dev,

...like this one.

>  				      ARRAY_SIZE(regulator_names),
>  				      regulator_names);

...

> +		ret = devm_request_threaded_irq(dev, client->irq, NULL,
> +						data->chip_spec->irq_thread,
>  						IRQF_TRIGGER_FALLING |
>  						IRQF_ONESHOT,
>  						"vcnl4000_irq",
>  						indio_dev);

>  		if (ret < 0) {
> -			dev_err(&client->dev, "irq request failed\n");
> +			dev_err(dev, "irq request failed\n");
>  			return ret;
>  		}

This should be another patch to remove the dup message completely before doing
struct device conversion.

-- 
With Best Regards,
Andy Shevchenko