From: Conor Dooley <conor@kernel.org>
To: Erikas Bitovtas <xerikasxx@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators
Date: Fri, 13 Mar 2026 16:51:50 +0000 [thread overview]
Message-ID: <20260313-reputably-pregame-ba41c3c1438a@spud> (raw)
In-Reply-To: <3d27945a-639d-4c3d-969f-2ec23bdd9900@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]
On Fri, Mar 13, 2026 at 06:39:25PM +0200, Erikas Bitovtas wrote:
>
>
> On 3/12/26 7:39 PM, Conor Dooley wrote:
> > On Thu, Mar 12, 2026 at 01:53:12PM +0200, Erikas Bitovtas wrote:
> >> This commit adds regulator properties for vcnl4000 ambient light and
> >> proximity sensors.
> >
> > This we can see. Your commit message should say why.
> >
> > Do all devices in the binding have all of these supplies?
> >
>
> If we look at the datasheet for vcnl4040,
> https://www.vishay.com/docs/84274/vcnl4040.pdf, in figure 11 we can see
> that there can be 3 supplies: sensor supply Vdd (vdd), I2C supply for
> the bus Vpull_up (vddio) and IR LED anode Vdd_led (vled).
> The other datasheets refer to three supplies as well - one for the
> sensor, one for anode and one for the bus:
> https://www.vishay.com/docs/83372/vcnl4000.pdf
> https://www.vishay.com/docs/84138/designingvcnl4010.pdf
> https://www.vishay.com/docs/84327/designingvcnl4200.pdf
Please provide this information in the commit message in v2.
Thanks,
Conor.
pw-bot: changes-requested
>
> >>
> >> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> index 2ba4d5de4ec4..a1b4c02db246 100644
> >> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
> >> @@ -33,6 +33,10 @@ properties:
> >> interrupts:
> >> maxItems: 1
> >>
> >> + vdd-supply: true
> >> + vddio-supply: true
> >> + vled-supply: true
> >> +
> >> reg:
> >> maxItems: 1
> >>
> >> @@ -54,6 +58,9 @@ examples:
> >> compatible = "vishay,vcnl4200";
> >> reg = <0x51>;
> >> proximity-near-level = <220>;
> >> + vdd-supply = <®_vdd>;
> >> + vddio-supply = <®_vddio>;
> >> + vled-supply = <®_vled>;
> >> };
> >> };
> >> ...
> >>
> >> --
> >> 2.53.0
> >>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-03-13 16:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:53 [PATCH v2 0/3] iio: light: vcnl4000: add regulator support Erikas Bitovtas
2026-03-12 11:53 ` [PATCH v2 1/3] dt-bindings: iio: light: vcnl4000: add regulators Erikas Bitovtas
2026-03-12 17:39 ` Conor Dooley
2026-03-13 16:39 ` Erikas Bitovtas
2026-03-13 16:51 ` Conor Dooley [this message]
2026-03-12 11:53 ` [PATCH v2 2/3] iio: light: vcnl4000: add support for regulators Erikas Bitovtas
2026-03-12 14:30 ` Andy Shevchenko
2026-03-12 11:53 ` [PATCH v2 3/3] iio: light: vcnl4000: move client->dev in probe into a variable Erikas Bitovtas
2026-03-12 14:33 ` Andy Shevchenko
2026-03-12 14:34 ` [PATCH v2 0/3] iio: light: vcnl4000: add regulator support Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313-reputably-pregame-ba41c3c1438a@spud \
--to=conor@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=xerikasxx@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®