* [PATCH v2] drm/arcpgu: fix device node leak
@ 2026-04-02 16:42 Luca Ceresoli
2026-04-08 16:18 ` Louis Chauvet
2026-04-14 10:27 ` Luca Ceresoli
0 siblings, 2 replies; 3+ messages in thread
From: Luca Ceresoli @ 2026-04-02 16:42 UTC (permalink / raw)
To: Simona Vetter, Alexey Brodkin, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Hui Pu, Thomas Petazzoni, dri-devel, linux-kernel, Ian Ray,
stable, Luca Ceresoli
This function gets a device_node reference via
of_graph_get_remote_port_parent() and stores it in encoder_node, but never
puts that reference. Add it.
There used to be a of_node_put(encoder_node) but it has been removed by
mistake during a rework in commit 3ea66a794fdc ("drm/arc: Inline
arcpgu_drm_hdmi_init").
Fixes: 3ea66a794fdc ("drm/arc: Inline arcpgu_drm_hdmi_init")
Cc: stable@vger.kernel.org
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
Changes in v2:
- fix typos in commit message
---
drivers/gpu/drm/tiny/arcpgu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
index 505888497482..c93d61ac0bb7 100644
--- a/drivers/gpu/drm/tiny/arcpgu.c
+++ b/drivers/gpu/drm/tiny/arcpgu.c
@@ -250,7 +250,8 @@ DEFINE_DRM_GEM_DMA_FOPS(arcpgu_drm_ops);
static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
{
struct platform_device *pdev = to_platform_device(arcpgu->drm.dev);
- struct device_node *encoder_node = NULL, *endpoint_node = NULL;
+ struct device_node *encoder_node __free(device_node) = NULL;
+ struct device_node *endpoint_node = NULL;
struct drm_connector *connector = NULL;
struct drm_device *drm = &arcpgu->drm;
int ret;
---
base-commit: 4b9c36c83b34f710da9573291404f6a2246251c1
change-id: 20251119-drm-arcgpu-fix-device-node-leak-f909bc1f7fbb
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/arcpgu: fix device node leak
2026-04-02 16:42 [PATCH v2] drm/arcpgu: fix device node leak Luca Ceresoli
@ 2026-04-08 16:18 ` Louis Chauvet
2026-04-14 10:27 ` Luca Ceresoli
1 sibling, 0 replies; 3+ messages in thread
From: Louis Chauvet @ 2026-04-08 16:18 UTC (permalink / raw)
To: Luca Ceresoli, Simona Vetter, Alexey Brodkin, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: Hui Pu, Thomas Petazzoni, dri-devel, linux-kernel, Ian Ray, stable
On 4/2/26 18:42, Luca Ceresoli wrote:
> This function gets a device_node reference via
> of_graph_get_remote_port_parent() and stores it in encoder_node, but never
> puts that reference. Add it.
>
> There used to be a of_node_put(encoder_node) but it has been removed by
> mistake during a rework in commit 3ea66a794fdc ("drm/arc: Inline
> arcpgu_drm_hdmi_init").
>
> Fixes: 3ea66a794fdc ("drm/arc: Inline arcpgu_drm_hdmi_init")
> Cc: stable@vger.kernel.org
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> Changes in v2:
> - fix typos in commit message
> ---
> drivers/gpu/drm/tiny/arcpgu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tiny/arcpgu.c b/drivers/gpu/drm/tiny/arcpgu.c
> index 505888497482..c93d61ac0bb7 100644
> --- a/drivers/gpu/drm/tiny/arcpgu.c
> +++ b/drivers/gpu/drm/tiny/arcpgu.c
> @@ -250,7 +250,8 @@ DEFINE_DRM_GEM_DMA_FOPS(arcpgu_drm_ops);
> static int arcpgu_load(struct arcpgu_drm_private *arcpgu)
> {
> struct platform_device *pdev = to_platform_device(arcpgu->drm.dev);
> - struct device_node *encoder_node = NULL, *endpoint_node = NULL;
> + struct device_node *encoder_node __free(device_node) = NULL;
> + struct device_node *endpoint_node = NULL;
> struct drm_connector *connector = NULL;
> struct drm_device *drm = &arcpgu->drm;
> int ret;
>
> ---
> base-commit: 4b9c36c83b34f710da9573291404f6a2246251c1
> change-id: 20251119-drm-arcgpu-fix-device-node-leak-f909bc1f7fbb
>
> Best regards,
> --
> Luca Ceresoli <luca.ceresoli@bootlin.com>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/arcpgu: fix device node leak
2026-04-02 16:42 [PATCH v2] drm/arcpgu: fix device node leak Luca Ceresoli
2026-04-08 16:18 ` Louis Chauvet
@ 2026-04-14 10:27 ` Luca Ceresoli
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2026-04-14 10:27 UTC (permalink / raw)
To: Simona Vetter, Alexey Brodkin, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Luca Ceresoli
Cc: Hui Pu, Thomas Petazzoni, dri-devel, linux-kernel, Ian Ray, stable
On Thu, 02 Apr 2026 18:42:20 +0200, Luca Ceresoli wrote:
> This function gets a device_node reference via
> of_graph_get_remote_port_parent() and stores it in encoder_node, but never
> puts that reference. Add it.
>
> There used to be a of_node_put(encoder_node) but it has been removed by
> mistake during a rework in commit 3ea66a794fdc ("drm/arc: Inline
> arcpgu_drm_hdmi_init").
>
> [...]
Applied, thanks!
[1/1] drm/arcpgu: fix device node leak
commit: ad3ac32a3893a2bbcad545efc005a8e4e7ecf10c
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-14 10:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-04-02 16:42 [PATCH v2] drm/arcpgu: fix device node leak Luca Ceresoli
2026-04-08 16:18 ` Louis Chauvet
2026-04-14 10:27 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®