[PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Yicong Hui]

Fix the following W=1 kerneldoc warnings by adding the missing parameter
descriptions for @phase0_identity and @nn_interpolation in
dcss_scaler_filter_design() and @phase0_identity in
dcss_scaler_gaussian_filter()

Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'

Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
Signed-off-by: Yicong Hui <yiconghui@gmail.com>
---
 drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
index 32c3f46b21da..5c7f8d952ec1 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
@@ -166,6 +166,7 @@ static int exp_approx_q(int x)
  * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
  * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
  * @use_5_taps: indicates whether to use 5 taps or 7 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
  * @coef: output filter coefficients
  */
 static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
@@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
  * @src_length: length of input
  * @dst_length: length of output
  * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
+ * @phase0_identity: whether to override phase 0 coefficients with identity filter
  * @coef: output coefficients
+ * @nn_interpolation: whether to use nearest neighbor instead of gaussian filter
  */
 static void dcss_scaler_filter_design(int src_length, int dst_length,
 				      bool use_5_taps, bool phase0_identity,
-- 
2.53.0

Re: [PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Yicong Hui]

On 06/04/2026 7:00 pm, Yicong Hui wrote:
> Fix the following W=1 kerneldoc warnings by adding the missing parameter
> descriptions for @phase0_identity and @nn_interpolation in
> dcss_scaler_filter_design() and @phase0_identity in
> dcss_scaler_gaussian_filter()
> 
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'
> 
> Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
> Signed-off-by: Yicong Hui <yiconghui@gmail.com>
> ---
>   drivers/gpu/drm/imx/dcss/dcss-scaler.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-scaler.c b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> index 32c3f46b21da..5c7f8d952ec1 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-scaler.c
> @@ -166,6 +166,7 @@ static int exp_approx_q(int x)
>    * dcss_scaler_gaussian_filter() - Generate gaussian prototype filter.
>    * @fc_q: fixed-point cutoff frequency normalized to range [0, 1]
>    * @use_5_taps: indicates whether to use 5 taps or 7 taps
> + * @phase0_identity: whether to override phase 0 coefficients with identity filter
>    * @coef: output filter coefficients
>    */
>   static void dcss_scaler_gaussian_filter(int fc_q, bool use_5_taps,
> @@ -262,7 +263,9 @@ static void dcss_scaler_nearest_neighbor_filter(bool use_5_taps,
>    * @src_length: length of input
>    * @dst_length: length of output
>    * @use_5_taps: 0 for 7 taps per phase, 1 for 5 taps
> + * @phase0_identity: whether to override phase 0 coefficients with identity filter
>    * @coef: output coefficients
> + * @nn_interpolation: whether to use nearest neighbor instead of gaussian filter
>    */
>   static void dcss_scaler_filter_design(int src_length, int dst_length,
>   				      bool use_5_taps, bool phase0_identity,

Hello!

Is there any further feedback or progress on this patch?

Thank you!
Yicong

Re: [PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Laurentiu Palcu]

Hi Yicong,

On Mon, Apr 06, 2026 at 07:00:13PM +0100, Yicong Hui wrote:
> Fix the following W=1 kerneldoc warnings by adding the missing parameter
> descriptions for @phase0_identity and @nn_interpolation in
> dcss_scaler_filter_design() and @phase0_identity in
> dcss_scaler_gaussian_filter()
> 
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'
> 
> Fixes: 9021c317b770 ("drm/imx: Add initial support for DCSS on iMX8MQ")
> Signed-off-by: Yicong Hui <yiconghui@gmail.com>

Sorry, I totally missed your patch... :/

Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

-- 
Thanks,
Laurentiu

Re: [PATCH] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c

[Liu Ying]

On Mon, 06 Apr 2026 19:00:13 +0100, Yicong Hui wrote:
> Fix the following W=1 kerneldoc warnings by adding the missing parameter
> descriptions for @phase0_identity and @nn_interpolation in
> dcss_scaler_filter_design() and @phase0_identity in
> dcss_scaler_gaussian_filter()
> 
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:173 function parameter 'phase0_identity' not described in 'dcss_scaler_gaussian_filter'
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'phase0_identity' not described in 'dcss_scaler_filter_design'
> Warning: drivers/gpu/drm/imx/dcss/dcss-scaler.c:270 function parameter 'nn_interpolation' not described in 'dcss_scaler_filter_design'
> 
> [...]

Applied to misc/kernel.git (drm-misc-fixes), thanks!

[1/1] drm/imx: Fix three kernel-doc warnings in dcss-scaler.c
      commit: ae0383e5a9a4b12d68c76c4769857def4665deff

-- 
Regards,
Liu Ying