mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sched/deadline: Fix stale comment above yield_task_dl()
@ 2026-05-13 10:25 Furkan Caliskan
  2026-05-13 11:54 ` Juri Lelli
  0 siblings, 1 reply; 3+ messages in thread
From: Furkan Caliskan @ 2026-05-13 10:25 UTC (permalink / raw)
  To: linux-kernel
  Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
	vschneid, jstultz, Furkan Caliskan

The comment above yield_task_dl() states that bandwidth reclaiming is
"planned for the future". This is now obsolete as GRUB-PA has been
implemented.

Update the comment to reflect that yielded bandwidth is now actively
reclaimed for power saving and scheduling efficiency.

Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
---
 kernel/sched/deadline.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index edca7849b165..1ff8e5aafb3b 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2365,14 +2365,11 @@ static bool dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 }
 
 /*
- * Yield task semantic for -deadline tasks is:
+ * Get off from the CPU until our next instance
  *
- *   get off from the CPU until our next instance, with
- *   a new runtime. This is of little use now, since we
- *   don't have a bandwidth reclaiming mechanism. Anyway,
- *   bandwidth reclaiming is planned for the future, and
- *   yield_task_dl will indicate that some spare budget
- *   is available for other task instances to use it.
+ * Yielding indicates that the current instance has finished its work 
+ * early. This allows the remaining budget to be reclaimed by other
+ * tasks or used to reduce CPU frequency via the GRUB-PA mechanism. 
  */
 static void yield_task_dl(struct rq *rq)
 {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] sched/deadline: Fix stale comment above yield_task_dl()
@ 2026-04-27  9:20 Furkan Caliskan
  0 siblings, 0 replies; 3+ messages in thread
From: Furkan Caliskan @ 2026-04-27  9:20 UTC (permalink / raw)
  To: linux-kernel
  Cc: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
	vschneid, jstultz, Furkan Caliskan

The comment above yield_task_dl() states that bandwidth reclaiming is
"planned for the future". This is now obsolete as GRUB-PA has been
implemented.

Update the comment to reflect that yielded bandwidth is now actively
reclaimed for power saving and scheduling efficiency.

Signed-off-by: Furkan Caliskan <frn1furkan10@gmail.com>
---
 kernel/sched/deadline.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 27359a1e995f..fba29af74107 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -2368,14 +2368,11 @@ static bool dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
 }
 
 /*
- * Yield task semantic for -deadline tasks is:
+ * Get off from the CPU until our next instance
  *
- *   get off from the CPU until our next instance, with
- *   a new runtime. This is of little use now, since we
- *   don't have a bandwidth reclaiming mechanism. Anyway,
- *   bandwidth reclaiming is planned for the future, and
- *   yield_task_dl will indicate that some spare budget
- *   is available for other task instances to use it.
+ * Yielding indicates that the current instance has finished its work 
+ * early. This allows the remaining budget to be reclaimed by other
+ * tasks or used to reduce CPU frequency via the GRUB-PA mechanism. 
  */
 static void yield_task_dl(struct rq *rq)
 {
-- 
2.34.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-13 11:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-05-13 10:25 [PATCH] sched/deadline: Fix stale comment above yield_task_dl() Furkan Caliskan
2026-05-13 11:54 ` Juri Lelli
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27  9:20 Furkan Caliskan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®