From: Peter Zijlstra <peterz@infradead.org>
To: Jim Mattson <jmattson@google.com>
Cc: seanjc@google.com, pbonzini@redhat.com, tglx@kernel.org,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, shuah@kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, ctpence@google.com,
David.Kaplan@amd.com, binbin.wu@linux.intel.com
Subject: Re: [PATCH v4 1/5] KVM: x86: Consolidate CPUID fault handling for emulator and interception logic
Date: Thu, 28 May 2026 11:13:57 +0200 [thread overview]
Message-ID: <20260528091357.GB343181@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260527174347.2356165-2-jmattson@google.com>
On Wed, May 27, 2026 at 10:43:43AM -0700, Jim Mattson wrote:
> [jim: Add EXPORT_STATIC_CALL_GPL(kvm_x86_get_cpl) so that KVM vendor
> modules can call kvm_is_cpuid_allowed(). Fix typo in commit message.]
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 1578c0ecbbd1..72bd3cddb026 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -151,6 +151,7 @@ struct kvm_x86_ops kvm_x86_ops __read_mostly;
> #include <asm/kvm-x86-ops.h>
> EXPORT_STATIC_CALL_GPL(kvm_x86_get_cs_db_l_bits);
> EXPORT_STATIC_CALL_GPL(kvm_x86_cache_reg);
> +EXPORT_STATIC_CALL_GPL(kvm_x86_get_cpl);
Are you aware of the distinction between EXPORT_STATIC_CALL_GPL() and
EXPORT_STATIC_CALL_TRAMP_GPL() ?
Specifically, the former allows modules to do static_call_update(),
while the latter does not. Whenever possible use the TRAMP thing, this
allows modules to *call* the static_call, but not to redirect it.
next prev parent reply other threads:[~2026-05-28 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 17:43 [PATCH v4 0/5] KVM: x86: Virtualize AMD's "disable CPUID in usermode" Jim Mattson
2026-05-27 17:43 ` [PATCH v4 1/5] KVM: x86: Consolidate CPUID fault handling for emulator and interception logic Jim Mattson
2026-05-28 9:13 ` Peter Zijlstra [this message]
2026-05-28 14:20 ` Jim Mattson
2026-05-28 16:08 ` Sean Christopherson
2026-05-28 16:06 ` Sean Christopherson
2026-05-27 17:43 ` [PATCH v4 2/5] KVM: x86: Prioritize CPUID faulting over CPUID VM-exits in nested VMX Jim Mattson
2026-05-27 17:43 ` [PATCH v4 3/5] KVM: x86: Remove supports_cpuid_fault() helper Jim Mattson
2026-05-27 17:43 ` [PATCH v4 4/5] KVM: x86: Virtualize AMD CPUID faulting Jim Mattson
2026-05-27 17:43 ` [PATCH v4 5/5] KVM: selftests: Update hwcr_msr_test for CPUID faulting bit Jim Mattson
2026-05-29 22:47 ` [PATCH v4 0/5] KVM: x86: Virtualize AMD's "disable CPUID in usermode" Sean Christopherson
2026-06-06 15:12 ` Jim Mattson
2026-06-06 16:00 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260528091357.GB343181@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Kaplan@amd.com \
--cc=binbin.wu@linux.intel.com \
--cc=bp@alien8.de \
--cc=ctpence@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®