[PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Rosen Penev]

Use platform_get_irq() to retrieve the interrupt resource instead of
directly parsing and mapping the OF node via irq_of_parse_and_map().
This is the standard pattern for platform devices.

In addition, platform_get_irq() returns a negative error code on
failure, which is now checked. Since we are no longer using
irq_of_parse_and_map(), we do not need to call irq_dispose_mapping()
on error or driver removal, so remove those calls.

Assisted-by: Antigravity:Gemini-3.5-Flash
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/edac/mpc85xx_edac.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index 277f1c6bd522..f494d922c6a1 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -555,14 +555,17 @@ static int mpc85xx_l2_err_probe(struct platform_device *op)
 	}
 
 	if (edac_op_state == EDAC_OPSTATE_INT) {
-		pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
+		pdata->irq = platform_get_irq(op, 0);
+		if (pdata->irq < 0) {
+			res = pdata->irq;
+			goto err;
+		}
 		res = devm_request_irq(&op->dev, pdata->irq,
 				       mpc85xx_l2_isr, IRQF_SHARED,
 				       "[EDAC] L2 err", edac_dev);
 		if (res < 0) {
 			pr_err("%s: Unable to request irq %d for MPC85xx L2 err\n",
 				__func__, pdata->irq);
-			irq_dispose_mapping(pdata->irq);
 			res = -ENODEV;
 			goto err2;
 		}
@@ -596,10 +599,8 @@ static void mpc85xx_l2_err_remove(struct platform_device *op)
 
 	edac_dbg(0, "\n");
 
-	if (edac_op_state == EDAC_OPSTATE_INT) {
+	if (edac_op_state == EDAC_OPSTATE_INT)
 		out_be32(pdata->l2_vbase + MPC85XX_L2_ERRINTEN, 0);
-		irq_dispose_mapping(pdata->irq);
-	}
 
 	out_be32(pdata->l2_vbase + MPC85XX_L2_ERRDIS, orig_l2_err_disable);
 	edac_device_del_device(&op->dev);
-- 
2.54.0

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Borislav Petkov]

On Wed, Jun 03, 2026 at 12:19:08PM -0700, Rosen Penev wrote:
> Use platform_get_irq() to retrieve the interrupt resource instead of
> directly parsing and mapping the OF node via irq_of_parse_and_map().
> This is the standard pattern for platform devices.
> 
> In addition, platform_get_irq() returns a negative error code on
> failure, which is now checked. Since we are no longer using
> irq_of_parse_and_map(), we do not need to call irq_dispose_mapping()
> on error or driver removal, so remove those calls.
> 
> Assisted-by: Antigravity:Gemini-3.5-Flash
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/edac/mpc85xx_edac.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)

I'd let Johannes comment here. AFAIR, he doesn't have the HW anymore and
I don't know who can test this for us so...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Johannes Thumshirn]

Sorry for the late response, been on PTO for some weeks.

 From what I can see this looks good, but as Boris already said, I don't 
have access to HW anymore so I can't test.

Anyways,

Acked-by: Johannes Thumshirn <jth@kernel.org>

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Borislav Petkov]

On Tue, Jun 09, 2026 at 07:59:41AM +0200, Johannes Thumshirn wrote:
> Sorry for the late response, been on PTO for some weeks.
> 
> From what I can see this looks good, but as Boris already said, I don't have
> access to HW anymore so I can't test.
> 
> Anyways,
> 
> Acked-by: Johannes Thumshirn <jth@kernel.org>

... and Sashiko has found a couple of issues too:

https://sashiko.dev/#/patchset/20260603191908.5618-1-rosenp%40gmail.com

So, how about we orphan this driver, considering that we don't have hw to test
it on? 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Rosen Penev]

On Wed, Jun 10, 2026 at 10:34 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Tue, Jun 09, 2026 at 07:59:41AM +0200, Johannes Thumshirn wrote:
> > Sorry for the late response, been on PTO for some weeks.
> >
> > From what I can see this looks good, but as Boris already said, I don't have
> > access to HW anymore so I can't test.
> >
> > Anyways,
> >
> > Acked-by: Johannes Thumshirn <jth@kernel.org>
>
> ... and Sashiko has found a couple of issues too:
>
> https://sashiko.dev/#/patchset/20260603191908.5618-1-rosenp%40gmail.com
>
> So, how about we orphan this driver, considering that we don't have hw to test
> it on?
sure.
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Johannes Thumshirn]

On 6/10/26 7:33 PM, Borislav Petkov wrote:
> On Tue, Jun 09, 2026 at 07:59:41AM +0200, Johannes Thumshirn wrote:
>> Sorry for the late response, been on PTO for some weeks.
>>
>>  From what I can see this looks good, but as Boris already said, I don't have
>> access to HW anymore so I can't test.
>>
>> Anyways,
>>
>> Acked-by: Johannes Thumshirn <jth@kernel.org>
> ... and Sashiko has found a couple of issues too:
>
> https://sashiko.dev/#/patchset/20260603191908.5618-1-rosenp%40gmail.com
>
> So, how about we orphan this driver, considering that we don't have hw to test
> it on?
>
Yep fine from my side

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Borislav Petkov]

On Thu, Jun 11, 2026 at 07:55:35AM +0200, Johannes Thumshirn wrote:
> Yep fine from my side

From: "Borislav Petkov (AMD)" <bp@alien8.de>
Date: Fri, 12 Jun 2026 08:35:50 -0700
Subject: [PATCH] EDAC/mpc85xx: Orphan it

Johannes doesn't have the hardware to test patches on it anymore and
TTBOMK, no one else has shown interest so orphan the driver, for now at
least.

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index dcdc7bda7ace..4f0788c8d212 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9298,9 +9298,8 @@ S:	Maintained
 F:	drivers/edac/igen6_edac.c
 
 EDAC-MPC85XX
-M:	Johannes Thumshirn <morbidrsa@gmail.com>
 L:	linux-edac@vger.kernel.org
-S:	Maintained
+S:	Orphan
 F:	drivers/edac/mpc85xx_edac.[ch]
 
 EDAC-NPCM
-- 
2.53.0


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Johannes Thumshirn]

On 6/12/26 5:38 PM, Borislav Petkov wrote:
> On Thu, Jun 11, 2026 at 07:55:35AM +0200, Johannes Thumshirn wrote:
>> Yep fine from my side
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> Date: Fri, 12 Jun 2026 08:35:50 -0700
> Subject: [PATCH] EDAC/mpc85xx: Orphan it
>
> Johannes doesn't have the hardware to test patches on it anymore and
> TTBOMK, no one else has shown interest so orphan the driver, for now at
> least.
>
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>


Acked-by: Johannes Thumshirn <jth@kernel.org>

Re: [PATCH] EDAC/mpc85xx: Use platform_get_irq() to get interrupt

[Borislav Petkov]

On Fri, Jun 12, 2026 at 07:05:47PM +0200, Johannes Thumshirn wrote:
> On 6/12/26 5:38 PM, Borislav Petkov wrote:
> > On Thu, Jun 11, 2026 at 07:55:35AM +0200, Johannes Thumshirn wrote:
> > > Yep fine from my side
> > From: "Borislav Petkov (AMD)" <bp@alien8.de>
> > Date: Fri, 12 Jun 2026 08:35:50 -0700
> > Subject: [PATCH] EDAC/mpc85xx: Orphan it
> > 
> > Johannes doesn't have the hardware to test patches on it anymore and
> > TTBOMK, no one else has shown interest so orphan the driver, for now at
> > least.
> > 
> > Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> 
> 
> Acked-by: Johannes Thumshirn <jth@kernel.org>

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette