[PATCH 0/2] media: intel: ipu-bridge: cleanup checkpatch warnings

[PATCH 0/2] media: intel: ipu-bridge: cleanup checkpatch warnings

[Hungyu Lin]

This series addresses two checkpatch.pl findings in
drivers/media/pci/intel/ipu-bridge.c.

Patch 1 adds a terminating entry to ivsc_acpi_ids[].
Patch 2 adds a blank line after local variable declarations.

No functional changes intended.

Hungyu Lin (2):
  media: intel: ipu-bridge: add sentinel to ivsc_acpi_ids
  media: intel: ipu-bridge: add blank line after declarations

 drivers/media/pci/intel/ipu-bridge.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.34.1

[PATCH 1/2] media: intel: ipu-bridge: add sentinel to ivsc_acpi_ids

[Hungyu Lin]

Add a terminating empty entry to ivsc_acpi_ids[].

The table currently contains only valid ACPI IDs. Add a
terminating entry to follow the common convention used by
device ID tables.

No functional change intended.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/media/pci/intel/ipu-bridge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
index fc6608e33de4..471a449f11f6 100644
--- a/drivers/media/pci/intel/ipu-bridge.c
+++ b/drivers/media/pci/intel/ipu-bridge.c
@@ -168,6 +168,7 @@ static const struct acpi_device_id ivsc_acpi_ids[] = {
 	{ "INTC1095" },
 	{ "INTC100A" },
 	{ "INTC10CF" },
+	{}
 };
 
 static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device *adev)
-- 
2.34.1

Re: [PATCH 1/2] media: intel: ipu-bridge: add sentinel to ivsc_acpi_ids

[Sakari Ailus]

Hi Hungyu,

On Sun, Jun 07, 2026 at 01:08:52PM +0000, Hungyu Lin wrote:
> Add a terminating empty entry to ivsc_acpi_ids[].
> 
> The table currently contains only valid ACPI IDs. Add a
> terminating entry to follow the common convention used by
> device ID tables.
> 
> No functional change intended.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/media/pci/intel/ipu-bridge.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index fc6608e33de4..471a449f11f6 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -168,6 +168,7 @@ static const struct acpi_device_id ivsc_acpi_ids[] = {
>  	{ "INTC1095" },
>  	{ "INTC100A" },
>  	{ "INTC10CF" },
> +	{}

There's no need to add a sentinel entry to the array as the code working on
it relies on its length for the boundary check (not its contents).

>  };
>  
>  static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device *adev)

-- 
Regards,

Sakari Ailus

[PATCH 2/2] media: intel: ipu-bridge: add blank line after declarations

[Hungyu Lin]

Add a blank line between the local variable declarations and
the following statement in ipu_bridge_get_ivsc_acpi_dev().

This addresses a checkpatch.pl warning.

No functional change intended.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/media/pci/intel/ipu-bridge.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
index 471a449f11f6..28d309646c1e 100644
--- a/drivers/media/pci/intel/ipu-bridge.c
+++ b/drivers/media/pci/intel/ipu-bridge.c
@@ -180,6 +180,7 @@ static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device *adev
 		struct acpi_device *consumer, *ivsc_adev;
 
 		acpi_handle handle = acpi_device_handle(ACPI_PTR(adev));
+
 		for_each_acpi_dev_match(ivsc_adev, acpi_id->id, NULL, -1)
 			/* camera sensor depends on IVSC in DSDT if exist */
 			for_each_acpi_consumer_dev(ivsc_adev, consumer)
-- 
2.34.1

Re: [PATCH 2/2] media: intel: ipu-bridge: add blank line after declarations

[Sakari Ailus]

Hi Hungyu,

On Sun, Jun 07, 2026 at 01:08:53PM +0000, Hungyu Lin wrote:
> Add a blank line between the local variable declarations and
> the following statement in ipu_bridge_get_ivsc_acpi_dev().
> 
> This addresses a checkpatch.pl warning.
> 
> No functional change intended.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/media/pci/intel/ipu-bridge.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> index 471a449f11f6..28d309646c1e 100644
> --- a/drivers/media/pci/intel/ipu-bridge.c
> +++ b/drivers/media/pci/intel/ipu-bridge.c
> @@ -180,6 +180,7 @@ static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device *adev
>  		struct acpi_device *consumer, *ivsc_adev;
>  
>  		acpi_handle handle = acpi_device_handle(ACPI_PTR(adev));
> +

This newline indeed is added where appropriate, but there's an extra one
just a few lines above. Please remove that one as well.

>  		for_each_acpi_dev_match(ivsc_adev, acpi_id->id, NULL, -1)
>  			/* camera sensor depends on IVSC in DSDT if exist */
>  			for_each_acpi_consumer_dev(ivsc_adev, consumer)

-- 
Sakari Ailus