[PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit

[PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit

[Hungyu Lin]

Remove the explicit u32 cast in the watermark limit calculation.

The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with
min() without triggering type issues.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
Changes in v2:
- Drop the unnecessary cast instead of using min_t().
- Follow reviewer feedback from David Laight and Andy Shevchenko.

 drivers/iio/imu/bmi323/bmi323_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/imu/bmi323/bmi323_core.c b/drivers/iio/imu/bmi323/bmi323_core.c
index f3d499423399..72955a697a93 100644
--- a/drivers/iio/imu/bmi323/bmi323_core.c
+++ b/drivers/iio/imu/bmi323/bmi323_core.c
@@ -1128,7 +1128,7 @@ static int bmi323_set_watermark(struct iio_dev *indio_dev, unsigned int val)
 {
 	struct bmi323_data *data = iio_priv(indio_dev);
 
-	val = min(val, (u32)BMI323_FIFO_FULL_IN_FRAMES);
+	val = min(val, BMI323_FIFO_FULL_IN_FRAMES);
 
 	guard(mutex)(&data->mutex);
 	data->watermark = val;
-- 
2.34.1

Re: [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit

[Nuno Sá]

On Mon, 2026-06-08 at 12:15 +0000, Hungyu Lin wrote:
> Remove the explicit u32 cast in the watermark limit calculation.
> 
> The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with
> min() without triggering type issues.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> Changes in v2:
> - Drop the unnecessary cast instead of using min_t().
> - Follow reviewer feedback from David Laight and Andy Shevchenko.
> 
>  drivers/iio/imu/bmi323/bmi323_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/bmi323/bmi323_core.c
> b/drivers/iio/imu/bmi323/bmi323_core.c
> index f3d499423399..72955a697a93 100644
> --- a/drivers/iio/imu/bmi323/bmi323_core.c
> +++ b/drivers/iio/imu/bmi323/bmi323_core.c
> @@ -1128,7 +1128,7 @@ static int bmi323_set_watermark(struct iio_dev *indio_dev,
> unsigned int val)
>  {
>  	struct bmi323_data *data = iio_priv(indio_dev);
>  
> -	val = min(val, (u32)BMI323_FIFO_FULL_IN_FRAMES);
> +	val = min(val, BMI323_FIFO_FULL_IN_FRAMES);
>  
>  	guard(mutex)(&data->mutex);
>  	data->watermark = val;

Re: [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit

[Andy Shevchenko]

On Mon, Jun 08, 2026 at 12:15:58PM +0000, Hungyu Lin wrote:
> Remove the explicit u32 cast in the watermark limit calculation.
> 
> The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with
> min() without triggering type issues.

Right, now it looks much better.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] iio: imu: bmi323: remove unnecessary cast in watermark limit

[Jonathan Cameron]

On Tue, 9 Jun 2026 16:28:31 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Mon, Jun 08, 2026 at 12:15:58PM +0000, Hungyu Lin wrote:
> > Remove the explicit u32 cast in the watermark limit calculation.
> > 
> > The BMI323_FIFO_FULL_IN_FRAMES macro can be used directly with
> > min() without triggering type issues.  
> 
> Right, now it looks much better.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> 


Agreed. Easy to check these min conditions as there is good documentation in
minmax.h  Entry that is relevant here I think is this one.

* - Unsigned arguments can be compared against non-negative signed constants.


Applied to the testing branch of iio.git.

Thanks,

Jonathan