From: Peter Zijlstra <peterz@infradead.org>
To: Xin Zhao <jackzxcui1989@163.com>
Cc: aiqun.yu@oss.qualcomm.com, bsegall@google.com,
dietmar.eggemann@arm.com, juri.lelli@redhat.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
mgorman@suse.de, mingo@redhat.com, pauld@redhat.com,
rostedt@goodmis.org, vincent.guittot@linaro.org,
vschneid@redhat.com
Subject: Re: [PATCH v5 2/2] sched/fair: Simplify balance_interval reset logic in sched_balance_rq()
Date: Thu, 18 Jun 2026 12:31:51 +0200 [thread overview]
Message-ID: <20260618103151.GO49951@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20260618101740.2753705-1-jackzxcui1989@163.com>
On Thu, Jun 18, 2026 at 06:17:40PM +0800, Xin Zhao wrote:
> On Thu, 18 Jun 2026 11:40:56 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
>
> > This is very confusing, and my AI helper isn't helping much this time
> > around.
> >
> > active_balance is initialized 0, it is only (but not always) set 1 when
> > need_active_balance().
> >
> > Therefore, the condition: !active_balance || need_active_balance() is a
> > truism and can be removed.
> >
> > Or am I missing something more complicated?
>
> Sorry for my poor English again.
No need to be; English isn't my native tongue either, although it is
much closer linguistically. It just takes a little patience (and LLM
help these days), but we'll get there.
> I will change the commit log as below:
No need, I shall edit, the patch itself looked fine.
next prev parent reply other threads:[~2026-06-18 10:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-17 7:21 [PATCH v5 0/2] sched/fair: Optimize some active balance logic Xin Zhao
2026-06-17 7:21 ` [PATCH v5 1/2] sched/fair: Don't trigger active lb if src_rq->curr is not on_rq Xin Zhao
2026-06-17 9:30 ` Valentin Schneider
2026-06-18 9:18 ` Peter Zijlstra
2026-06-18 10:09 ` Xin Zhao
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Xin Zhao
2026-06-17 7:21 ` [PATCH v5 2/2] sched/fair: Simplify balance_interval reset logic in sched_balance_rq() Xin Zhao
2026-06-18 9:40 ` Peter Zijlstra
2026-06-18 10:17 ` Xin Zhao
2026-06-18 10:31 ` Peter Zijlstra [this message]
2026-06-18 10:49 ` Xin Zhao
2026-06-30 9:03 ` [tip: sched/core] " tip-bot2 for Xin Zhao
2026-06-18 10:56 ` [PATCH v5 0/2] sched/fair: Optimize some active balance logic Peter Zijlstra
2026-06-18 13:56 ` Xin Zhao
2026-06-22 12:15 ` Aiqun(Maria) Yu
2026-06-30 9:03 ` [tip: sched/core] sched/fair: Reflow sched_balance_rq() tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260618103151.GO49951@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jackzxcui1989@163.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome