From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Linus Torvalds <torvalds@linux-foundation.org>,
John Ogness <john.ogness@linutronix.de>,
Thomas Gleixner <tglx@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Yury Norov <ynorov@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ao Sun <ao.sun@transsion.com>, David Carlier <devnexen@gmail.com>,
Karl Mehltretter <kmehltretter@gmail.com>,
Martin Kaiser <martin@kaiser.cx>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Qian-Yu Lin <tiffany019230@gmail.com>,
Rik van Riel <riel@surriel.com>, Rosen Penev <rosenp@gmail.com>,
Shuvam Pandey <shuvampandey1@gmail.com>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Yash Suthar <yashsuthar983@gmail.com>,
Yu Peng <pengyu@kylinos.cn>
Subject: Re: [GIT PULL] tracing: Updates for 7.2
Date: Fri, 19 Jun 2026 17:40:25 +0200 [thread overview]
Message-ID: <20260619154025.h4BHc5wi@linutronix.de> (raw)
In-Reply-To: <CAHk-=wiH8muwBL8FJ7iThgqvWY790ocWxPZ8tGtfQq=A3ErO3A@mail.gmail.com>
On 2026-06-19 07:35:15 [-0700], Linus Torvalds wrote:
> On Fri, 19 Jun 2026 at 05:15, Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > Many developers use trace_printk() over printk().
>
> You're on some bad drugs, Steven.
>
> By "many developers" you clearly must have meant "almost nobody".
I do use it for debugging all the time. The alternative is printk but it
is "slower" if it throws everything to the UART which I prefer to limit
to BUG/WARN kind of messages. Also it does not record the context where
this comes from which is often helpful.
Afaik it is the only to debug printk.
> > Requiring people to add that include for every use case would
> > severely limit debugging of the kernel. Would you be OK if we did
> > the same for printk?
>
> Stop making inane and silly arguments that have nothing to do with
> reality.
>
> The two are not the same:
>
> $ git grep -wl printk | wc -l 3212 $ git grep -wl trace_printk | wc
> -l 50
>
> and making them sound remotely similar is just making you look dishonst.
>
> Look, the attached patch makes my defconfig build cleanly, and makes a
>
> $ touch include/linux/trace_printk.h
>
> cause my recompile to build just a handful of files. While touching
> linux/kernel.h causes thousands of files to be re-build.
>
> That's a whopping
>
> 6 files changed, 6 insertions(+), 1 deletion(-)
>
> to make my tree build without including <linux/trace_printk.h> everywhere.
>
> Now, that's _just_ my defconfig, and the full build clearly has a
> handful of other cases. From a quick look, mostly in the 'samples'
> directory.
>
> But it looks like a *handful* of other cases.
>
> Now, if the same was true for printk(), I'd happily split that into
> some other header too.
>
> But it isn't.
>
> Because we live in reality.
>
> Linus
Sebastian
next prev parent reply other threads:[~2026-06-19 15:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 22:01 Steven Rostedt
2026-06-19 4:23 ` Linus Torvalds
2026-06-19 12:15 ` Steven Rostedt
2026-06-19 14:35 ` Linus Torvalds
2026-06-19 15:40 ` Sebastian Andrzej Siewior [this message]
2026-06-19 15:43 ` Linus Torvalds
2026-06-19 18:30 ` Sebastian Andrzej Siewior
2026-06-19 19:07 ` Linus Torvalds
2026-06-19 20:28 ` Thomas Gleixner
2026-06-19 20:55 ` Linus Torvalds
2026-06-20 9:22 ` Willy Tarreau
2026-06-19 22:28 ` Linus Torvalds
2026-06-22 12:50 ` Petr Pavlu
2026-06-19 15:54 ` Steven Rostedt
2026-06-19 16:29 ` Linus Torvalds
2026-06-21 20:26 ` Agatha Isabelle Moreira
2026-06-21 20:51 ` Linus Torvalds
2026-06-21 21:19 ` Steven Rostedt
2026-06-21 23:16 ` Linus Torvalds
2026-06-22 8:51 ` Steven Rostedt
2026-06-20 20:24 ` Julia Lawall
2026-06-21 20:34 ` Agatha Isabelle Moreira
2026-06-20 22:19 ` Steven Rostedt
2026-06-20 22:39 ` Linus Torvalds
2026-06-20 23:43 ` Steven Rostedt
2026-06-21 0:18 ` Linus Torvalds
2026-06-21 6:34 ` Steven Rostedt
2026-06-21 7:10 ` Steven Rostedt
2026-06-22 8:40 ` Peter Zijlstra
2026-06-22 8:55 ` Steven Rostedt
2026-06-24 9:21 ` Steven Rostedt
2026-06-25 20:55 ` Vincent Mailhol
2026-06-27 8:50 ` Steven Rostedt
2026-06-19 15:19 ` Yury Norov
2026-06-19 15:40 ` Linus Torvalds
2026-06-19 22:18 ` Yury Norov
2026-06-19 4:38 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619154025.h4BHc5wi@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=ao.sun@transsion.com \
--cc=devnexen@gmail.com \
--cc=john.ogness@linutronix.de \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=pengyu@kylinos.cn \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rosenp@gmail.com \
--cc=rostedt@goodmis.org \
--cc=shuvampandey1@gmail.com \
--cc=tglx@kernel.org \
--cc=tiffany019230@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vineeth@bitbyteword.org \
--cc=yashsuthar983@gmail.com \
--cc=ynorov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®