From: Vincent Mailhol <mailhol@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Yury Norov <ynorov@nvidia.com>,
LKML <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Ao Sun <ao.sun@transsion.com>, David Carlier <devnexen@gmail.com>,
Karl Mehltretter <kmehltretter@gmail.com>,
Martin Kaiser <martin@kaiser.cx>,
Pengpeng Hou <pengpeng@iscas.ac.cn>,
Qian-Yu Lin <tiffany019230@gmail.com>,
Rik van Riel <riel@surriel.com>, Rosen Penev <rosenp@gmail.com>,
Shuvam Pandey <shuvampandey1@gmail.com>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Yash Suthar <yashsuthar983@gmail.com>,
Yu Peng <pengyu@kylinos.cn>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] tracing: Updates for 7.2
Date: Thu, 25 Jun 2026 22:55:47 +0200 [thread overview]
Message-ID: <768b3253-599c-4d46-96e5-2bc8d72ffb4d@kernel.org> (raw)
In-Reply-To: <20260624052102.564f9946@fedora>
On 24/06/2026 at 11:21, Steven Rostedt wrote:
> On Mon, 22 Jun 2026 04:55:47 -0400
> Steven Rostedt <steven@rostedt.org> wrote:
>
>> It really isn't about me. I personally don't care if I have to add a
>> patch to include it in kernel.h in my environment. It's just something
>> that all the other kernel developers will need to now remember to add
>> (and then remove) the include.
>
> For me, I just updated my ktest config and added:
>
> CFLAGS_KERNEL='-include $(srctree)/include/linux/trace_printk.h' CFLAGS_MODULE='-include $(srctree)/include/linux/trace_printk.h'
>
> to the kernel build and it works like it used to. But that doesn't help
> others. I may update the trace_printk documentation to mention the
> above to keep the old behavior.
Maybe what could make sense is to add a CONFIG_CUSTOM_CFLAGS entry to
Kconfig. This can be versatile enough to cover many uses cases:
- Add your custom linux/trace_printk.h include as you described above.
- Add optimizations (other than -march=native which already has its
own Kbuild entry). Can be useful for optimized cross builds.
- Add your non common compiler checks (for example -fanalyzer).
- (list not exhaustive)
That would be one entry to handle all the weird/unique use cases. I
personally do not rely often enough on trace_printk.h to wish for a
dedicated Kconfig entry just for that, but a CONFIG_CUSTOM_CFLAGS would
cover some of my use cases while also solving your problem.
Yes, all of these can be passed on the command line, but that would be a
quality of live improvement to have the config remember these for us.
Yours sincerely,
Vincent Mailhol
next prev parent reply other threads:[~2026-06-25 20:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 22:01 Steven Rostedt
2026-06-19 4:23 ` Linus Torvalds
2026-06-19 12:15 ` Steven Rostedt
2026-06-19 14:35 ` Linus Torvalds
2026-06-19 15:40 ` Sebastian Andrzej Siewior
2026-06-19 15:43 ` Linus Torvalds
2026-06-19 18:30 ` Sebastian Andrzej Siewior
2026-06-19 19:07 ` Linus Torvalds
2026-06-19 20:28 ` Thomas Gleixner
2026-06-19 20:55 ` Linus Torvalds
2026-06-20 9:22 ` Willy Tarreau
2026-06-19 22:28 ` Linus Torvalds
2026-06-22 12:50 ` Petr Pavlu
2026-06-19 15:54 ` Steven Rostedt
2026-06-19 16:29 ` Linus Torvalds
2026-06-21 20:26 ` Agatha Isabelle Moreira
2026-06-21 20:51 ` Linus Torvalds
2026-06-21 21:19 ` Steven Rostedt
2026-06-21 23:16 ` Linus Torvalds
2026-06-22 8:51 ` Steven Rostedt
2026-06-20 20:24 ` Julia Lawall
2026-06-21 20:34 ` Agatha Isabelle Moreira
2026-06-20 22:19 ` Steven Rostedt
2026-06-20 22:39 ` Linus Torvalds
2026-06-20 23:43 ` Steven Rostedt
2026-06-21 0:18 ` Linus Torvalds
2026-06-21 6:34 ` Steven Rostedt
2026-06-21 7:10 ` Steven Rostedt
2026-06-22 8:40 ` Peter Zijlstra
2026-06-22 8:55 ` Steven Rostedt
2026-06-24 9:21 ` Steven Rostedt
2026-06-25 20:55 ` Vincent Mailhol [this message]
2026-06-27 8:50 ` Steven Rostedt
2026-06-19 15:19 ` Yury Norov
2026-06-19 15:40 ` Linus Torvalds
2026-06-19 22:18 ` Yury Norov
2026-06-19 4:38 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=768b3253-599c-4d46-96e5-2bc8d72ffb4d@kernel.org \
--to=mailhol@kernel.org \
--cc=ao.sun@transsion.com \
--cc=bigeasy@linutronix.de \
--cc=devnexen@gmail.com \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=pengpeng@iscas.ac.cn \
--cc=pengyu@kylinos.cn \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rosenp@gmail.com \
--cc=rostedt@goodmis.org \
--cc=shuvampandey1@gmail.com \
--cc=tglx@linutronix.de \
--cc=tiffany019230@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vineeth@bitbyteword.org \
--cc=yashsuthar983@gmail.com \
--cc=ynorov@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome