* [PATCH] usb: dwc3: qcom: make dwc3_qcom_glue_ops static
@ 2026-06-23 10:00 Ben Dooks
2026-06-23 10:16 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Ben Dooks @ 2026-06-23 10:00 UTC (permalink / raw)
To: Thinh Nguyen, Greg Kroah-Hartman, linux-arm-msm, linux-usb, linux-kernel
Cc: Ben Dooks
The dwc3_qcom_glue_ops is not used outside of the file it is declared in
, so make it static to avoid the following warning:
drivers/usb/dwc3/dwc3-qcom.c:605:22: warning: symbol 'dwc3_qcom_glue_ops' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/usb/dwc3/dwc3-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
index f43f73ac36ff..ac68b4218b56 100644
--- a/drivers/usb/dwc3/dwc3-qcom.c
+++ b/drivers/usb/dwc3/dwc3-qcom.c
@@ -602,7 +602,7 @@ static void dwc3_qcom_run_stop_notifier(struct dwc3 *dwc, bool is_on)
pm_runtime_mark_last_busy(qcom->dev);
}
-struct dwc3_glue_ops dwc3_qcom_glue_ops = {
+static struct dwc3_glue_ops dwc3_qcom_glue_ops = {
.pre_set_role = dwc3_qcom_set_role_notifier,
.pre_run_stop = dwc3_qcom_run_stop_notifier,
};
--
2.37.2.352.g3c44437643
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: dwc3: qcom: make dwc3_qcom_glue_ops static
2026-06-23 10:00 [PATCH] usb: dwc3: qcom: make dwc3_qcom_glue_ops static Ben Dooks
@ 2026-06-23 10:16 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2026-06-23 10:16 UTC (permalink / raw)
To: Ben Dooks, Thinh Nguyen, Greg Kroah-Hartman, linux-arm-msm,
linux-usb, linux-kernel
On 6/23/26 12:00 PM, Ben Dooks wrote:
> The dwc3_qcom_glue_ops is not used outside of the file it is declared in
> , so make it static to avoid the following warning:
Odd to begin a line with a comma>
> drivers/usb/dwc3/dwc3-qcom.c:605:22: warning: symbol 'dwc3_qcom_glue_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
for the change:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-23 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-23 10:00 [PATCH] usb: dwc3: qcom: make dwc3_qcom_glue_ops static Ben Dooks
2026-06-23 10:16 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®