From: Peter Zijlstra <peterz@infradead.org>
To: mingo@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, ziqianlu@bytedance.com, tj@kernel.org,
williams@redhat.com, jkacur@redhat.com
Subject: [PATCH 0/2] sched: Remove sched_class::balance()
Date: Wed, 24 Jun 2026 14:13:27 +0200 [thread overview]
Message-ID: <20260624121327.190063948@infradead.org> (raw)
Hi!
As mentioned [1], I was going to move sched_balance_newidle() into
balance_fair(). And while the patch was quickly done, something didn't feel
right.
The two things that bugged me were:
- core-sched only calls prev_balance() on one sibling, not allowing the others
to pull tasks;
- both ::balance() and ::pick_task() take @rf and do balance operations.
That latter is because of ext; the DSQ move needs to be undone if it turns out
a higher class will get ran after all -- this is where ::pick_task() got the rf
from and why I moved its balance into pick_task_scx().
After a bit of puzzling and a few wrong turns [2], I think these patches do
away with sched_class::balance() instead, less is more and all that.
[1] https://patch.msgid.link/20260611113219.GG187714%40noisy.programming.kicks-ass.net
[2] I'm pretty sure I messed things up a few times, but rt-migration-test never
threw a failure on me -- which suggests it isn't very good at finding fails.
next reply other threads:[~2026-06-24 12:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 12:13 Peter Zijlstra [this message]
2026-06-24 12:13 ` [PATCH 1/2] sched/core: Allow newidle for core-sched Peter Zijlstra
2026-06-24 23:56 ` K Prateek Nayak
2026-06-25 12:41 ` Peter Zijlstra
2026-06-25 12:42 ` Peter Zijlstra
2026-06-24 12:13 ` [PATCH 2/2] sched: Remove sched_class::balance() Peter Zijlstra
2026-07-02 11:49 ` [PATCH 0/2] " Aaron Lu
2026-07-03 3:31 ` K Prateek Nayak
2026-08-19 9:39 ` Peter Zijlstra
2026-08-19 7:58 ` Peter Zijlstra
2026-08-19 14:36 ` Peter Zijlstra
2026-08-19 19:22 ` Tejun Heo
2026-08-20 7:18 ` Peter Zijlstra
2026-08-20 7:42 ` Tejun Heo
2026-08-20 7:58 ` Peter Zijlstra
2026-08-20 15:40 ` Peter Zijlstra
2026-08-20 17:15 ` K Prateek Nayak
2026-08-21 7:10 ` Peter Zijlstra
2026-08-22 9:42 ` Peter Zijlstra
2026-08-21 2:44 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624121327.190063948@infradead.org \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=williams@redhat.com \
--cc=ziqianlu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®