[PATCH v1] PCI: keystone: Fix OF node reference leak in init

[PATCH v1] PCI: keystone: Fix OF node reference leak in init

[Yuho Choi]

of_find_matching_node() returns a device node with its reference count
incremented. ks_pcie_init() only uses the returned node to decide whether
to register the ARM external abort fault handler, but never drops the
reference.

Store the lookup result in a temporary variable and release it with
of_node_put() once the existence check has been made.

Fixes: bc10d0ad540d ("PCI: keystone: Add support to build as a loadable module")
Signed-off-by: Yuho Choi <dbgh9129@gmail.com>
---
 drivers/pci/controller/dwc/pci-keystone.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index 278d2dba1db0..f1b27aed488d 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -1389,13 +1389,17 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr,
 
 static int __init ks_pcie_init(void)
 {
+	struct device_node *np;
 	/*
 	 * PCIe access errors that result into OCP errors are caught by ARM as
 	 * "External aborts"
 	 */
-	if (of_find_matching_node(NULL, ks_pcie_of_match))
+	np = of_find_matching_node(NULL, ks_pcie_of_match);
+	if (np) {
+		of_node_put(np);
 		hook_fault_code(17, ks_pcie_fault, SIGBUS, 0,
 				"Asynchronous external abort");
+	}
 
 	return platform_driver_register(&ks_pcie_driver);
 }
-- 
2.43.0

Re: [PATCH v1] PCI: keystone: Fix OF node reference leak in init

[Manivannan Sadhasivam]

On Tue, 30 Jun 2026 16:29:38 -0400, Yuho Choi wrote:
> of_find_matching_node() returns a device node with its reference count
> incremented. ks_pcie_init() only uses the returned node to decide whether
> to register the ARM external abort fault handler, but never drops the
> reference.
> 
> Store the lookup result in a temporary variable and release it with
> of_node_put() once the existence check has been made.
> 
> [...]

Applied, thanks!

[1/1] PCI: keystone: Fix OF node reference leak in init
      commit: 3260336defeb292a91de29e4d1d93469e3cec663

Best regards,
-- 
மணிவண்ணன் சதாசிவம்