* [PATCH v2] drm/qxl: remove dependency on DRM simple helpers
@ 2026-07-07 16:14 Diogo Silva
2026-07-08 12:33 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Diogo Silva @ 2026-07-07 16:14 UTC (permalink / raw)
To: Dave Airlie, Gerd Hoffmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: virtualization, spice-devel, dri-devel, linux-kernel, Diogo Silva
Simple KMS helper are deprecated since they only add an intermediate
layer between drivers and the atomic modesetting.
This patch removes the drm_simple_encoder_init() helper usage in the
qxl display driver by open coding it and using the encoder atomic
helpers directly. This is a step to eventually get rid of this simple
KMS helper, once all drivers that use it have been converted.
Signed-off-by: Diogo Silva <diogompaissilva@gmail.com>
---
Changes in v2:
- fix type error
- Link to v1: https://lore.kernel.org/r/20260707-qxl-simple-v1-1-524f6316b5d5@gmail.com
---
drivers/gpu/drm/qxl/qxl_display.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index a026bd35ef485..7f4178800afd7 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -31,12 +31,12 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_edid.h>
+#include <drm/drm_encoder.h>
#include <drm/drm_framebuffer.h>
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_plane_helper.h>
#include <drm/drm_print.h>
#include <drm/drm_probe_helper.h>
-#include <drm/drm_simple_kms_helper.h>
#include <drm/drm_gem_atomic_helper.h>
#include <drm/drm_vblank.h>
#include <drm/drm_vblank_helper.h>
@@ -1095,6 +1095,10 @@ static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = {
.best_encoder = qxl_best_encoder,
};
+static const struct drm_encoder_funcs qxl_encoder_funcs = {
+ .destroy = drm_encoder_cleanup,
+};
+
static enum drm_connector_status qxl_conn_detect(
struct drm_connector *connector,
bool force)
@@ -1169,10 +1173,10 @@ static int qdev_output_init(struct drm_device *dev, int num_output)
drm_connector_init(dev, &qxl_output->base,
&qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL);
- ret = drm_simple_encoder_init(dev, &qxl_output->enc,
- DRM_MODE_ENCODER_VIRTUAL);
+ ret = drm_encoder_init(dev, &qxl_output->enc, &qxl_encoder_funcs,
+ DRM_MODE_ENCODER_VIRTUAL, NULL);
if (ret) {
- drm_err(dev, "drm_simple_encoder_init() failed, error %d\n",
+ drm_err(dev, "drm_encoder_init() failed, error %d\n",
ret);
goto err_drm_connector_cleanup;
}
---
base-commit: ee2867b79f9bac3a6fc3221139b09598ce79099c
change-id: 20260707-qxl-simple-c01aa1a5c4eb
Best regards,
--
Diogo Silva <diogompaissilva@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/qxl: remove dependency on DRM simple helpers
2026-07-07 16:14 [PATCH v2] drm/qxl: remove dependency on DRM simple helpers Diogo Silva
@ 2026-07-08 12:33 ` Thomas Zimmermann
2026-07-10 13:11 ` Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2026-07-08 12:33 UTC (permalink / raw)
To: Diogo Silva, Dave Airlie, Gerd Hoffmann, Maarten Lankhorst,
Maxime Ripard, David Airlie, Simona Vetter
Cc: virtualization, spice-devel, dri-devel, linux-kernel
Am 07.07.26 um 18:14 schrieb Diogo Silva:
> Simple KMS helper are deprecated since they only add an intermediate
> layer between drivers and the atomic modesetting.
> This patch removes the drm_simple_encoder_init() helper usage in the
> qxl display driver by open coding it and using the encoder atomic
> helpers directly. This is a step to eventually get rid of this simple
> KMS helper, once all drivers that use it have been converted.
>
> Signed-off-by: Diogo Silva <diogompaissilva@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> Changes in v2:
> - fix type error
> - Link to v1: https://lore.kernel.org/r/20260707-qxl-simple-v1-1-524f6316b5d5@gmail.com
> ---
> drivers/gpu/drm/qxl/qxl_display.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
> index a026bd35ef485..7f4178800afd7 100644
> --- a/drivers/gpu/drm/qxl/qxl_display.c
> +++ b/drivers/gpu/drm/qxl/qxl_display.c
> @@ -31,12 +31,12 @@
> #include <drm/drm_atomic.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_edid.h>
> +#include <drm/drm_encoder.h>
> #include <drm/drm_framebuffer.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> #include <drm/drm_plane_helper.h>
> #include <drm/drm_print.h>
> #include <drm/drm_probe_helper.h>
> -#include <drm/drm_simple_kms_helper.h>
> #include <drm/drm_gem_atomic_helper.h>
> #include <drm/drm_vblank.h>
> #include <drm/drm_vblank_helper.h>
> @@ -1095,6 +1095,10 @@ static const struct drm_connector_helper_funcs qxl_connector_helper_funcs = {
> .best_encoder = qxl_best_encoder,
> };
>
> +static const struct drm_encoder_funcs qxl_encoder_funcs = {
> + .destroy = drm_encoder_cleanup,
> +};
> +
> static enum drm_connector_status qxl_conn_detect(
> struct drm_connector *connector,
> bool force)
> @@ -1169,10 +1173,10 @@ static int qdev_output_init(struct drm_device *dev, int num_output)
> drm_connector_init(dev, &qxl_output->base,
> &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL);
>
> - ret = drm_simple_encoder_init(dev, &qxl_output->enc,
> - DRM_MODE_ENCODER_VIRTUAL);
> + ret = drm_encoder_init(dev, &qxl_output->enc, &qxl_encoder_funcs,
> + DRM_MODE_ENCODER_VIRTUAL, NULL);
> if (ret) {
> - drm_err(dev, "drm_simple_encoder_init() failed, error %d\n",
> + drm_err(dev, "drm_encoder_init() failed, error %d\n",
> ret);
> goto err_drm_connector_cleanup;
> }
>
> ---
> base-commit: ee2867b79f9bac3a6fc3221139b09598ce79099c
> change-id: 20260707-qxl-simple-c01aa1a5c4eb
>
> Best regards,
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] drm/qxl: remove dependency on DRM simple helpers
2026-07-08 12:33 ` Thomas Zimmermann
@ 2026-07-10 13:11 ` Thomas Zimmermann
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2026-07-10 13:11 UTC (permalink / raw)
To: Diogo Silva, Dave Airlie, Gerd Hoffmann, Maarten Lankhorst,
Maxime Ripard, David Airlie, Simona Vetter
Cc: virtualization, spice-devel, dri-devel, linux-kernel
Merged into drm-misc-next
Am 08.07.26 um 14:33 schrieb Thomas Zimmermann:
>
>
> Am 07.07.26 um 18:14 schrieb Diogo Silva:
>> Simple KMS helper are deprecated since they only add an intermediate
>> layer between drivers and the atomic modesetting.
>> This patch removes the drm_simple_encoder_init() helper usage in the
>> qxl display driver by open coding it and using the encoder atomic
>> helpers directly. This is a step to eventually get rid of this simple
>> KMS helper, once all drivers that use it have been converted.
>>
>> Signed-off-by: Diogo Silva <diogompaissilva@gmail.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
>> ---
>> Changes in v2:
>> - fix type error
>> - Link to v1:
>> https://lore.kernel.org/r/20260707-qxl-simple-v1-1-524f6316b5d5@gmail.com
>> ---
>> drivers/gpu/drm/qxl/qxl_display.c | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/qxl/qxl_display.c
>> b/drivers/gpu/drm/qxl/qxl_display.c
>> index a026bd35ef485..7f4178800afd7 100644
>> --- a/drivers/gpu/drm/qxl/qxl_display.c
>> +++ b/drivers/gpu/drm/qxl/qxl_display.c
>> @@ -31,12 +31,12 @@
>> #include <drm/drm_atomic.h>
>> #include <drm/drm_atomic_helper.h>
>> #include <drm/drm_edid.h>
>> +#include <drm/drm_encoder.h>
>> #include <drm/drm_framebuffer.h>
>> #include <drm/drm_gem_framebuffer_helper.h>
>> #include <drm/drm_plane_helper.h>
>> #include <drm/drm_print.h>
>> #include <drm/drm_probe_helper.h>
>> -#include <drm/drm_simple_kms_helper.h>
>> #include <drm/drm_gem_atomic_helper.h>
>> #include <drm/drm_vblank.h>
>> #include <drm/drm_vblank_helper.h>
>> @@ -1095,6 +1095,10 @@ static const struct drm_connector_helper_funcs
>> qxl_connector_helper_funcs = {
>> .best_encoder = qxl_best_encoder,
>> };
>> +static const struct drm_encoder_funcs qxl_encoder_funcs = {
>> + .destroy = drm_encoder_cleanup,
>> +};
>> +
>> static enum drm_connector_status qxl_conn_detect(
>> struct drm_connector *connector,
>> bool force)
>> @@ -1169,10 +1173,10 @@ static int qdev_output_init(struct drm_device
>> *dev, int num_output)
>> drm_connector_init(dev, &qxl_output->base,
>> &qxl_connector_funcs, DRM_MODE_CONNECTOR_VIRTUAL);
>> - ret = drm_simple_encoder_init(dev, &qxl_output->enc,
>> - DRM_MODE_ENCODER_VIRTUAL);
>> + ret = drm_encoder_init(dev, &qxl_output->enc, &qxl_encoder_funcs,
>> + DRM_MODE_ENCODER_VIRTUAL, NULL);
>> if (ret) {
>> - drm_err(dev, "drm_simple_encoder_init() failed, error %d\n",
>> + drm_err(dev, "drm_encoder_init() failed, error %d\n",
>> ret);
>> goto err_drm_connector_cleanup;
>> }
>>
>> ---
>> base-commit: ee2867b79f9bac3a6fc3221139b09598ce79099c
>> change-id: 20260707-qxl-simple-c01aa1a5c4eb
>>
>> Best regards,
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-10 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-07 16:14 [PATCH v2] drm/qxl: remove dependency on DRM simple helpers Diogo Silva
2026-07-08 12:33 ` Thomas Zimmermann
2026-07-10 13:11 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®