mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops
@ 2026-07-10 16:12 Ben Dooks
  2026-07-13 11:25 ` Ulf Hansson
  2026-07-15  2:16 ` Shawn Lin
  0 siblings, 2 replies; 3+ messages in thread
From: Ben Dooks @ 2026-07-10 16:12 UTC (permalink / raw)
  To: Jaehoon Chung, Shawn Lin, Ulf Hansson, linux-mmc, linux-kernel; +Cc: Ben Dooks

The dw_mci_pmops is exported out of dw_mmc.c so move the declaration of
ton dw_mmc.h from dw_mmc-pltfm.h to fix the following sparse warning:

drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
v2:
  - changed to moving the definition and re-worded commit
---
 drivers/mmc/host/dw_mmc-pltfm.h | 1 -
 drivers/mmc/host/dw_mmc.h       | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc-pltfm.h b/drivers/mmc/host/dw_mmc-pltfm.h
index ef1b05d484c3..f3193662abf1 100644
--- a/drivers/mmc/host/dw_mmc-pltfm.h
+++ b/drivers/mmc/host/dw_mmc-pltfm.h
@@ -11,6 +11,5 @@
 extern int dw_mci_pltfm_register(struct platform_device *pdev,
 				const struct dw_mci_drv_data *drv_data);
 extern void dw_mci_pltfm_remove(struct platform_device *pdev);
-extern const struct dev_pm_ops dw_mci_pmops;
 
 #endif /* _DW_MMC_PLTFM_H_ */
diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
index 9ffcd3946cff..38610c89d54a 100644
--- a/drivers/mmc/host/dw_mmc.h
+++ b/drivers/mmc/host/dw_mmc.h
@@ -19,6 +19,8 @@
 #include <linux/interrupt.h>
 #include <linux/workqueue.h>
 
+extern const struct dev_pm_ops dw_mci_pmops;
+
 enum dw_mci_state {
 	STATE_IDLE = 0,
 	STATE_SENDING_CMD,
-- 
2.37.2.352.g3c44437643


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops
  2026-07-10 16:12 [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops Ben Dooks
@ 2026-07-13 11:25 ` Ulf Hansson
  2026-07-15  2:16 ` Shawn Lin
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2026-07-13 11:25 UTC (permalink / raw)
  To: Ben Dooks; +Cc: Jaehoon Chung, Shawn Lin, Ulf Hansson, linux-mmc, linux-kernel

On Fri, Jul 10, 2026 at 6:13 PM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The dw_mci_pmops is exported out of dw_mmc.c so move the declaration of
> ton dw_mmc.h from dw_mmc-pltfm.h to fix the following sparse warning:
>
> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>

Applied for next, thanks!

Kind regards
Uffe


> ---
> v2:
>   - changed to moving the definition and re-worded commit
> ---
>  drivers/mmc/host/dw_mmc-pltfm.h | 1 -
>  drivers/mmc/host/dw_mmc.h       | 2 ++
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-pltfm.h b/drivers/mmc/host/dw_mmc-pltfm.h
> index ef1b05d484c3..f3193662abf1 100644
> --- a/drivers/mmc/host/dw_mmc-pltfm.h
> +++ b/drivers/mmc/host/dw_mmc-pltfm.h
> @@ -11,6 +11,5 @@
>  extern int dw_mci_pltfm_register(struct platform_device *pdev,
>                                 const struct dw_mci_drv_data *drv_data);
>  extern void dw_mci_pltfm_remove(struct platform_device *pdev);
> -extern const struct dev_pm_ops dw_mci_pmops;
>
>  #endif /* _DW_MMC_PLTFM_H_ */
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 9ffcd3946cff..38610c89d54a 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -19,6 +19,8 @@
>  #include <linux/interrupt.h>
>  #include <linux/workqueue.h>
>
> +extern const struct dev_pm_ops dw_mci_pmops;
> +
>  enum dw_mci_state {
>         STATE_IDLE = 0,
>         STATE_SENDING_CMD,
> --
> 2.37.2.352.g3c44437643
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops
  2026-07-10 16:12 [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops Ben Dooks
  2026-07-13 11:25 ` Ulf Hansson
@ 2026-07-15  2:16 ` Shawn Lin
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Lin @ 2026-07-15  2:16 UTC (permalink / raw)
  To: Ben Dooks, Ulf Hansson; +Cc: shawn.lin, Jaehoon Chung, linux-mmc, linux-kernel

在 2026/07/11 星期六 0:12, Ben Dooks 写道:
> The dw_mci_pmops is exported out of dw_mmc.c so move the declaration of
> ton dw_mmc.h from dw_mmc-pltfm.h to fix the following sparse warning:
> 
> drivers/mmc/host/dw_mmc.c:3512:25: warning: symbol 'dw_mci_pmops' was not declared. Should it be static?
> 

Sorry for late response, this looks good to me,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>


> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> v2:
>    - changed to moving the definition and re-worded commit
> ---
>   drivers/mmc/host/dw_mmc-pltfm.h | 1 -
>   drivers/mmc/host/dw_mmc.h       | 2 ++
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-pltfm.h b/drivers/mmc/host/dw_mmc-pltfm.h
> index ef1b05d484c3..f3193662abf1 100644
> --- a/drivers/mmc/host/dw_mmc-pltfm.h
> +++ b/drivers/mmc/host/dw_mmc-pltfm.h
> @@ -11,6 +11,5 @@
>   extern int dw_mci_pltfm_register(struct platform_device *pdev,
>   				const struct dw_mci_drv_data *drv_data);
>   extern void dw_mci_pltfm_remove(struct platform_device *pdev);
> -extern const struct dev_pm_ops dw_mci_pmops;
>   
>   #endif /* _DW_MMC_PLTFM_H_ */
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 9ffcd3946cff..38610c89d54a 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -19,6 +19,8 @@
>   #include <linux/interrupt.h>
>   #include <linux/workqueue.h>
>   
> +extern const struct dev_pm_ops dw_mci_pmops;
> +
>   enum dw_mci_state {
>   	STATE_IDLE = 0,
>   	STATE_SENDING_CMD,


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-15  2:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-10 16:12 [PATCH v2] mmc: dw_mmc: move declaration of dw_mci_pmops Ben Dooks
2026-07-13 11:25 ` Ulf Hansson
2026-07-15  2:16 ` Shawn Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®