[PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()

[PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()

[Andy Shevchenko]

No more users.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

As of today must go via MFD tree where last user of this API was
converted by the commit 62acd2babc1d ("mfd: si476x: Modernize GPIO handling")

 include/linux/gpio/legacy.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/linux/gpio/legacy.h b/include/linux/gpio/legacy.h
index d4273162ed13..1a6e46bc85a0 100644
--- a/include/linux/gpio/legacy.h
+++ b/include/linux/gpio/legacy.h
@@ -63,10 +63,6 @@ static inline int gpio_get_value_cansleep(unsigned gpio)
 {
 	return gpiod_get_raw_value_cansleep(gpio_to_desc(gpio));
 }
-static inline void gpio_set_value_cansleep(unsigned gpio, int value)
-{
-	gpiod_set_raw_value_cansleep(gpio_to_desc(gpio), value);
-}
 
 static inline int gpio_get_value(unsigned gpio)
 {
@@ -140,12 +136,6 @@ static inline int gpio_get_value_cansleep(unsigned gpio)
 	return 0;
 }
 
-static inline void gpio_set_value_cansleep(unsigned gpio, int value)
-{
-	/* GPIO can never have been requested or set as output */
-	WARN_ON(1);
-}
-
 static inline int gpio_to_irq(unsigned gpio)
 {
 	/* GPIO can never have been requested or set as input */
-- 
2.50.1

Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()

[Bartosz Golaszewski]

On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
> No more users.
> 
> 

Yes please! Thank you!

[1/1] gpio: legacy: Kill gpio_set_value_cansleep()
      https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()

[Andy Shevchenko]

On Thu, Jul 16, 2026 at 09:58:42AM +0200, Bartosz Golaszewski wrote:
> 
> On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
> > No more users.
> 
> Yes please! Thank you!

> [1/1] gpio: legacy: Kill gpio_set_value_cansleep()
>       https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5

Not sure, I put in the comment that this should be part of MFD, otherwise
the one driver will fail (the conversion change in MFD tree only).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()

[Bartosz Golaszewski]

On Thu, 16 Jul 2026 10:30:00 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> On Thu, Jul 16, 2026 at 09:58:42AM +0200, Bartosz Golaszewski wrote:
>>
>> On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
>> > No more users.
>>
>> Yes please! Thank you!
>
>> [1/1] gpio: legacy: Kill gpio_set_value_cansleep()
>>       https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5
>
> Not sure, I put in the comment that this should be part of MFD, otherwise
> the one driver will fail (the conversion change in MFD tree only).
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>

Ah dang it, should have read what's below the commit message. Backed out now.

Bart

Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()

[Bartosz Golaszewski]

On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> No more users.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> As of today must go via MFD tree where last user of this API was
> converted by the commit 62acd2babc1d ("mfd: si476x: Modernize GPIO handling")
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>