* [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
@ 2026-07-15 19:23 Andy Shevchenko
2026-07-16 7:58 ` Bartosz Golaszewski
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Andy Shevchenko @ 2026-07-15 19:23 UTC (permalink / raw)
To: linux-gpio, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski, Lee Jones, mfd, Andy Shevchenko
No more users.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
As of today must go via MFD tree where last user of this API was
converted by the commit 62acd2babc1d ("mfd: si476x: Modernize GPIO handling")
include/linux/gpio/legacy.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/include/linux/gpio/legacy.h b/include/linux/gpio/legacy.h
index d4273162ed13..1a6e46bc85a0 100644
--- a/include/linux/gpio/legacy.h
+++ b/include/linux/gpio/legacy.h
@@ -63,10 +63,6 @@ static inline int gpio_get_value_cansleep(unsigned gpio)
{
return gpiod_get_raw_value_cansleep(gpio_to_desc(gpio));
}
-static inline void gpio_set_value_cansleep(unsigned gpio, int value)
-{
- gpiod_set_raw_value_cansleep(gpio_to_desc(gpio), value);
-}
static inline int gpio_get_value(unsigned gpio)
{
@@ -140,12 +136,6 @@ static inline int gpio_get_value_cansleep(unsigned gpio)
return 0;
}
-static inline void gpio_set_value_cansleep(unsigned gpio, int value)
-{
- /* GPIO can never have been requested or set as output */
- WARN_ON(1);
-}
-
static inline int gpio_to_irq(unsigned gpio)
{
/* GPIO can never have been requested or set as input */
--
2.50.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-15 19:23 [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep() Andy Shevchenko
@ 2026-07-16 7:58 ` Bartosz Golaszewski
2026-07-16 8:30 ` Andy Shevchenko
2026-07-16 8:35 ` Bartosz Golaszewski
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-07-16 7:58 UTC (permalink / raw)
To: linux-gpio, linux-kernel, Andy Shevchenko
Cc: Bartosz Golaszewski, Linus Walleij, Bartosz Golaszewski, Lee Jones, mfd
On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
> No more users.
>
>
Yes please! Thank you!
[1/1] gpio: legacy: Kill gpio_set_value_cansleep()
https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-16 7:58 ` Bartosz Golaszewski
@ 2026-07-16 8:30 ` Andy Shevchenko
2026-07-16 8:35 ` Bartosz Golaszewski
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2026-07-16 8:30 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, Linus Walleij, Bartosz Golaszewski,
Lee Jones, mfd
On Thu, Jul 16, 2026 at 09:58:42AM +0200, Bartosz Golaszewski wrote:
>
> On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
> > No more users.
>
> Yes please! Thank you!
> [1/1] gpio: legacy: Kill gpio_set_value_cansleep()
> https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5
Not sure, I put in the comment that this should be part of MFD, otherwise
the one driver will fail (the conversion change in MFD tree only).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-16 8:30 ` Andy Shevchenko
@ 2026-07-16 8:35 ` Bartosz Golaszewski
2026-10-13 13:10 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-07-16 8:35 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Linus Walleij, Bartosz Golaszewski,
Lee Jones, mfd, Bartosz Golaszewski
On Thu, 16 Jul 2026 10:30:00 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> On Thu, Jul 16, 2026 at 09:58:42AM +0200, Bartosz Golaszewski wrote:
>>
>> On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
>> > No more users.
>>
>> Yes please! Thank you!
>
>> [1/1] gpio: legacy: Kill gpio_set_value_cansleep()
>> https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5
>
> Not sure, I put in the comment that this should be part of MFD, otherwise
> the one driver will fail (the conversion change in MFD tree only).
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>
Ah dang it, should have read what's below the commit message. Backed out now.
Bart
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-16 8:35 ` Bartosz Golaszewski
@ 2026-10-13 13:10 ` Andy Shevchenko
2026-10-13 13:37 ` Bartosz Golaszewski
0 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2026-10-13 13:10 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: linux-gpio, linux-kernel, Linus Walleij, Lee Jones, mfd,
Bartosz Golaszewski
On Thu, Jul 16, 2026 at 01:35:18AM -0700, Bartosz Golaszewski wrote:
> On Thu, 16 Jul 2026 10:30:00 +0200, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> said:
> > On Thu, Jul 16, 2026 at 09:58:42AM +0200, Bartosz Golaszewski wrote:
> >>
> >> On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
> >> > No more users.
> >>
> >> Yes please! Thank you!
> >
> >> [1/1] gpio: legacy: Kill gpio_set_value_cansleep()
> >> https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5
> >
> > Not sure, I put in the comment that this should be part of MFD, otherwise
> > the one driver will fail (the conversion change in MFD tree only).
>
> Ah dang it, should have read what's below the commit message. Backed out now.
Now it can be applied, can't it?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-10-13 13:10 ` Andy Shevchenko
@ 2026-10-13 13:37 ` Bartosz Golaszewski
0 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-10-13 13:37 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Linus Walleij, Lee Jones, mfd,
Bartosz Golaszewski, Bartosz Golaszewski
On Tue, 13 Oct 2026 15:10:25 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> On Thu, Jul 16, 2026 at 01:35:18AM -0700, Bartosz Golaszewski wrote:
>> On Thu, 16 Jul 2026 10:30:00 +0200, Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com> said:
>> > On Thu, Jul 16, 2026 at 09:58:42AM +0200, Bartosz Golaszewski wrote:
>> >>
>> >> On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
>> >> > No more users.
>> >>
>> >> Yes please! Thank you!
>> >
>> >> [1/1] gpio: legacy: Kill gpio_set_value_cansleep()
>> >> https://git.kernel.org/brgl/c/aa4bc3b7d36d52caf7c3d3214ae4ce96d609e8c5
>> >
>> > Not sure, I put in the comment that this should be part of MFD, otherwise
>> > the one driver will fail (the conversion change in MFD tree only).
>>
>> Ah dang it, should have read what's below the commit message. Backed out now.
>
> Now it can be applied, can't it?
>
Sure seems like it! :)
Bartosz
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-15 19:23 [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep() Andy Shevchenko
2026-07-16 7:58 ` Bartosz Golaszewski
@ 2026-07-16 8:35 ` Bartosz Golaszewski
2026-07-24 21:45 ` Linus Walleij
2026-10-13 13:36 ` Bartosz Golaszewski
3 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-07-16 8:35 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Bartosz Golaszewski, Lee Jones, mfd, linux-gpio,
linux-kernel
On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> said:
> No more users.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> As of today must go via MFD tree where last user of this API was
> converted by the commit 62acd2babc1d ("mfd: si476x: Modernize GPIO handling")
>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-15 19:23 [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep() Andy Shevchenko
2026-07-16 7:58 ` Bartosz Golaszewski
2026-07-16 8:35 ` Bartosz Golaszewski
@ 2026-07-24 21:45 ` Linus Walleij
2026-10-13 13:36 ` Bartosz Golaszewski
3 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2026-07-24 21:45 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-gpio, linux-kernel, Bartosz Golaszewski, Lee Jones, mfd
On Wed, Jul 15, 2026 at 9:24 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> No more users.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep()
2026-07-15 19:23 [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep() Andy Shevchenko
` (2 preceding siblings ...)
2026-07-24 21:45 ` Linus Walleij
@ 2026-10-13 13:36 ` Bartosz Golaszewski
3 siblings, 0 replies; 9+ messages in thread
From: Bartosz Golaszewski @ 2026-10-13 13:36 UTC (permalink / raw)
To: linux-gpio, linux-kernel, Andy Shevchenko
Cc: Bartosz Golaszewski, Linus Walleij, Bartosz Golaszewski, Lee Jones, mfd
On Wed, 15 Jul 2026 21:23:30 +0200, Andy Shevchenko wrote:
> No more users.
>
>
Applied, thanks!
[1/1] gpio: legacy: Kill gpio_set_value_cansleep()
https://git.kernel.org/brgl/c/93f4db6fcf0bf62a4e00c9beb571b35e6e3860de
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2026-10-13 13:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-15 19:23 [PATCH v1 1/1] gpio: legacy: Kill gpio_set_value_cansleep() Andy Shevchenko
2026-07-16 7:58 ` Bartosz Golaszewski
2026-07-16 8:30 ` Andy Shevchenko
2026-07-16 8:35 ` Bartosz Golaszewski
2026-10-13 13:10 ` Andy Shevchenko
2026-10-13 13:37 ` Bartosz Golaszewski
2026-07-16 8:35 ` Bartosz Golaszewski
2026-07-24 21:45 ` Linus Walleij
2026-10-13 13:36 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®