From: Pan Chuang <panchuang@vivo.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-crypto@vger.kernel.org (open list:CRYPTO API),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/Microchip (AT91) SoC support),
linux-kernel@vger.kernel.org (open list),
imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
ARCHITECTURE)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 04/12] crypto: Remove redundant dev_err()/dev_err_probe()
Date: Fri, 17 Jul 2026 16:00:18 +0800 [thread overview]
Message-ID: <20260717080045.191538-5-panchuang@vivo.com> (raw)
In-Reply-To: <20260717080045.191538-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/atmel-aes.c | 4 +---
drivers/crypto/atmel-sha.c | 4 +---
drivers/crypto/atmel-tdes.c | 4 +---
drivers/crypto/img-hash.c | 4 +---
drivers/crypto/mxs-dcp.c | 8 ++------
drivers/crypto/omap-aes.c | 4 +---
drivers/crypto/omap-des.c | 4 +---
drivers/crypto/omap-sham.c | 5 +----
drivers/crypto/sahara.c | 3 +--
9 files changed, 10 insertions(+), 30 deletions(-)
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index 30acfd937d54..50d97cef75b8 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -2364,10 +2364,8 @@ static int atmel_aes_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, aes_dd->irq, atmel_aes_irq,
IRQF_SHARED, "atmel-aes", aes_dd);
- if (err) {
- dev_err(dev, "unable to request aes irq.\n");
+ if (err)
goto err_tasklet_kill;
- }
/* Initializing the clock */
aes_dd->iclk = devm_clk_get_prepared(&pdev->dev, "aes_clk");
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 66323ac63406..48f54b615504 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -2604,10 +2604,8 @@ static int atmel_sha_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, sha_dd->irq, atmel_sha_irq,
IRQF_SHARED, "atmel-sha", sha_dd);
- if (err) {
- dev_err(dev, "unable to request sha irq.\n");
+ if (err)
goto err_tasklet_kill;
- }
/* Initializing the clock */
sha_dd->iclk = devm_clk_get_prepared(&pdev->dev, "sha_clk");
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 48cd537f001e..4511166fd74d 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -978,10 +978,8 @@ static int atmel_tdes_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, tdes_dd->irq, atmel_tdes_irq,
IRQF_SHARED, "atmel-tdes", tdes_dd);
- if (err) {
- dev_err(dev, "unable to request tdes irq.\n");
+ if (err)
goto err_tasklet_kill;
- }
/* Initializing the clock */
tdes_dd->iclk = devm_clk_get(&pdev->dev, "tdes_clk");
diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index 0f19dcc2f388..1ccfc0eccc73 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -966,10 +966,8 @@ static int img_hash_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq, img_irq_handler, 0,
dev_name(dev), hdev);
- if (err) {
- dev_err(dev, "unable to request irq\n");
+ if (err)
goto res_err;
- }
dev_dbg(dev, "using IRQ channel %d\n", irq);
hdev->hash_clk = devm_clk_get_enabled(&pdev->dev, "hash");
diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c
index 595b2fd84667..c75a06999787 100644
--- a/drivers/crypto/mxs-dcp.c
+++ b/drivers/crypto/mxs-dcp.c
@@ -1085,17 +1085,13 @@ static int mxs_dcp_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, dcp_vmi_irq, mxs_dcp_irq, 0,
"dcp-vmi-irq", sdcp);
- if (ret) {
- dev_err(dev, "Failed to claim DCP VMI IRQ!\n");
+ if (ret)
return ret;
- }
ret = devm_request_irq(dev, dcp_irq, mxs_dcp_irq, 0,
"dcp-irq", sdcp);
- if (ret) {
- dev_err(dev, "Failed to claim DCP IRQ!\n");
+ if (ret)
return ret;
- }
/* Allocate coherent helper block. */
sdcp->coh = devm_kzalloc(dev, sizeof(*sdcp->coh) + DCP_ALIGNMENT,
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index f31555c0d715..711909de2013 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1172,10 +1172,8 @@ static int omap_aes_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq, omap_aes_irq, 0,
dev_name(dev), dd);
- if (err) {
- dev_err(dev, "Unable to grab omap-aes IRQ\n");
+ if (err)
goto err_irq;
- }
}
spin_lock_init(&dd->lock);
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index dfaf831dd8ec..3b7104cb4487 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -1017,10 +1017,8 @@ static int omap_des_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq, omap_des_irq, 0,
dev_name(dev), dd);
- if (err) {
- dev_err(dev, "Unable to grab omap-des IRQ\n");
+ if (err)
goto err_irq;
- }
}
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index be1ac640ee59..8f95c381f4c8 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -2092,11 +2092,8 @@ static int omap_sham_probe(struct platform_device *pdev)
err = devm_request_irq(dev, dd->irq, dd->pdata->intr_hdlr,
IRQF_TRIGGER_NONE, dev_name(dev), dd);
- if (err) {
- dev_err(dev, "unable to request irq %d, err = %d\n",
- dd->irq, err);
+ if (err)
goto data_err;
- }
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 533080b0cddc..d586f1315de1 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -1305,8 +1305,7 @@ static int sahara_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, irq, sahara_irq_handler,
0, dev_name(&pdev->dev), dev);
if (err)
- return dev_err_probe(&pdev->dev, err,
- "failed to request irq\n");
+ return err;
/* clocks */
dev->clk_ipg = devm_clk_get_enabled(&pdev->dev, "ipg");
--
2.34.1
next prev parent reply other threads:[~2026-07-17 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 8:00 ` [PATCH 01/12] crypto: allwinner - Remove redundant dev_err() Pan Chuang
2026-07-17 8:00 ` [PATCH 02/12] crypto: amlogic " Pan Chuang
2026-07-17 8:00 ` [PATCH 03/12] crypto: aspeed " Pan Chuang
2026-07-17 8:00 ` Pan Chuang [this message]
2026-07-17 8:00 ` [PATCH 05/12] crypto: caam " Pan Chuang
2026-07-17 8:00 ` [PATCH 06/12] crypto: ccree " Pan Chuang
2026-07-17 8:00 ` [PATCH 07/12] crypto: sl3516 " Pan Chuang
2026-07-17 8:00 ` [PATCH 08/12] crypto: safexcel " Pan Chuang
2026-07-17 8:00 ` [PATCH 09/12] crypto: keembay " Pan Chuang
2026-07-17 8:00 ` [PATCH 10/12] crypto: octeontx2 " Pan Chuang
2026-07-17 8:00 ` [PATCH 11/12] crypto: rockchip " Pan Chuang
2026-07-17 8:00 ` [PATCH 12/12] crypto: stm32 " Pan Chuang
2026-07-17 8:59 ` Maxime MERE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717080045.191538-5-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Frank.Li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox