From: Pan Chuang <panchuang@vivo.com>
To: Hans Ulli Kroll <ulli.kroll@googlemail.com>,
Linus Walleij <linusw@kernel.org>,
Corentin Labbe <clabbe@baylibre.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM/CORTINA
SYSTEMS GEMINI ARM ARCHITECTURE),
linux-crypto@vger.kernel.org (open list:GEMINI CRYPTO DRIVER),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 07/12] crypto: sl3516 - Remove redundant dev_err()
Date: Fri, 17 Jul 2026 16:00:21 +0800 [thread overview]
Message-ID: <20260717080045.191538-8-panchuang@vivo.com> (raw)
In-Reply-To: <20260717080045.191538-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/gemini/sl3516-ce-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/gemini/sl3516-ce-core.c b/drivers/crypto/gemini/sl3516-ce-core.c
index f7e0e3fea15c..c1df5f96ea42 100644
--- a/drivers/crypto/gemini/sl3516-ce-core.c
+++ b/drivers/crypto/gemini/sl3516-ce-core.c
@@ -414,10 +414,8 @@ static int sl3516_ce_probe(struct platform_device *pdev)
return irq;
err = devm_request_irq(&pdev->dev, irq, ce_irq_handler, 0, "crypto", ce);
- if (err) {
- dev_err(ce->dev, "Cannot request Crypto Engine IRQ (err=%d)\n", err);
+ if (err)
return err;
- }
ce->reset = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(ce->reset))
--
2.34.1
next prev parent reply other threads:[~2026-07-17 8:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 8:00 ` [PATCH 01/12] crypto: allwinner - Remove redundant dev_err() Pan Chuang
2026-07-17 8:00 ` [PATCH 02/12] crypto: amlogic " Pan Chuang
2026-07-17 8:00 ` [PATCH 03/12] crypto: aspeed " Pan Chuang
2026-07-17 8:00 ` [PATCH 04/12] crypto: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 8:00 ` [PATCH 05/12] crypto: caam - Remove redundant dev_err() Pan Chuang
2026-07-17 8:00 ` [PATCH 06/12] crypto: ccree " Pan Chuang
2026-07-17 8:00 ` Pan Chuang [this message]
2026-07-17 8:00 ` [PATCH 08/12] crypto: safexcel " Pan Chuang
2026-07-17 8:00 ` [PATCH 09/12] crypto: keembay " Pan Chuang
2026-07-17 8:00 ` [PATCH 10/12] crypto: octeontx2 " Pan Chuang
2026-07-17 8:00 ` [PATCH 11/12] crypto: rockchip " Pan Chuang
2026-07-17 8:00 ` [PATCH 12/12] crypto: stm32 " Pan Chuang
2026-07-17 8:59 ` Maxime MERE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717080045.191538-8-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ulli.kroll@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox