Re: [PATCH 12/12] crypto: stm32 - Remove redundant dev_err()

[Maxime MERE <maxime.mere@foss.st.com>]

Acked-by: Maxime Méré <maxime.mere@foss.st.com>

On 7/17/26 10:00, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
>   drivers/crypto/stm32/stm32-cryp.c | 4 +---
>   drivers/crypto/stm32/stm32-hash.c | 4 +---
>   2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
> index b79877099942..3fc2db290b0f 100644
> --- a/drivers/crypto/stm32/stm32-cryp.c
> +++ b/drivers/crypto/stm32/stm32-cryp.c
> @@ -2590,10 +2590,8 @@ static int stm32_cryp_probe(struct platform_device *pdev)
>   	ret = devm_request_threaded_irq(dev, irq, stm32_cryp_irq,
>   					stm32_cryp_irq_thread, IRQF_ONESHOT,
>   					dev_name(dev), cryp);
> -	if (ret) {
> -		dev_err(dev, "Cannot grab IRQ\n");
> +	if (ret)
>   		return ret;
> -	}
>   
>   	cryp->clk = devm_clk_get(dev, NULL);
>   	if (IS_ERR(cryp->clk)) {
> diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
> index dada5951082c..e6a1e9b9f88d 100644
> --- a/drivers/crypto/stm32/stm32-hash.c
> +++ b/drivers/crypto/stm32/stm32-hash.c
> @@ -2356,10 +2356,8 @@ static int stm32_hash_probe(struct platform_device *pdev)
>   						stm32_hash_irq_thread,
>   						IRQF_ONESHOT,
>   						dev_name(dev), hdev);
> -		if (ret) {
> -			dev_err(dev, "Cannot grab IRQ\n");
> +		if (ret)
>   			return ret;
> -		}
>   	} else {
>   		dev_info(dev, "No IRQ, use polling mode\n");
>   		hdev->polled = true;