mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Salah Triki" <salah.triki@gmail.com>,
	"Yury Norov" <ynorov@nvidia.com>,
	"Pan Chuang" <panchuang@vivo.com>,
	"Achim Gratz" <Achim.Gratz@Stromeko.DE>,
	"Yash Suthar" <yashsuthar983@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Dixit Parmar" <dixitparmar19@gmail.com>,
	"Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>,
	"Shi Hao" <i.shihao.999@gmail.com>,
	linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe()
Date: Fri, 17 Jul 2026 17:42:33 +0800	[thread overview]
Message-ID: <20260717094408.509583-11-panchuang@vivo.com> (raw)
In-Reply-To: <20260717094408.509583-1-panchuang@vivo.com>

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/iio/pressure/bmp280-core.c | 3 +--
 drivers/iio/pressure/dlhl60d.c     | 4 +---
 drivers/iio/pressure/rohm-bm1390.c | 2 +-
 drivers/iio/pressure/zpa2326.c     | 5 +----
 4 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
index c89153dcc323..6270309db5bb 100644
--- a/drivers/iio/pressure/bmp280-core.c
+++ b/drivers/iio/pressure/bmp280-core.c
@@ -1339,7 +1339,7 @@ static int __bmp280_trigger_probe(struct iio_dev *indio_dev,
 					irq_thread_handler, IRQF_ONESHOT,
 					indio_dev->name, indio_dev);
 	if (ret)
-		return dev_err_probe(dev, ret, "request IRQ failed.\n");
+		return ret;
 
 	ret = devm_iio_trigger_register(data->dev, data->trig);
 	if (ret)
@@ -3070,7 +3070,6 @@ static int bmp085_trigger_probe(struct iio_dev *indio_dev)
 			       indio_dev->name, data);
 	if (ret) {
 		/* Bail out without IRQ but keep the driver in place */
-		dev_err(dev, "unable to request DRDY IRQ\n");
 		return 0;
 	}
 
diff --git a/drivers/iio/pressure/dlhl60d.c b/drivers/iio/pressure/dlhl60d.c
index 01a873165923..961888fd03a7 100644
--- a/drivers/iio/pressure/dlhl60d.c
+++ b/drivers/iio/pressure/dlhl60d.c
@@ -309,10 +309,8 @@ static int dlh_probe(struct i2c_client *client)
 		ret = devm_request_irq(&client->dev, client->irq, dlh_interrupt,
 				       IRQF_TRIGGER_RISING | IRQF_NO_THREAD,
 				       st->info->name, indio_dev);
-		if (ret) {
-			dev_err(&client->dev, "failed to allocate threaded irq");
+		if (ret)
 			return ret;
-		}
 
 		st->use_interrupt = true;
 		init_completion(&st->completion);
diff --git a/drivers/iio/pressure/rohm-bm1390.c b/drivers/iio/pressure/rohm-bm1390.c
index 9d72ae64126c..57941fb4a535 100644
--- a/drivers/iio/pressure/rohm-bm1390.c
+++ b/drivers/iio/pressure/rohm-bm1390.c
@@ -805,7 +805,7 @@ static int bm1390_setup_trigger(struct bm1390_data *data, struct iio_dev *idev,
 					&bm1390_irq_thread_handler,
 					IRQF_ONESHOT, name, idev);
 	if (ret)
-		return dev_err_probe(data->dev, ret, "Could not request IRQ\n");
+		return ret;
 
 
 	ret = devm_iio_trigger_register(data->dev, itrig);
diff --git a/drivers/iio/pressure/zpa2326.c b/drivers/iio/pressure/zpa2326.c
index 2c68fdf2744e..b38493ff3b8b 100644
--- a/drivers/iio/pressure/zpa2326.c
+++ b/drivers/iio/pressure/zpa2326.c
@@ -911,11 +911,8 @@ static int zpa2326_init_managed_irq(struct device          *parent,
 					zpa2326_handle_threaded_irq,
 					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
 					dev_name(parent), indio_dev);
-	if (err) {
-		dev_err(parent, "failed to request interrupt %d (%d)", irq,
-			err);
+	if (err)
 		return err;
-	}
 
 	dev_info(parent, "using interrupt %d", irq);
 
-- 
2.34.1


  parent reply	other threads:[~2026-07-17  9:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17  9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 23:21   ` Jonathan Cameron
2026-07-17  9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 22:05   ` Maxwell Doose
2026-07-17 23:24     ` Jonathan Cameron
2026-07-17  9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
2026-07-17 23:26   ` Jonathan Cameron
2026-07-17  9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-17  9:42 ` [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 08/13] iio: imu: " Pan Chuang
2026-07-17  9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-17  9:42 ` Pan Chuang [this message]
2026-07-17  9:42 ` [PATCH 11/13] iio: proximity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
2026-07-17  9:42 ` [PATCH 13/13] iio: temperature: " Pan Chuang
2026-07-17 10:30 ` [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717094408.509583-11-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=Achim.Gratz@Stromeko.DE \
    --cc=andy@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=dixitparmar19@gmail.com \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=i.shihao.999@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=salah.triki@gmail.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=yashsuthar983@gmail.com \
    --cc=ynorov@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox