From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"Petre Rodan" <petre.rodan@subdimension.ro>,
"Dan Robertson" <dan@dlrobertson.com>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Gustavo Silva" <gustavograzs@gmail.com>,
"Maxwell Doose" <m32285159@gmail.com>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Nishant Malpani" <nish.malpani25@gmail.com>,
"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
"Li peiyu" <579lpy@gmail.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>,
"Alex Lanzano" <lanzano.alex@gmail.com>,
"Jagath Jog J" <jagathjog1996@gmail.com>,
"Mikael Gonella-Bolduc" <m.gonella.bolduc@gmail.com>,
"Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
"Mudit Sharma" <muditsharma.info@gmail.com>,
"Kevin Tsai" <ktsai@capellamicro.com>,
"Linus Walleij" <linusw@kernel.org>,
"Anshul Dalal" <anshulusr@gmail.com>,
"Song Qiang" <songqiang1304521@gmail.com>,
"Andreas Klinger" <ak@it-klinger.de>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>, "Siratul Islam" <email@sirat.me>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Danilo Krummrich" <dakr@kernel.org>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Xichao Zhao" <zhao.xichao@vivo.com>,
"Waqar Hameed" <waqar.hameed@axis.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Marcus Folkesson" <marcus.folkesson@gmail.com>,
"Dixit Parmar" <dixitparmar19@gmail.com>,
"Miao Li" <limiao@kylinos.cn>, "Andrew Davis" <afd@ti.com>,
"Kurt Borja" <kuurtb@gmail.com>,
"Shrikant Raskar" <raskar.shree97@gmail.com>,
"Chu Guangqing" <chuguangqing@inspur.com>,
"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Felipe Khoury Dayoub" <felipedayoub@usp.br>,
"Rafael G. Dias" <rafael.guimaraes.dias@usp.br>,
"Svyatoslav Ryhel" <clamor95@gmail.com>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Salah Triki" <salah.triki@gmail.com>,
"David Carlier" <devnexen@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Yash Suthar" <yashsuthar983@gmail.com>,
"Achim Gratz" <Achim.Gratz@stromeko.de>,
"Yasin Lee" <yasin.lee.x@gmail.com>,
"open list:ANALOG DEVICES INC IIO DRIVERS" <linux@analog.com>,
"open list:ADXL355 THREE-AXIS DIGITAL ACCELEROMETER DRIVER"
<linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure
Date: Fri, 17 Jul 2026 13:30:34 +0300 [thread overview]
Message-ID: <aloESr1dVkAh784F@ashevche-desk.local> (raw)
In-Reply-To: <20260717094408.509583-1-panchuang@vivo.com>
On Fri, Jul 17, 2026 at 05:42:23PM +0800, Pan Chuang wrote:
> Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()") added automatic error logging to
> devm_request_threaded_irq() and devm_request_any_context_irq()
> via the new devm_request_result() helper, which prints device
> name, IRQ number, handler functions, and error code on failure.
>
> Since devm_request_irq() is a static inline wrapper around
> devm_request_threaded_irq(), it also benefits from this
> automatic logging.
>
> Remove the now-redundant dev_err() and dev_err_probe() calls
> in iio drivers that follow these devm_request_*_irq()
> functions, as the core now provides more detailed diagnostic
> information on failure.
Same comment as per your other series.
While at it drop all these ' != 0' and ' < 0' noise in the conditionals.
With that being done, feel free to add my
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-07-17 10:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 9:42 Pan Chuang
2026-07-17 9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 23:21 ` Jonathan Cameron
2026-07-18 6:30 ` Andy Shevchenko
2026-07-17 9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 22:05 ` Maxwell Doose
2026-07-17 23:24 ` Jonathan Cameron
2026-07-18 9:11 ` Maxwell Doose
2026-07-18 6:28 ` Andy Shevchenko
2026-07-17 9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
2026-07-17 23:26 ` Jonathan Cameron
2026-07-18 6:35 ` Andy Shevchenko
2026-07-17 9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-17 9:42 ` [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 08/13] iio: imu: " Pan Chuang
2026-07-17 9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-17 9:42 ` [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 9:42 ` [PATCH 11/13] iio: proximity: " Pan Chuang
2026-07-17 9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
2026-07-17 9:42 ` [PATCH 13/13] iio: temperature: " Pan Chuang
2026-07-17 10:30 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aloESr1dVkAh784F@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=579lpy@gmail.com \
--cc=Achim.Gratz@stromeko.de \
--cc=Michael.Hennerich@analog.com \
--cc=afd@ti.com \
--cc=ak@it-klinger.de \
--cc=andy@kernel.org \
--cc=anshulusr@gmail.com \
--cc=antoniu.miclaus@analog.com \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=chuguangqing@inspur.com \
--cc=clamor95@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=dakr@kernel.org \
--cc=dan@dlrobertson.com \
--cc=devnexen@gmail.com \
--cc=dixitparmar19@gmail.com \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=felipedayoub@usp.br \
--cc=gregkh@linuxfoundation.org \
--cc=gustavograzs@gmail.com \
--cc=i.shihao.999@gmail.com \
--cc=jagathjog1996@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=ktsai@capellamicro.com \
--cc=kuurtb@gmail.com \
--cc=lanzano.alex@gmail.com \
--cc=limiao@kylinos.cn \
--cc=linusw@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@analog.com \
--cc=lorenzo@kernel.org \
--cc=m.gonella.bolduc@gmail.com \
--cc=m32285159@gmail.com \
--cc=marcelo.schmitt@analog.com \
--cc=marcus.folkesson@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=muditsharma.info@gmail.com \
--cc=nish.malpani25@gmail.com \
--cc=nuno.sa@analog.com \
--cc=o-takashi@sakamocchi.jp \
--cc=panchuang@vivo.com \
--cc=petre.rodan@subdimension.ro \
--cc=puranjay@kernel.org \
--cc=rafael.guimaraes.dias@usp.br \
--cc=raskar.shree97@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=salah.triki@gmail.com \
--cc=songqiang1304521@gmail.com \
--cc=subhajit.ghosh@tweaklogic.com \
--cc=tduszyns@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=waqar.hameed@axis.com \
--cc=yashsuthar983@gmail.com \
--cc=yasin.lee.x@gmail.com \
--cc=zhao.xichao@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome