mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: "Nuno Sá" <nuno.sa@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Uwe Kleine-König (The Capable Hub)"
	<u.kleine-koenig@baylibre.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Pan Chuang" <panchuang@vivo.com>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	linux-iio@vger.kernel.org (open list:LTC2983 IIO TEMPERATURE
	DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 13/13] iio: temperature: Remove redundant dev_err()/dev_err_probe()
Date: Fri, 17 Jul 2026 17:42:36 +0800	[thread overview]
Message-ID: <20260717094408.509583-14-panchuang@vivo.com> (raw)
In-Reply-To: <20260717094408.509583-1-panchuang@vivo.com>

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/iio/temperature/ltc2983.c | 2 +-
 drivers/iio/temperature/tmp007.c  | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index a9d38ed45da6..6efb5252a773 100644
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -1994,7 +1994,7 @@ static int ltc2983_probe(struct spi_device *spi)
 	ret = devm_request_irq(dev, spi->irq, ltc2983_irq_handler,
 			       IRQF_TRIGGER_RISING, st->info->name, st);
 	if (ret)
-		return dev_err_probe(dev, ret, "failed to request an irq\n");
+		return ret;
 
 	if (st->info->has_eeprom) {
 		ret = ltc2983_eeprom_cmd(st, LTC2983_EEPROM_WRITE_CMD,
diff --git a/drivers/iio/temperature/tmp007.c b/drivers/iio/temperature/tmp007.c
index 2f6ff87d2a37..4e743424f88e 100644
--- a/drivers/iio/temperature/tmp007.c
+++ b/drivers/iio/temperature/tmp007.c
@@ -527,10 +527,8 @@ static int tmp007_probe(struct i2c_client *client)
 				NULL, tmp007_interrupt_handler,
 				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				tmp007_id->name, indio_dev);
-		if (ret) {
-			dev_err(&client->dev, "irq request error %d\n", -ret);
+		if (ret)
 			return ret;
-		}
 	}
 
 	return devm_iio_device_register(&client->dev, indio_dev);
-- 
2.34.1


  parent reply	other threads:[~2026-07-17  9:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  9:42 [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17  9:42 ` [PATCH 01/13] iio: accel: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 23:21   ` Jonathan Cameron
2026-07-17  9:42 ` [PATCH 02/13] iio: addac: Remove redundant dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 03/13] iio: chemical: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17 22:05   ` Maxwell Doose
2026-07-17 23:24     ` Jonathan Cameron
2026-07-17  9:42 ` [PATCH 04/13] iio: common: Remove redundant dev_err() Pan Chuang
2026-07-17 23:26   ` Jonathan Cameron
2026-07-17  9:42 ` [PATCH 05/13] iio: gyro: Remove redundant dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 06/13] iio: health: Remove redundant dev_err() Pan Chuang
2026-07-17  9:42 ` [PATCH 07/13] iio: humidity: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 08/13] iio: imu: " Pan Chuang
2026-07-17  9:42 ` [PATCH 09/13] iio: magnetometer: Remove redundant dev_err() Pan Chuang
2026-07-17  9:42 ` [PATCH 10/13] iio: pressure: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-17  9:42 ` [PATCH 11/13] iio: proximity: " Pan Chuang
2026-07-17  9:42 ` [PATCH 12/13] iio: light: " Pan Chuang
2026-07-17  9:42 ` Pan Chuang [this message]
2026-07-17 10:30 ` [PATCH 00/13] iio: Remove redundant error messages on IRQ request failure Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717094408.509583-14-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=andy@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox