* [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err()
2026-07-17 10:58 [PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-17 10:58 ` Pan Chuang
2026-07-17 10:58 ` [PATCH 2/4] pinctrl: bcm: " Pan Chuang
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Pan Chuang @ 2026-07-17 10:58 UTC (permalink / raw)
To: Lorenzo Bianconi, Linus Walleij,
moderated list:PIN CONTROLLER - AIROHA,
open list:PIN CONTROL SUBSYSTEM, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pinctrl/airoha/pinctrl-airoha.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/pinctrl/airoha/pinctrl-airoha.c b/drivers/pinctrl/airoha/pinctrl-airoha.c
index 04b4424c688b..abfb018f207e 100644
--- a/drivers/pinctrl/airoha/pinctrl-airoha.c
+++ b/drivers/pinctrl/airoha/pinctrl-airoha.c
@@ -2519,10 +2519,8 @@ static int airoha_pinctrl_add_gpiochip(struct airoha_pinctrl *pinctrl,
err = devm_request_irq(dev, irq, airoha_irq_handler, IRQF_SHARED,
dev_name(dev), pinctrl);
- if (err) {
- dev_err(dev, "error requesting irq %d: %d\n", irq, err);
+ if (err)
return err;
- }
return devm_gpiochip_add_data(dev, gc, pinctrl);
}
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/4] pinctrl: bcm: Remove redundant dev_err()
2026-07-17 10:58 [PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 10:58 ` [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err() Pan Chuang
@ 2026-07-17 10:58 ` Pan Chuang
2026-07-17 10:58 ` [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 10:58 ` [PATCH 4/4] pinctrl: Remove redundant dev_err()/dev_err_probe() Pan Chuang
3 siblings, 0 replies; 6+ messages in thread
From: Pan Chuang @ 2026-07-17 10:58 UTC (permalink / raw)
To: Ray Jui, Scott Branden, Broadcom internal kernel review list,
Linus Walleij, moderated list:BROADCOM IPROC ARM ARCHITECTURE,
open list:PIN CONTROL SUBSYSTEM, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index b425ecacd1b0..1fbb101386a3 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -671,11 +671,8 @@ static int nsp_gpio_probe(struct platform_device *pdev)
/* Install ISR for this GPIO controller. */
ret = devm_request_irq(dev, irq, nsp_gpio_irq_handler,
IRQF_SHARED, "gpio-a", &chip->gc);
- if (ret) {
- dev_err(&pdev->dev, "Unable to request IRQ%d: %d\n",
- irq, ret);
+ if (ret)
return ret;
- }
girq = &chip->gc.irq;
gpio_irq_chip_set_chip(girq, &nsp_gpio_irq_chip);
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe()
2026-07-17 10:58 [PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 10:58 ` [PATCH 1/4] pinctrl: airoha: Remove redundant dev_err() Pan Chuang
2026-07-17 10:58 ` [PATCH 2/4] pinctrl: bcm: " Pan Chuang
@ 2026-07-17 10:58 ` Pan Chuang
2026-07-17 16:58 ` Andy Shevchenko
2026-07-17 10:58 ` [PATCH 4/4] pinctrl: Remove redundant dev_err()/dev_err_probe() Pan Chuang
3 siblings, 1 reply; 6+ messages in thread
From: Pan Chuang @ 2026-07-17 10:58 UTC (permalink / raw)
To: Mika Westerberg, Andy Shevchenko, Linus Walleij,
open list:PIN CONTROL SUBSYSTEM, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 2e2526e01d58..261ec2ee63ef 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -1414,7 +1414,7 @@ static int intel_gpio_probe(struct intel_pinctrl *pctrl, int irq)
IRQF_SHARED | IRQF_NO_THREAD,
dev_name(pctrl->dev), pctrl);
if (ret)
- return dev_err_probe(pctrl->dev, ret, "failed to request interrupt\n");
+ return ret;
/* Setup IRQ chip */
girq = &pctrl->chip.irq;
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe()
2026-07-17 10:58 ` [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-17 16:58 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2026-07-17 16:58 UTC (permalink / raw)
To: Pan Chuang
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij,
open list:PIN CONTROL SUBSYSTEM, open list
On Fri, Jul 17, 2026 at 06:58:45PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err_probe() calls.
Pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/4] pinctrl: Remove redundant dev_err()/dev_err_probe()
2026-07-17 10:58 [PATCH 0/4] pinctrl: Remove redundant error messages on IRQ request failure Pan Chuang
` (2 preceding siblings ...)
2026-07-17 10:58 ` [PATCH 3/4] pinctrl: intel: Remove redundant dev_err_probe() Pan Chuang
@ 2026-07-17 10:58 ` Pan Chuang
3 siblings, 0 replies; 6+ messages in thread
From: Pan Chuang @ 2026-07-17 10:58 UTC (permalink / raw)
To: Linus Walleij, Maxime Coquelin, Alexandre Torgue,
open list:PIN CONTROL SUBSYSTEM, open list,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pinctrl/pinctrl-aw9523.c | 2 +-
drivers/pinctrl/pinctrl-mcp23s08.c | 5 +----
drivers/pinctrl/pinctrl-stmfx.c | 4 +---
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9523.c
index bc94003512cf..a13b1cdb78ea 100644
--- a/drivers/pinctrl/pinctrl-aw9523.c
+++ b/drivers/pinctrl/pinctrl-aw9523.c
@@ -817,7 +817,7 @@ static int aw9523_init_irq(struct aw9523 *awi, int irq)
ret = devm_request_threaded_irq(dev, irq, NULL, aw9523_irq_thread_func,
IRQF_ONESHOT, dev_name(dev), awi);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request irq %d\n", irq);
+ return ret;
girq = &awi->gpio.irq;
gpio_irq_chip_set_chip(girq, &aw9523_irq_chip);
diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c
index a4f0ba728c6e..cc668f84bf8b 100644
--- a/drivers/pinctrl/pinctrl-mcp23s08.c
+++ b/drivers/pinctrl/pinctrl-mcp23s08.c
@@ -559,11 +559,8 @@ static int mcp23s08_irq_setup(struct mcp23s08 *mcp)
err = devm_request_threaded_irq(chip->parent, mcp->irq, NULL,
mcp23s08_irq,
irqflags, dev_name(chip->parent), mcp);
- if (err != 0) {
- dev_err(chip->parent, "unable to request IRQ#%d: %d\n",
- mcp->irq, err);
+ if (err)
return err;
- }
return 0;
}
diff --git a/drivers/pinctrl/pinctrl-stmfx.c b/drivers/pinctrl/pinctrl-stmfx.c
index 03ee13844b50..935cace7f645 100644
--- a/drivers/pinctrl/pinctrl-stmfx.c
+++ b/drivers/pinctrl/pinctrl-stmfx.c
@@ -727,10 +727,8 @@ static int stmfx_pinctrl_probe(struct platform_device *pdev)
stmfx_pinctrl_irq_thread_fn,
IRQF_ONESHOT,
dev_name(pctl->dev), pctl);
- if (ret) {
- dev_err(pctl->dev, "cannot request irq%d\n", irq);
+ if (ret)
return ret;
- }
dev_info(pctl->dev,
"%ld GPIOs available\n", hweight_long(pctl->gpio_valid_mask));
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread