mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guangshuo Li <lgs201920130244@gmail.com>
To: Nas Chung <nas.chung@chipsnmedia.com>,
	Jackson Lee <jackson.lee@chipsnmedia.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nicolas Dufresne <nicolas.dufresne@collabora.com>,
	Hans Verkuil <hverkuil+cisco@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] media: chips-media: wave5: Handle decoder runtime resume failures
Date: Sat, 18 Jul 2026 21:00:35 +0800	[thread overview]
Message-ID: <20260718130037.3306626-1-lgs201920130244@gmail.com> (raw)

This series checks the return value from every
pm_runtime_resume_and_get() call in wave5-vpu-dec.c.

The first patch fixes the capture-buffer queue path introduced by
cbb9c0d50e47. The second patch fixes the start-streaming,
stop-streaming and device-run paths introduced by 2092b3833487.

On a runtime resume failure, the decoder must not continue accessing VPU
registers. Since pm_runtime_resume_and_get() does not retain a runtime PM
usage reference on failure, these paths must also avoid calling an
unmatched pm_runtime_put_autosuspend().

Each callback now handles the failure according to its interface by
returning or completing queued buffers, cleaning up the stop-streaming
path without touching hardware, or finishing the current mem2mem job.

v2:
  - Check all four pm_runtime_resume_and_get() call sites in
    wave5-vpu-dec.c, as suggested by Nicolas.
  - Split the changes into two patches according to the commits that
    introduced the affected calls.
  - Add callback-specific cleanup for runtime resume failures.

Guangshuo Li (2):
media: chips-media: wave5: Check decoder qbuf runtime resume
media: chips-media: wave5: Check decoder runtime resume errors

.../chips-media/wave5/wave5-vpu-dec.c         | 44 +++++++++++++++++--
1 file changed, 40 insertions(+), 4 deletions(-)

--
2.43.0

             reply	other threads:[~2026-07-18 13:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18 13:00 Guangshuo Li [this message]
2026-07-18 13:00 ` [PATCH v2 1/2] media: chips-media: wave5: Check decoder qbuf runtime resume Guangshuo Li
2026-09-28 21:10   ` Nicolas Dufresne
2026-07-18 13:00 ` [PATCH v2 2/2] media: chips-media: wave5: Check decoder runtime resume errors Guangshuo Li
2026-09-28 21:13   ` Nicolas Dufresne
2026-09-28 21:21     ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718130037.3306626-1-lgs201920130244@gmail.com \
    --to=lgs201920130244@gmail.com \
    --cc=hverkuil+cisco@kernel.org \
    --cc=jackson.lee@chipsnmedia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=nas.chung@chipsnmedia.com \
    --cc=nicolas.dufresne@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®