From: Mark Brown <broonie@kernel.org>
To: Marc Zyngier <maz@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Will Deacon <will@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
Oliver Upton <oupton@kernel.org>
Cc: Dave Martin <Dave.Martin@arm.com>, Fuad Tabba <tabba@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Ben Horgan <ben.horgan@arm.com>,
Jean-Philippe Brucker <jpb@kernel.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
Peter Maydell <peter.maydell@linaro.org>,
Eric Auger <eric.auger@redhat.com>,
Mark Brown <broonie@kernel.org>
Subject: [PATCH v13 29/32] KVM: arm64: selftests: Remove spurious check for single bit safe values
Date: Mon, 20 Jul 2026 00:07:56 +0100 [thread overview]
Message-ID: <20260720-kvm-arm64-sme-v13-29-d9abd3ffa245@kernel.org> (raw)
In-Reply-To: <20260720-kvm-arm64-sme-v13-0-d9abd3ffa245@kernel.org>
get_safe_value() currently asserts that bitfields it is generating a safe
value for must be more than one bit wide but in actual fact it should
always be possible to generate a safe value to write to a bitfield even if
it is just the current value and the function correctly handles that.
Remove the assert.
Fixes: bf09ee918053e ("KVM: arm64: selftests: Remove ARM64_FEATURE_FIELD_BITS and its last user")
Reviewed-by: Ben Horgan <ben.horgan@arm.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/kvm/arm64/set_id_regs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/kvm/arm64/set_id_regs.c b/tools/testing/selftests/kvm/arm64/set_id_regs.c
index 7429a1055df5..9eceac84e297 100644
--- a/tools/testing/selftests/kvm/arm64/set_id_regs.c
+++ b/tools/testing/selftests/kvm/arm64/set_id_regs.c
@@ -279,8 +279,6 @@ u64 get_safe_value(const struct reg_ftr_bits *ftr_bits, u64 ftr)
{
u64 ftr_max = ftr_bits->mask >> ftr_bits->shift;
- TEST_ASSERT(ftr_max > 1, "This test doesn't support single bit features");
-
if (ftr_bits->sign == FTR_UNSIGNED) {
switch (ftr_bits->type) {
case FTR_EXACT:
--
2.47.3
next prev parent reply other threads:[~2026-07-19 23:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 23:07 [PATCH v13 00/32] KVM: arm64: Implement support for SME Mark Brown
2026-07-19 23:07 ` [PATCH v13 01/32] arm64/sysreg: Define full value read/modify/write helpers Mark Brown
2026-07-19 23:07 ` [PATCH v13 02/32] arm64/fpsimd: Ensure all of ZCR_EL1 is initialised from idle Mark Brown
2026-07-23 12:58 ` Mark Rutland
2026-07-24 15:16 ` Mark Rutland
2026-07-19 23:07 ` [PATCH v13 03/32] arm64/fpsimd: Configure all ZCR/SMCR bits when loading task state Mark Brown
2026-07-19 23:07 ` [PATCH v13 04/32] arm64/fpsimd: Decide to save ZT0 and streaming mode FFR at bind time Mark Brown
2026-07-19 23:07 ` [PATCH v13 05/32] arm64/sve: Factor virtualizable VL discovery out of SVE specific code Mark Brown
2026-07-19 23:07 ` [PATCH v13 06/32] arm64/fpsimd: Determine maximum virtualisable SME vector length Mark Brown
2026-07-19 23:07 ` [PATCH v13 07/32] KVM: arm64: Remove bitrotted comment on handle_sve() Mark Brown
2026-07-19 23:07 ` [PATCH v13 08/32] KVM: arm64: Handle FEAT_IDST for guest accesses to hidden registers Mark Brown
2026-07-19 23:07 ` [PATCH v13 09/32] KVM: arm64: Pull ctxt_has_ helpers to start of sysreg-sr.h Mark Brown
2026-07-19 23:07 ` [PATCH v13 10/32] KVM: arm64: Rename SVE finalization constants to be more general Mark Brown
2026-07-19 23:07 ` [PATCH v13 11/32] KVM: arm64: Remove special case for FP state loading from ZCR_EL2 traps Mark Brown
2026-07-19 23:07 ` [PATCH v13 12/32] KVM: arm64: Define internal features for SME Mark Brown
2026-07-19 23:07 ` [PATCH v13 13/32] KVM: arm64: Rename sve_state_reg_region Mark Brown
2026-07-19 23:07 ` [PATCH v13 14/32] KVM: arm64: Store vector lengths in an array Mark Brown
2026-07-19 23:07 ` [PATCH v13 15/32] KVM: arm64: Factor SVE code out of fpsimd_lazy_switch_to_host() Mark Brown
2026-07-19 23:07 ` [PATCH v13 16/32] KVM: arm64: Document the KVM ABI for SME Mark Brown
2026-07-19 23:07 ` [PATCH v13 17/32] KVM: arm64: Implement SME vector length configuration Mark Brown
2026-07-19 23:07 ` [PATCH v13 18/32] KVM: arm64: Support SME control registers Mark Brown
2026-07-19 23:07 ` [PATCH v13 19/32] KVM: arm64: Support TPIDR2_EL0 Mark Brown
2026-07-19 23:07 ` [PATCH v13 20/32] KVM: arm64: Support SME identification registers for guests Mark Brown
2026-07-19 23:07 ` [PATCH v13 21/32] KVM: arm64: Support SME priority registers Mark Brown
2026-07-19 23:07 ` [PATCH v13 22/32] KVM: arm64: Support userspace access to streaming mode Z and P registers Mark Brown
2026-07-19 23:07 ` [PATCH v13 23/32] KVM: arm64: Flush register state on writes to SVCR.SM and SVCR.ZA Mark Brown
2026-07-19 23:07 ` [PATCH v13 24/32] KVM: arm64: Expose SME specific state to userspace Mark Brown
2026-07-19 23:07 ` [PATCH v13 25/32] KVM: arm64: Context switch SME state for guests Mark Brown
2026-07-19 23:07 ` [PATCH v13 26/32] KVM: arm64: Handle SME exceptions Mark Brown
2026-07-19 23:07 ` [PATCH v13 27/32] KVM: arm64: Expose SME to nested guests Mark Brown
2026-07-19 23:07 ` [PATCH v13 28/32] KVM: arm64: Provide interface for configuring and enabling SME for guests Mark Brown
2026-07-19 23:07 ` Mark Brown [this message]
2026-07-19 23:07 ` [PATCH v13 30/32] KVM: arm64: selftests: Skip impossible invalid value tests Mark Brown
2026-07-19 23:07 ` [PATCH v13 31/32] KVM: arm64: selftests: Add SME system registers to get-reg-list Mark Brown
2026-07-19 23:07 ` [PATCH v13 32/32] KVM: arm64: selftests: Add SME to set_id_regs test Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720-kvm-arm64-sme-v13-29-d9abd3ffa245@kernel.org \
--to=broonie@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=ben.horgan@arm.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=eric.auger@redhat.com \
--cc=joey.gouly@arm.com \
--cc=jpb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=shuah@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®