mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pradhan, Sanman" <sanman.pradhan@hpe.com>
To: "linux@roeck-us.net" <linux@roeck-us.net>
Cc: "krzk@kernel.org" <krzk@kernel.org>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sanman Pradhan <psanman@juniper.net>
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505
Date: Fri, 24 Jul 2026 16:50:22 +0000	[thread overview]
Message-ID: <20260724165008.248684-1-sanman.pradhan@hpe.com> (raw)
In-Reply-To: <668b28b1-875f-4fdd-b367-b09edef95367@roeck-us.net>

From: Sanman Pradhan <psanman@juniper.net>

On Fri, Jul 24, 2026 at 06:15:35 -0700, Guenter Roeck wrote:
> On 7/24/26 02:03, Krzysztof Kozlowski wrote:
> > On Thu, Jul 23, 2026 at 04:43:59PM +0000, Pradhan, Sanman wrote:
> > > +enum chips { max16550, vt7505 };
> >
> > You must adjust to upstream kernel style and such constants/defines are
> > UPPER CASE
>
> No, you must not. Not in the hardware monitoring subsystem, where the
> chips enumeration is and always has been traditionally lower case.

Thanks for the reviews, Krzysztof and Guenter. I've tried to address
all the comments in v3.

Regarding adi,rload-ohms: after checking the datasheet more carefully,
this does not seem to be the same as the current-path sense resistor
that shunt-resistor-micro-ohms describes. These devices use integrated
lossless current sensing the ILOAD pin sources a small reporting
current proportional to the load current (typically 5 uA/A), and RLOAD
simply converts that reporting current into a voltage for telemetry
scaling. It does not carry the load current itself. I've kept the
device-specific property and tried to clarify this distinction in the
binding description.

I've also moved additionalProperties after the allOf block and added
adi,ocp-severe-filter-us to the example. The property is still
optional, when absent, the driver leaves the existing MFR_CONFIG
setting unchanged.

In the driver, I've replaced the raw enum match values with per-device
match data for MAX16545, MAX16550, and VT7505. This avoids the
zero-valued match data concern and removes the compatible-string check
from probe. The match data now carries the temperature coefficients and
a flag indicating whether the severe OCP filter is programmable.

Thank you.

Regards,
Sanman Pradhan

      reply	other threads:[~2026-07-24 16:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 16:43 [PATCH v2 0/2] hwmon: (pmbus) Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 driver Pradhan, Sanman
2026-07-23 16:43 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 Pradhan, Sanman
2026-07-24  8:52   ` Krzysztof Kozlowski
2026-07-23 16:43 ` [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for " Pradhan, Sanman
     [not found]   ` <20260723170031.6C04A1F000E9@smtp.kernel.org>
2026-07-23 21:30     ` Pradhan, Sanman
2026-07-23 23:51       ` Guenter Roeck
2026-07-24  9:03   ` Krzysztof Kozlowski
2026-07-24 13:15     ` Guenter Roeck
2026-07-24 16:50       ` Pradhan, Sanman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724165008.248684-1-sanman.pradhan@hpe.com \
    --to=sanman.pradhan@hpe.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=psanman@juniper.net \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®