mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"Pradhan, Sanman" <sanman.pradhan@hpe.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Sanman Pradhan <psanman@juniper.net>,
	Georgi Vlaev <gvlaev@juniper.net>,
	Dhruva Devineni <ddevineni@juniper.net>,
	Debjit Ghosh <dghosh@juniper.net>,
	Jawahar Balaji Thirumalaisamy <jawaharb@juniper.net>,
	Avadhut Naik <avadhutn@juniper.net>,
	Santhanakrishnan Balraj <sbalraj@juniper.net>,
	Brian Mak <makb@juniper.net>
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505
Date: Fri, 24 Jul 2026 06:15:35 -0700	[thread overview]
Message-ID: <668b28b1-875f-4fdd-b367-b09edef95367@roeck-us.net> (raw)
In-Reply-To: <20260724-skink-of-unmistakable-novelty-d97d95@quoll>

On 7/24/26 02:03, Krzysztof Kozlowski wrote:
> On Thu, Jul 23, 2026 at 04:43:59PM +0000, Pradhan, Sanman wrote:
>> diff --git a/drivers/hwmon/pmbus/Makefile b/drivers/hwmon/pmbus/Makefile
>> index 080d366809f3..daa4b49bc90f 100644
>> --- a/drivers/hwmon/pmbus/Makefile
>> +++ b/drivers/hwmon/pmbus/Makefile
>> @@ -75,6 +75,7 @@ obj-$(CONFIG_SENSORS_TPS53679)	+= tps53679.o
>>   obj-$(CONFIG_SENSORS_TPS546D24)	+= tps546d24.o
>>   obj-$(CONFIG_SENSORS_UCD9000)	+= ucd9000.o
>>   obj-$(CONFIG_SENSORS_UCD9200)	+= ucd9200.o
>> +obj-$(CONFIG_SENSORS_VT7505)	+= vt7505.o
>>   obj-$(CONFIG_SENSORS_XDP710)	+= xdp710.o
>>   obj-$(CONFIG_SENSORS_XDP720)	+= xdp720.o
>>   obj-$(CONFIG_SENSORS_XDPE122)	+= xdpe12284.o
>> diff --git a/drivers/hwmon/pmbus/vt7505.c b/drivers/hwmon/pmbus/vt7505.c
>> new file mode 100644
>> index 000000000000..a96abf75b1aa
>> --- /dev/null
>> +++ b/drivers/hwmon/pmbus/vt7505.c
>> @@ -0,0 +1,274 @@
>> +// SPDX-License-Identifier: GPL-2.0-or-later
>> +/*
>> + * Hardware monitoring driver for Analog Devices MAX16545/MAX16550 and
>> + * Volterra VT7505 PMBus controllers.
>> + *
>> + * SPDX-FileCopyrightText: Copyright Hewlett Packard Enterprise Development LP
> 
> Tag is accepted but discouraged. Use standard copyright header.
> 
> ...
> 
> 
>> +#define VT7505_MFR_PEAK_VIN		0xd1
>> +#define VT7505_MFR_PEAK_IOUT		0xd2
>> +#define VT7505_MFR_PEAK_PIN		0xd3
>> +#define VT7505_MFR_PEAK_TEMP		0xd4
>> +#define VT7505_MFR_CLEAR_PEAKS		0xd5
>> +#define VT7505_MFR_PEAK_VOUT		0xfd
>> +
>> +#define VT7505_RLOAD_DEFAULT		4750
>> +
>> +enum chips { max16550, vt7505 };
> 
> You must adjust to upstream kernel style and such constants/defines are

No, you must not.

> UPPER CASE (I know there are antipatterns in existing drivers, though).
> 

Not in the hardware monitoring subsystem, where the chips enumeration is
and always has been traditionally lower case.

Guenter


  reply	other threads:[~2026-07-24 13:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 16:43 [PATCH v2 0/2] hwmon: (pmbus) Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 driver Pradhan, Sanman
2026-07-23 16:43 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 Pradhan, Sanman
2026-07-24  8:52   ` Krzysztof Kozlowski
2026-07-23 16:43 ` [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for " Pradhan, Sanman
     [not found]   ` <20260723170031.6C04A1F000E9@smtp.kernel.org>
2026-07-23 21:30     ` Pradhan, Sanman
2026-07-23 23:51       ` Guenter Roeck
2026-07-24  9:03   ` Krzysztof Kozlowski
2026-07-24 13:15     ` Guenter Roeck [this message]
2026-07-24 16:50       ` Pradhan, Sanman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=668b28b1-875f-4fdd-b367-b09edef95367@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=avadhutn@juniper.net \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=ddevineni@juniper.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dghosh@juniper.net \
    --cc=gvlaev@juniper.net \
    --cc=jawaharb@juniper.net \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=makb@juniper.net \
    --cc=psanman@juniper.net \
    --cc=robh@kernel.org \
    --cc=sanman.pradhan@hpe.com \
    --cc=sbalraj@juniper.net \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®