From: Guenter Roeck <linux@roeck-us.net>
To: "Pradhan, Sanman" <sanman.pradhan@hpe.com>,
"sashiko-reviews@lists.linux.dev"
<sashiko-reviews@lists.linux.dev>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sanman Pradhan <psanman@juniper.net>
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for Analog Devices MAX16545/MAX16550 and Volterra VT7505
Date: Thu, 23 Jul 2026 16:51:03 -0700 [thread overview]
Message-ID: <f691a121-3604-4db1-b3e5-3be27cbfbb2a@roeck-us.net> (raw)
In-Reply-To: <20260723213009.220862-1-sanman.pradhan@hpe.com>
On 7/23/26 14:30, Pradhan, Sanman wrote:
> From: Sanman Pradhan <psanman@juniper.net>
>
> On Thu, Jul 23, 2026 at 17:00:21 +0000, sashiko-bot@kernel.org wrote:
>>> +static const struct i2c_device_id vt7505_id[] = {
>>> + { "max16545", vt7505 },
>>> + { "max16550", max16550 },
>>> + { "vt7505", vt7505 },
>>> + { }
>>> +};
>>
>> [Severity: Low]
>> Could these array entries be updated to use named (designated) initializers?
>> The I2C subsystem guidelines recommend using named initializers for arrays of
>> type struct i2c_device_id to maintain uniformity and prevent field
>> misalignment.
>
> Thanks for the suggestion. I think the current initialization is valid
> across existing drivers for i2c_device_id.
>
No, it isn't acceptable anymore. Existing drivers are all in the process
of being converted.
Guenter
next prev parent reply other threads:[~2026-07-23 23:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 16:43 [PATCH v2 0/2] hwmon: (pmbus) Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 driver Pradhan, Sanman
2026-07-23 16:43 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: Add Analog Devices MAX16545/MAX16550 and Volterra VT7505 Pradhan, Sanman
2026-07-24 8:52 ` Krzysztof Kozlowski
2026-07-23 16:43 ` [PATCH v2 2/2] hwmon: (pmbus/vt7505) Add driver for " Pradhan, Sanman
[not found] ` <20260723170031.6C04A1F000E9@smtp.kernel.org>
2026-07-23 21:30 ` Pradhan, Sanman
2026-07-23 23:51 ` Guenter Roeck [this message]
2026-07-24 9:03 ` Krzysztof Kozlowski
2026-07-24 13:15 ` Guenter Roeck
2026-07-24 16:50 ` Pradhan, Sanman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f691a121-3604-4db1-b3e5-3be27cbfbb2a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=psanman@juniper.net \
--cc=robh@kernel.org \
--cc=sanman.pradhan@hpe.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®