* [PATCH] sched/fair: Remove unused autogroup.h include
@ 2026-07-26 16:02 Kayra Cizmeci
2026-08-31 19:22 ` Kayra Cizmeci
0 siblings, 1 reply; 3+ messages in thread
From: Kayra Cizmeci @ 2026-07-26 16:02 UTC (permalink / raw)
To: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, K Prateek Nayak, linux-kernel
Cc: Kayra Cizmeci
autogroup.h is included in fair.c but nothing in fair.c uses
anything it declares.
Signed-off-by: Kayra Cizmeci <kayracizmeci@gmail.com>
---
Hello, I've done some confirmations, firstly I grepped autogroup and
only place it appears is the include. Because of everything in autogroup.h
that can be used has autogroup string in them (Sorry if I've missed something)
autogroup.h is not used in fair.c. I also made a boot test using Lima and above
that QEMU, in x86_64 defconfig, 4 CPUs, busybox.
kernel/sched/fair.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d78467ec6ee1..666ee3643b73 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -56,7 +56,6 @@
#include "sched.h"
#include "stats.h"
-#include "autogroup.h"
/*
* The initial- and re-scaling of tunables is configurable
base-commit: 3dab139d4795f688e4f243e40c7474df00d329d9
--
2.53.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sched/fair: Remove unused autogroup.h include
2026-07-26 16:02 [PATCH] sched/fair: Remove unused autogroup.h include Kayra Cizmeci
@ 2026-08-31 19:22 ` Kayra Cizmeci
0 siblings, 0 replies; 3+ messages in thread
From: Kayra Cizmeci @ 2026-08-31 19:22 UTC (permalink / raw)
To: kayracizmeci
Cc: bsegall, dietmar.eggemann, juri.lelli, kprateek.nayak,
linux-kernel, mgorman, mingo, peterz, rostedt, vincent.guittot,
vschneid
Gentle ping on this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] sched/fair: reuse the ENQUEUE_DELAYED calculation in enqueue_task_fair()
@ 2026-08-26 10:41 K Prateek Nayak
2026-09-07 16:05 ` [PATCH] sched/fair: Remove unused autogroup.h include Kayra Cizmeci
0 siblings, 1 reply; 3+ messages in thread
From: K Prateek Nayak @ 2026-08-26 10:41 UTC (permalink / raw)
To: Kayra Cizmeci, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Valentin Schneider
Cc: linux-kernel
On 8/26/2026 3:45 PM, Kayra Cizmeci wrote:
> @@ -7996,12 +7996,12 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
> * Let's add the task's estimated utilization to the cfs_rq's
> * estimated utilization, before we update schedutil.
> */
> - if (!p->se.sched_delayed || (flags & ENQUEUE_DELAYED))
> + if (!p->se.sched_delayed || delayed)
nit. This reads funny now - not delayed or delayed?
Maybe wakeup_delayed but all of this should be optimized by compiler
at the end and a big ENQUEUE_DELAYED is better for humans who are
reading the code no?
> util_est_enqueue(cfs_rq, p);
>
> update_curr_eevdf(cfs_rq);
>
> - if (flags & ENQUEUE_DELAYED) {
> + if (delayed) {
> requeue_delayed_entity(cfs_rq, se);
> return;
> }
--
Thanks and Regards,
Prateek
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] sched/fair: Remove unused autogroup.h include
2026-08-26 10:41 [PATCH v2 1/2] sched/fair: reuse the ENQUEUE_DELAYED calculation in enqueue_task_fair() K Prateek Nayak
@ 2026-09-07 16:05 ` Kayra Cizmeci
0 siblings, 0 replies; 3+ messages in thread
From: Kayra Cizmeci @ 2026-09-07 16:05 UTC (permalink / raw)
To: kprateek.nayak
Cc: bsegall, dietmar.eggemann, juri.lelli, kayracizmeci,
linux-kernel, mgorman, mingo, peterz, rostedt, vincent.guittot,
vschneid
Gentle ping on this patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-07 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-26 16:02 [PATCH] sched/fair: Remove unused autogroup.h include Kayra Cizmeci
2026-08-31 19:22 ` Kayra Cizmeci
2026-08-26 10:41 [PATCH v2 1/2] sched/fair: reuse the ENQUEUE_DELAYED calculation in enqueue_task_fair() K Prateek Nayak
2026-09-07 16:05 ` [PATCH] sched/fair: Remove unused autogroup.h include Kayra Cizmeci
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®