mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yazen Ghannam <yazen.ghannam@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Lin Wang <wanglin@open-hieco.net>,
	mario.limonciello@amd.com, tglx@kernel.org, mingo@redhat.com,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] x86/hygon: Add Family 0x18 DF node enumeration and SMN access
Date: Mon, 27 Jul 2026 18:08:54 -0400	[thread overview]
Message-ID: <20260727220854.GA941383@yaz-khff2.amd.com> (raw)
In-Reply-To: <20260722195913.GEamEhEWeBNt65mHmy@fat_crate.local>

On Wed, Jul 22, 2026 at 12:59:13PM -0700, Borislav Petkov wrote:
> On Thu, Jul 09, 2026 at 03:55:43PM +0800, Lin Wang wrote:
> > Hygon Family 0x18 systems expose Data Fabric (DF) devices in a layout
> > that cannot be handled by the AMD fixed-slot node model.
> 
> A bunch of issues Sashiko caught which need addressing:
> 
> https://sashiko.dev/#/patchset/20260709075549.626095-1-wanglin%40open-hieco.net
> 
> @Yazen, there are some preexisting ones in the SMN code that would need
> addressing/commenting too.
> 

There are a couple of preexisting issues.

1) Use-After-Free

This looks like a long-time gap that doesn't happen in practice. The
"devices" are the internal root ports. They don't get added/removed,
since they're built into the chip. And the amd_node code is built-in
too.

In any case, I'll work on a patch for this.

2) Divide-by-Zero

This one has come up a few times recently. Latest two threads:

https://lore.kernel.org/20260506055528.476493-1-penny.zheng@amd.com/
https://lore.kernel.org/20260623211904.3674-1-jason.andryuk@amd.com/

Thanks,
Yazen

      parent reply	other threads:[~2026-07-27 22:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  7:55 Lin Wang
2026-07-09  7:55 ` [PATCH v3 1/6] pci_ids: Add Hygon Family 0x18 DF F3/F4 device IDs Lin Wang
2026-07-09  7:55 ` [PATCH v3 2/6] x86/amd_nb: Restrict NB framework init to AMD vendor Lin Wang
2026-07-14 13:10   ` Yazen Ghannam
2026-07-09  7:55 ` [PATCH v3 3/6] x86/amd_node: Restrict SMN root enumeration " Lin Wang
2026-07-09  7:55 ` [PATCH v3 4/6] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-07-19 20:36   ` Yazen Ghannam
2026-07-20  1:56     ` Lin Wang
2026-07-09  7:55 ` [PATCH v3 5/6] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-07-09  7:55 ` [PATCH v3 6/6] x86/hygon: Add SMN debugfs interface Lin Wang
2026-07-22 19:59 ` [PATCH v3 0/6] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Borislav Petkov
2026-07-23  8:33   ` Lin Wang
2026-07-26  5:14     ` Borislav Petkov
2026-07-27  2:25       ` Lin Wang
2026-07-27 22:08   ` Yazen Ghannam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727220854.GA941383@yaz-khff2.amd.com \
    --to=yazen.ghannam@amd.com \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=wanglin@open-hieco.net \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®