mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] platform/x86: asus-armoury: add support for FX517ZR
@ 2026-07-29 11:09 AbdElRahman Soliman
  2026-08-16 14:48 ` Denis Benato
  0 siblings, 1 reply; 2+ messages in thread
From: AbdElRahman Soliman @ 2026-07-29 11:09 UTC (permalink / raw)
  To: hansg, ilpo.jarvinen
  Cc: platform-driver-x86, linux-kernel, AbdElRahman Soliman

Add DMI match and power-limit table entry for the ASUS TUF Dash F15
(2022), board FX517ZR, an Alder Lake + RTX 3070 laptop.

AC and DC min/max values for ppt_pl1_spl, ppt_pl2_sppt,
nv_dynamic_boost and nv_temp_target were read from the sliders in
ASUS Armoury Crate's manual performance-tuning mode on Windows for
this exact model, since ASUS does not publish these limits on the Web.

Tested locally: values now report correctly via 'asusctl armoury
list' instead of unavailable, and Dynamic Boost via nvidia-powerd
measurably raises GPU power limit under load, consistent with the
80W base + 25W boost = 105W max TGP in ASUS's own spec sheet for
this configuration.

Assisted-by: Claude:claude-sonnet-5

Signed-off-by: AbdElRahman Soliman <abdelrahman7987@gmail.com>
---
 drivers/platform/x86/asus-armoury.h | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
index bc899bec7..46c308ba8 100644
--- a/drivers/platform/x86/asus-armoury.h
+++ b/drivers/platform/x86/asus-armoury.h
@@ -975,6 +975,32 @@ static const struct dmi_system_id power_limits[] = {
 			.requires_fan_curve = true,
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_NAME, "FX517ZR"),
+		},
+		.driver_data = &(struct power_data) {
+			.ac_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 28,
+				.ppt_pl1_spl_max = 85,
+				.ppt_pl2_sppt_min = 28,
+				.ppt_pl2_sppt_max = 135,
+				.nv_dynamic_boost_min = 5,
+				.nv_dynamic_boost_max = 25,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.dc_data = &(struct power_limits) {
+				.ppt_pl1_spl_min = 25,
+				.ppt_pl1_spl_max = 45,
+				.ppt_pl2_sppt_min = 35,
+				.ppt_pl2_sppt_max = 60,
+				.nv_temp_target_min = 75,
+				.nv_temp_target_max = 87,
+			},
+			.requires_fan_curve = true,
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_NAME, "FX607VU"),
-- 
2.55.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] platform/x86: asus-armoury: add support for FX517ZR
  2026-07-29 11:09 [PATCH] platform/x86: asus-armoury: add support for FX517ZR AbdElRahman Soliman
@ 2026-08-16 14:48 ` Denis Benato
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Benato @ 2026-08-16 14:48 UTC (permalink / raw)
  To: AbdElRahman Soliman, hansg, ilpo.jarvinen
  Cc: platform-driver-x86, linux-kernel


On 7/29/26 13:09, AbdElRahman Soliman wrote:
> Add DMI match and power-limit table entry for the ASUS TUF Dash F15
> (2022), board FX517ZR, an Alder Lake + RTX 3070 laptop.
>
> AC and DC min/max values for ppt_pl1_spl, ppt_pl2_sppt,
> nv_dynamic_boost and nv_temp_target were read from the sliders in
> ASUS Armoury Crate's manual performance-tuning mode on Windows for
> this exact model, since ASUS does not publish these limits on the Web.
>
> Tested locally: values now report correctly via 'asusctl armoury
> list' instead of unavailable, and Dynamic Boost via nvidia-powerd
> measurably raises GPU power limit under load, consistent with the
> 80W base + 25W boost = 105W max TGP in ASUS's own spec sheet for
> this configuration.
>
> Assisted-by: Claude:claude-sonnet-5
Hi,

Thanks for this.

I would say remove the "Tested locally" paragraph: guidelines says
that commit messages are to be written in the second person as if
you were telling git what to do.

Also I personally never used a commit message so long and
a shorter one will be absolutely be fine too.

Next revision use the -v2 flag and don't forget to email me too.

If you need further help just tell me, thanks!
> Signed-off-by: AbdElRahman Soliman <abdelrahman7987@gmail.com>
> ---
>  drivers/platform/x86/asus-armoury.h | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index bc899bec7..46c308ba8 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -975,6 +975,32 @@ static const struct dmi_system_id power_limits[] = {
>  			.requires_fan_curve = true,
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "FX517ZR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 28,
> +				.ppt_pl1_spl_max = 85,
> +				.ppt_pl2_sppt_min = 28,
> +				.ppt_pl2_sppt_max = 135,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 25,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 25,
> +				.ppt_pl1_spl_max = 45,
> +				.ppt_pl2_sppt_min = 35,
> +				.ppt_pl2_sppt_max = 60,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "FX607VU"),

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-16 14:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-29 11:09 [PATCH] platform/x86: asus-armoury: add support for FX517ZR AbdElRahman Soliman
2026-08-16 14:48 ` Denis Benato

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®