From: David Laight <david.laight.linux@gmail.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: "Borislav Betkov" <bp@alien8.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Thomas Gleinxer" <tglx@linutronix.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
rodrigo.alencar@analog.com, jic23@kernel.org
Subject: Re: [PATCH 0/2] x86: Use "er" asm constriant for add/sub
Date: Mon, 3 Aug 2026 16:39:55 +0100 [thread overview]
Message-ID: <20260803163955.627bdd3f@pumpkin> (raw)
In-Reply-To: <11o7545n-7569-3p9r-1q77-8nor8513r6n1@syhkavp.arg>
On Mon, 3 Aug 2026 10:49:40 -0400 (EDT)
Nicolas Pitre <nico@fluxnic.net> wrote:
> On Mon, 3 Aug 2026, David Laight wrote:
>
> > The x86 instruction set only supports 32bit signed immediate values
> > for add/sub.
> > Replace the "ir" constraint with "er" to avoid build errors.
> >
> > Found by a patch that added used mul_u64_add_u64_div_u64() to
> > do a rounding divide by 2^32 (perhaps not the best way to do this).
> >
> > A quick grep only found one other affected file.
>
> Would be a good idea adding those cases to the test module.
They fail to compile so it isn't a big deal.
David
>
>
> Nicolas
next prev parent reply other threads:[~2026-08-03 15:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 9:47 David Laight
2026-08-03 9:47 ` [PATCH 1/2] lib: mul_u64_add_u64_div_u64: Fix addition of large constants David Laight
2026-08-03 10:08 ` H. Peter Anvin
2026-09-10 18:00 ` [tip: x86/urgent] x86/div64: Fix addition of large constants in mul_u64_add_u64_div_u64() tip-bot2 for David Laight
2026-08-03 9:47 ` [PATCH 2/2] x86/local: local_add/local_sub: Support large immediate values David Laight
2026-08-03 10:01 ` Peter Zijlstra
2026-08-03 10:07 ` H. Peter Anvin
2026-09-23 20:25 ` [tip: x86/asm] x86/local: Support large immediate values in local_(add|sub)() tip-bot2 for David Laight
2026-08-03 9:59 ` [PATCH 0/2] x86: Use "er" asm constriant for add/sub Peter Zijlstra
2026-08-03 14:49 ` Nicolas Pitre
2026-08-03 15:39 ` David Laight [this message]
2026-08-23 22:35 ` Jonathan Cameron
2026-09-01 16:51 ` Jonathan Cameron
2026-09-07 22:14 ` Jonathan Cameron
2026-09-08 3:32 ` Borislav Petkov
2026-09-08 10:02 ` Uwe Kleine-König
2026-09-08 15:21 ` Borislav Petkov
2026-09-08 15:49 ` Uwe Kleine-König
2026-09-08 16:55 ` Borislav Petkov
2026-09-10 3:20 ` Jonathan Cameron
2026-09-10 3:45 ` Borislav Petkov
2026-09-10 16:09 ` Jonathan Cameron
2026-09-10 18:00 ` Borislav Petkov
2026-09-13 23:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260803163955.627bdd3f@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jic23@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nico@fluxnic.net \
--cc=peterz@infradead.org \
--cc=rodrigo.alencar@analog.com \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®