mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] usb: core: handle port status errors in disable_show()
@ 2026-08-08 13:16 Karl Mehltretter
  2026-08-08 13:44 ` Alan Stern
  0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-08-08 13:16 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Karl Mehltretter, Alan Stern, Michael Grzeschik, linux-usb, linux-kernel

usb_hub_port_status() leaves its output arguments untouched when the
status request fails. disable_show() nevertheless uses portstatus, so a
sysfs read may report the wrong port state instead of an error.

Propagate the status request error.

Fixes: f061f43d7418c ("usb: hub: port: add sysfs entry to switch port power")
Assisted-by: Claude:claude-fable-5
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 drivers/usb/core/port.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
index b4452b665f591..0022473e526d7 100644
--- a/drivers/usb/core/port.c
+++ b/drivers/usb/core/port.c
@@ -96,7 +96,9 @@ static ssize_t disable_show(struct device *dev,
 		goto out_hdev_lock;
 	}
 
-	usb_hub_port_status(hub, port1, &portstatus, &unused);
+	rc = usb_hub_port_status(hub, port1, &portstatus, &unused);
+	if (rc < 0)
+		goto out_hdev_lock;
 	disabled = !usb_port_is_power_on(hub, portstatus);
 
  out_hdev_lock:
-- 
2.53.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: core: handle port status errors in disable_show()
  2026-08-08 13:16 [PATCH] usb: core: handle port status errors in disable_show() Karl Mehltretter
@ 2026-08-08 13:44 ` Alan Stern
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2026-08-08 13:44 UTC (permalink / raw)
  To: Karl Mehltretter
  Cc: Greg Kroah-Hartman, Michael Grzeschik, linux-usb, linux-kernel

On Sat, Aug 08, 2026 at 03:16:01PM +0200, Karl Mehltretter wrote:
> usb_hub_port_status() leaves its output arguments untouched when the
> status request fails. disable_show() nevertheless uses portstatus, so a
> sysfs read may report the wrong port state instead of an error.
> 
> Propagate the status request error.
> 
> Fixes: f061f43d7418c ("usb: hub: port: add sysfs entry to switch port power")
> Assisted-by: Claude:claude-fable-5
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  drivers/usb/core/port.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
> index b4452b665f591..0022473e526d7 100644
> --- a/drivers/usb/core/port.c
> +++ b/drivers/usb/core/port.c
> @@ -96,7 +96,9 @@ static ssize_t disable_show(struct device *dev,
>  		goto out_hdev_lock;
>  	}
>  
> -	usb_hub_port_status(hub, port1, &portstatus, &unused);
> +	rc = usb_hub_port_status(hub, port1, &portstatus, &unused);
> +	if (rc < 0)
> +		goto out_hdev_lock;
>  	disabled = !usb_port_is_power_on(hub, portstatus);
>  
>   out_hdev_lock:

It would be cleaner and simpler to do:

	if (rc >= 0)
		disabled = !usb_port_is_power_on(hub, portstatus);

Alan Stern

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-08 13:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-08 13:16 [PATCH] usb: core: handle port status errors in disable_show() Karl Mehltretter
2026-08-08 13:44 ` Alan Stern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®