* [PATCH] virtio_pci_modern: replace msleep(1) with usleep_range(1000, 2000)
@ 2026-08-16 9:43 Mirza Ishan Beg
2026-08-16 21:38 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Mirza Ishan Beg @ 2026-08-16 9:43 UTC (permalink / raw)
To: virtualization
Cc: linux-kernel, Michael S . Tsirkin, Jason Wang, Xuan Zhuo,
Eugenio Pérez, Mirza Ishan Beg
Replace msleep(1) with usleep_range(1000, 2000) in the queue reset
loops.
msleep(1) relies on jiffies and can sleep up to 4-10 ms depending on HZ,
whereas usleep_range provides predictable microsecond-level delay.
Signed-off-by: Mirza Ishan Beg <seedandsyntax@gmail.com>
---
drivers/virtio/virtio_pci_modern_dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c
index 413a8c353463..8e74a813ca97 100644
--- a/drivers/virtio/virtio_pci_modern_dev.c
+++ b/drivers/virtio/virtio_pci_modern_dev.c
@@ -535,10 +535,10 @@ void vp_modern_set_queue_reset(struct virtio_pci_modern_device *mdev, u16 index)
vp_iowrite16(1, &cfg->queue_reset);
while (vp_ioread16(&cfg->queue_reset))
- msleep(1);
+ usleep_range(1000, 2000);
while (vp_ioread16(&cfg->cfg.queue_enable))
- msleep(1);
+ usleep_range(1000, 2000);
}
EXPORT_SYMBOL_GPL(vp_modern_set_queue_reset);
--
2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] virtio_pci_modern: replace msleep(1) with usleep_range(1000, 2000)
2026-08-16 9:43 [PATCH] virtio_pci_modern: replace msleep(1) with usleep_range(1000, 2000) Mirza Ishan Beg
@ 2026-08-16 21:38 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2026-08-16 21:38 UTC (permalink / raw)
To: Mirza Ishan Beg
Cc: virtualization, linux-kernel, Jason Wang, Xuan Zhuo, Eugenio Pérez
On Sun, Aug 16, 2026 at 03:13:19PM +0530, Mirza Ishan Beg wrote:
> Replace msleep(1) with usleep_range(1000, 2000) in the queue reset
> loops.
> msleep(1) relies on jiffies and can sleep up to 4-10 ms depending on HZ,
> whereas usleep_range provides predictable microsecond-level delay.
>
> Signed-off-by: Mirza Ishan Beg <seedandsyntax@gmail.com>
why do we care?
> ---
> drivers/virtio/virtio_pci_modern_dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci_modern_dev.c b/drivers/virtio/virtio_pci_modern_dev.c
> index 413a8c353463..8e74a813ca97 100644
> --- a/drivers/virtio/virtio_pci_modern_dev.c
> +++ b/drivers/virtio/virtio_pci_modern_dev.c
> @@ -535,10 +535,10 @@ void vp_modern_set_queue_reset(struct virtio_pci_modern_device *mdev, u16 index)
> vp_iowrite16(1, &cfg->queue_reset);
>
> while (vp_ioread16(&cfg->queue_reset))
> - msleep(1);
> + usleep_range(1000, 2000);
>
> while (vp_ioread16(&cfg->cfg.queue_enable))
> - msleep(1);
> + usleep_range(1000, 2000);
> }
> EXPORT_SYMBOL_GPL(vp_modern_set_queue_reset);
>
> --
> 2.47.3
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-16 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-16 9:43 [PATCH] virtio_pci_modern: replace msleep(1) with usleep_range(1000, 2000) Mirza Ishan Beg
2026-08-16 21:38 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®