* [PATCH net] net: fec: only stop PTP if it was initialized
@ 2026-08-24 10:08 phucduc.bui
2026-08-24 14:57 ` Frank Li
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: phucduc.bui @ 2026-08-24 10:08 UTC (permalink / raw)
To: Wei Fang, Frank Li, Shenwei Wang
Cc: Andrew Lunn, davem, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, imx, linux-kernel, netdev, bui duc phuc
From: bui duc phuc <phucduc.bui@gmail.com>
fec_ptp_init() is only called when fep->bufdesc_ex is available.
However, fec_probe() unconditionally calls fec_ptp_stop() on the
failed_init path.
Check fep->bufdesc_ex before calling fec_ptp_stop() to avoid stopping
PTP when it was not initialized.
Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
drivers/net/ethernet/freescale/fec_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index ced4dbf8cd90..7a87f40d12d9 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -5457,7 +5457,8 @@ fec_probe(struct platform_device *pdev)
failed_irq:
fec_enet_deinit(ndev);
failed_init:
- fec_ptp_stop(pdev);
+ if (fep->bufdesc_ex)
+ fec_ptp_stop(pdev);
failed_reset:
pm_runtime_put_noidle(&pdev->dev);
pm_runtime_disable(&pdev->dev);
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] net: fec: only stop PTP if it was initialized
2026-08-24 10:08 [PATCH net] net: fec: only stop PTP if it was initialized phucduc.bui
@ 2026-08-24 14:57 ` Frank Li
2026-08-25 2:03 ` Wei Fang
2026-08-25 2:06 ` Wei Fang
2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-08-24 14:57 UTC (permalink / raw)
To: phucduc.bui
Cc: Wei Fang, Frank Li, Shenwei Wang, Andrew Lunn, davem,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Richard Cochran, imx,
linux-kernel, netdev
On Mon, Aug 24, 2026 at 05:08:34PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> fec_ptp_init() is only called when fep->bufdesc_ex is available.
> However, fec_probe() unconditionally calls fec_ptp_stop() on the
> failed_init path.
>
> Check fep->bufdesc_ex before calling fec_ptp_stop() to avoid stopping
> PTP when it was not initialized.
>
> Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail path")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/net/ethernet/freescale/fec_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index ced4dbf8cd90..7a87f40d12d9 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -5457,7 +5457,8 @@ fec_probe(struct platform_device *pdev)
> failed_irq:
> fec_enet_deinit(ndev);
> failed_init:
> - fec_ptp_stop(pdev);
> + if (fep->bufdesc_ex)
> + fec_ptp_stop(pdev);
> failed_reset:
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net] net: fec: only stop PTP if it was initialized
2026-08-24 10:08 [PATCH net] net: fec: only stop PTP if it was initialized phucduc.bui
2026-08-24 14:57 ` Frank Li
@ 2026-08-25 2:03 ` Wei Fang
2026-08-25 2:06 ` Wei Fang
2 siblings, 0 replies; 4+ messages in thread
From: Wei Fang @ 2026-08-25 2:03 UTC (permalink / raw)
To: phucduc.bui, Frank Li, Shenwei Wang
Cc: Andrew Lunn, davem, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, imx, linux-kernel, netdev
> fec_ptp_init() is only called when fep->bufdesc_ex is available.
> However, fec_probe() unconditionally calls fec_ptp_stop() on the failed_init
> path.
>
> Check fep->bufdesc_ex before calling fec_ptp_stop() to avoid stopping PTP when
> it was not initialized.
>
> Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail
> path")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index ced4dbf8cd90..7a87f40d12d9 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -5457,7 +5457,8 @@ fec_probe(struct platform_device *pdev)
> failed_irq:
> fec_enet_deinit(ndev);
> failed_init:
> - fec_ptp_stop(pdev);
> + if (fep->bufdesc_ex)
> + fec_ptp_stop(pdev);
> failed_reset:
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> --
> 2.43.0
Thanks for fixing this issue.
Reviewed-by: Wei Fang <wei.fang@nxp.com>
NXP Confidential
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH net] net: fec: only stop PTP if it was initialized
2026-08-24 10:08 [PATCH net] net: fec: only stop PTP if it was initialized phucduc.bui
2026-08-24 14:57 ` Frank Li
2026-08-25 2:03 ` Wei Fang
@ 2026-08-25 2:06 ` Wei Fang
2 siblings, 0 replies; 4+ messages in thread
From: Wei Fang @ 2026-08-25 2:06 UTC (permalink / raw)
To: phucduc.bui, Frank Li, Shenwei Wang
Cc: Andrew Lunn, davem, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran, imx, linux-kernel, netdev
Sorry for replying this thread with same content, just to remove the
"NXP Confidential" label. Sorry for the noise.
> fec_ptp_init() is only called when fep->bufdesc_ex is available.
> However, fec_probe() unconditionally calls fec_ptp_stop() on the failed_init
> path.
>
> Check fep->bufdesc_ex before calling fec_ptp_stop() to avoid stopping PTP when
> it was not initialized.
>
> Fixes: 32cba57ba74b ("net: fec: introduce fec_ptp_stop and use in probe fail
> path")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index ced4dbf8cd90..7a87f40d12d9 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -5457,7 +5457,8 @@ fec_probe(struct platform_device *pdev)
> failed_irq:
> fec_enet_deinit(ndev);
> failed_init:
> - fec_ptp_stop(pdev);
> + if (fep->bufdesc_ex)
> + fec_ptp_stop(pdev);
> failed_reset:
> pm_runtime_put_noidle(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> --
> 2.43.0
Thanks for fixing this issue.
Reviewed-by: Wei Fang <wei.fang@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-25 2:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-24 10:08 [PATCH net] net: fec: only stop PTP if it was initialized phucduc.bui
2026-08-24 14:57 ` Frank Li
2026-08-25 2:03 ` Wei Fang
2026-08-25 2:06 ` Wei Fang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®