mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2)
  2026-09-02 16:04 [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2) Catherine L
@ 2026-09-02 11:07 ` Paul Menzel
  2026-09-02 13:24   ` L, Catherine
  2026-09-02 15:17   ` Luiz Augusto von Dentz
  0 siblings, 2 replies; 4+ messages in thread
From: Paul Menzel @ 2026-09-02 11:07 UTC (permalink / raw)
  To: Catherine L; +Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel, kiran.k, L

Dear Catherine,


Thank you for your patch.

Am 02.09.26 um 18:04 schrieb Catherine L:
> From: "L, Catherine" <catherine.l@intel.com>

Please use the format without comma: Catherine L.

> $ lsusb
> Bus 003 Device 003: ID 8087:0043 Intel Corp.
> 
> $ cat /sys/kernel/debug/usb/devices
> T:  Bus=03 Lev=01 Prnt=01 Port=09 Cnt=02 Dev#=  3 Spd=12   MxCh= 0
> D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=8087 ProdID=0043 Rev= 0.00
> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=81(I) Atr=03(Int.) MxPS=  64 Ivl=1ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> 
> Signed-off-by: L, Catherine <catherine.l@intel.com>

Ditto.

> ---
>   drivers/bluetooth/btusb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 03039ceaa77d..a4fdf6549127 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -488,6 +488,8 @@ static const struct usb_device_id quirks_table[] = {
>   	{ USB_DEVICE(0x8087, 0x0037), .driver_info = BTUSB_INTEL_COMBINED },
>   	{ USB_DEVICE(0x8087, 0x0038), .driver_info = BTUSB_INTEL_COMBINED },
>   	{ USB_DEVICE(0x8087, 0x0039), .driver_info = BTUSB_INTEL_COMBINED },
> +	/* Otter Peak2, Wildcat Lake */
> +	{ USB_DEVICE(0x8087, 0x0043), .driver_info = BTUSB_INTEL_COMBINED },

Please sort and put the comment on the same line as below.

>   	{ USB_DEVICE(0x8087, 0x0040), .driver_info = BTUSB_INTEL_COMBINED }, /* Lizard Peak 2 */
>   	{ USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
>   	{ USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED |


Kind regards,

Paul

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2)
  2026-09-02 11:07 ` Paul Menzel
@ 2026-09-02 13:24   ` L, Catherine
  2026-09-02 15:17   ` Luiz Augusto von Dentz
  1 sibling, 0 replies; 4+ messages in thread
From: L, Catherine @ 2026-09-02 13:24 UTC (permalink / raw)
  To: Paul Menzel
  Cc: marcel, luiz.dentz, linux-bluetooth, linux-kernel, K, Kiran, L

Hi Paul,
Thanks for the comments.


-----Original Message-----
From: Paul Menzel <pmenzel@molgen.mpg.de> 
Sent: 02 September 2026 16:37
To: L, Catherine <catherine.l@intel.com>
Cc: marcel@holtmann.org; luiz.dentz@gmail.com; linux-bluetooth@vger.kernel.org; linux-kernel@vger.kernel.org; K, Kiran <kiran.k@intel.com>; L@web.codeaurora.org
Subject: Re: [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2)

Dear Catherine,


Thank you for your patch.

Am 02.09.26 um 18:04 schrieb Catherine L:
> From: "L, Catherine" <catherine.l@intel.com>

Please use the format without comma: Catherine L.
Ack, Will change in v2 patch

> $ lsusb
> Bus 003 Device 003: ID 8087:0043 Intel Corp.
> 
> $ cat /sys/kernel/debug/usb/devices
> T:  Bus=03 Lev=01 Prnt=01 Port=09 Cnt=02 Dev#=  3 Spd=12   MxCh= 0
> D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=8087 ProdID=0043 Rev= 0.00
> C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=81(I) Atr=03(Int.) MxPS=  64 Ivl=1ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> 
> Signed-off-by: L, Catherine <catherine.l@intel.com>

Ditto.
Ack, Will change in v2 patch

> ---
>   drivers/bluetooth/btusb.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c 
> index 03039ceaa77d..a4fdf6549127 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -488,6 +488,8 @@ static const struct usb_device_id quirks_table[] = {
>   	{ USB_DEVICE(0x8087, 0x0037), .driver_info = BTUSB_INTEL_COMBINED },
>   	{ USB_DEVICE(0x8087, 0x0038), .driver_info = BTUSB_INTEL_COMBINED },
>   	{ USB_DEVICE(0x8087, 0x0039), .driver_info = BTUSB_INTEL_COMBINED 
> },
> +	/* Otter Peak2, Wildcat Lake */
> +	{ USB_DEVICE(0x8087, 0x0043), .driver_info = BTUSB_INTEL_COMBINED },

Please sort and put the comment on the same line as below.
Ack, Will change in v2 patch

>   	{ USB_DEVICE(0x8087, 0x0040), .driver_info = BTUSB_INTEL_COMBINED }, /* Lizard Peak 2 */
>   	{ USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
>   	{ USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED |


Kind regards,

Paul

Regards,
Catherine L

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2)
  2026-09-02 11:07 ` Paul Menzel
  2026-09-02 13:24   ` L, Catherine
@ 2026-09-02 15:17   ` Luiz Augusto von Dentz
  1 sibling, 0 replies; 4+ messages in thread
From: Luiz Augusto von Dentz @ 2026-09-02 15:17 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Catherine L, marcel, linux-bluetooth, linux-kernel, kiran.k, L

Hi Paul,

On Wed, Sep 2, 2026 at 7:07 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> Dear Catherine,
>
>
> Thank you for your patch.
>
> Am 02.09.26 um 18:04 schrieb Catherine L:
> > From: "L, Catherine" <catherine.l@intel.com>
>
> Please use the format without comma: Catherine L.
>
> > $ lsusb
> > Bus 003 Device 003: ID 8087:0043 Intel Corp.
> >
> > $ cat /sys/kernel/debug/usb/devices
> > T:  Bus=03 Lev=01 Prnt=01 Port=09 Cnt=02 Dev#=  3 Spd=12   MxCh= 0
> > D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> > P:  Vendor=8087 ProdID=0043 Rev= 0.00
> > C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
> > I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=81(I) Atr=03(Int.) MxPS=  64 Ivl=1ms
> > E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> > E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
> > I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> > E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> > E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms
> >
> > Signed-off-by: L, Catherine <catherine.l@intel.com>
>
> Ditto.
>
> > ---
> >   drivers/bluetooth/btusb.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 03039ceaa77d..a4fdf6549127 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -488,6 +488,8 @@ static const struct usb_device_id quirks_table[] = {
> >       { USB_DEVICE(0x8087, 0x0037), .driver_info = BTUSB_INTEL_COMBINED },
> >       { USB_DEVICE(0x8087, 0x0038), .driver_info = BTUSB_INTEL_COMBINED },
> >       { USB_DEVICE(0x8087, 0x0039), .driver_info = BTUSB_INTEL_COMBINED },
> > +     /* Otter Peak2, Wildcat Lake */
> > +     { USB_DEVICE(0x8087, 0x0043), .driver_info = BTUSB_INTEL_COMBINED },
>
> Please sort and put the comment on the same line as below.

That's not a good idea, we still have the 80-column limit for the
Bluetooth subsystem.

> >       { USB_DEVICE(0x8087, 0x0040), .driver_info = BTUSB_INTEL_COMBINED }, /* Lizard Peak 2 */
> >       { USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
> >       { USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED |
>
>
> Kind regards,
>
> Paul



-- 
Luiz Augusto von Dentz

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2)
@ 2026-09-02 16:04 Catherine L
  2026-09-02 11:07 ` Paul Menzel
  0 siblings, 1 reply; 4+ messages in thread
From: Catherine L @ 2026-09-02 16:04 UTC (permalink / raw)
  To: marcel, luiz.dentz, linux-bluetooth, linux-kernel
  Cc: kiran.k, L, Catherine, L

From: "L, Catherine" <catherine.l@intel.com>

$ lsusb
Bus 003 Device 003: ID 8087:0043 Intel Corp.

$ cat /sys/kernel/debug/usb/devices
T:  Bus=03 Lev=01 Prnt=01 Port=09 Cnt=02 Dev#=  3 Spd=12   MxCh= 0
D:  Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
P:  Vendor=8087 ProdID=0043 Rev= 0.00
C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=81(I) Atr=03(Int.) MxPS=  64 Ivl=1ms
E:  Ad=02(O) Atr=02(Bulk) MxPS=  64 Ivl=0ms
E:  Ad=82(I) Atr=02(Bulk) MxPS=  64 Ivl=0ms
I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E:  Ad=03(O) Atr=01(Isoc) MxPS=   0 Ivl=1ms
E:  Ad=83(I) Atr=01(Isoc) MxPS=   0 Ivl=1ms

Signed-off-by: L, Catherine <catherine.l@intel.com>
---
 drivers/bluetooth/btusb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 03039ceaa77d..a4fdf6549127 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -488,6 +488,8 @@ static const struct usb_device_id quirks_table[] = {
 	{ USB_DEVICE(0x8087, 0x0037), .driver_info = BTUSB_INTEL_COMBINED },
 	{ USB_DEVICE(0x8087, 0x0038), .driver_info = BTUSB_INTEL_COMBINED },
 	{ USB_DEVICE(0x8087, 0x0039), .driver_info = BTUSB_INTEL_COMBINED },
+	/* Otter Peak2, Wildcat Lake */
+	{ USB_DEVICE(0x8087, 0x0043), .driver_info = BTUSB_INTEL_COMBINED },
 	{ USB_DEVICE(0x8087, 0x0040), .driver_info = BTUSB_INTEL_COMBINED }, /* Lizard Peak 2 */
 	{ USB_DEVICE(0x8087, 0x07da), .driver_info = BTUSB_CSR },
 	{ USB_DEVICE(0x8087, 0x07dc), .driver_info = BTUSB_INTEL_COMBINED |
-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-02 15:17 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-02 16:04 [PATCH v1] Bluetooth: btusb: Add support for Intel Otter Peak2 (OrP2) Catherine L
2026-09-02 11:07 ` Paul Menzel
2026-09-02 13:24   ` L, Catherine
2026-09-02 15:17   ` Luiz Augusto von Dentz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®